]> git.r.bdr.sh - rbdr/mobius/commitdiff
Fix mutex lock bug on invalid client
authorJeff Halter <redacted>
Mon, 21 Nov 2022 16:21:24 +0000 (08:21 -0800)
committerJeff Halter <redacted>
Mon, 21 Nov 2022 16:21:24 +0000 (08:21 -0800)
hotline/server.go

index bd15a2ecea697b8ed88a2e34c29e870b6866e034..e28ff9a597dc93ef7f8a6d06d0430290150dd14d 100644 (file)
@@ -152,13 +152,12 @@ func (s *Server) sendTransaction(t Transaction) error {
        }
 
        s.mux.Lock()
+       defer s.mux.Unlock()
        client := s.Clients[uint16(clientID)]
        if client == nil {
                return fmt.Errorf("invalid client id %v", *t.clientID)
        }
 
-       s.mux.Unlock()
-
        b, err := t.MarshalBinary()
        if err != nil {
                return err