Fix failing test, replace use of reflect package with assert

diff --git a/hotline/file_name_with_info_test.go b/hotline/file_name_with_info_test.go
index d1b03c20f842884a812a394b9da595d64538cb16..5095acf53b37b1ebff950ba0ede5d7305f79bec2 100644 (file)
--- a/hotline/file_name_with_info_test.go
+++ b/hotline/file_name_with_info_test.go
@@ -3,7 +3,6 @@ package hotline
 import (
        "github.com/stretchr/testify/assert"
        "io"
-       "reflect"
        "testing"
 )
 
@@ -54,7 +53,7 @@ func TestFileNameWithInfo_MarshalBinary(t *testing.T) {
                                t.Errorf("MarshalBinary() error = %v, wantErr %v", err, tt.wantErr)
                                return
                        }
-                       if !reflect.DeepEqual(gotData, tt.wantData) {
+                       if !assert.Equal(t, tt.wantData, gotData) {
                                t.Errorf("MarshalBinary() gotData = %v, want %v", gotData, tt.wantData)
                        }
                })

diff --git a/hotline/file_transfer_test.go b/hotline/file_transfer_test.go
index b1236b650c7fb3513af13137f98163ede5598639..0b549f86a60c960b19d831d243d2dd40b0e6dd90 100644 (file)
--- a/hotline/file_transfer_test.go
+++ b/hotline/file_transfer_test.go
@@ -4,7 +4,6 @@ import (
        "encoding/binary"
        "github.com/stretchr/testify/assert"
        "io"
-       "reflect"
        "testing"
 )
 
@@ -127,7 +126,7 @@ func TestNewFileHeader(t *testing.T) {
        }
        for _, tt := range tests {
                t.Run(tt.name, func(t *testing.T) {
-                       if got := NewFileHeader(tt.args.fileName, tt.args.isDir); !reflect.DeepEqual(got, tt.want) {
+                       if got := NewFileHeader(tt.args.fileName, tt.args.isDir); !assert.Equal(t, tt.want, got) {
                                t.Errorf("NewFileHeader() = %v, want %v", got, tt.want)
                        }
                })
@@ -170,7 +169,7 @@ func TestFileHeader_Payload(t *testing.T) {
                                FilePath: tt.fields.FilePath,
                        }
                        got, _ := io.ReadAll(fh)
-                       if !reflect.DeepEqual(got, tt.want) {
+                       if !assert.Equal(t, tt.want, got) {
                                t.Errorf("Read() = %v, want %v", got, tt.want)
                        }
                })

diff --git a/hotline/files_test.go b/hotline/files_test.go
index 4c8ef80fd42a8a6e439bc0b353137a43ae78f0c5..0a7eb7b5537b4e44165d6a379d8e6d4af98b1f0d 100644 (file)
--- a/hotline/files_test.go
+++ b/hotline/files_test.go
@@ -3,9 +3,9 @@ package hotline
 import (
        "bytes"
        "encoding/binary"
+       "github.com/stretchr/testify/assert"
        "os"
        "path/filepath"
-       "reflect"
        "testing"
 )
 
@@ -77,7 +77,7 @@ func TestCalcTotalSize(t *testing.T) {
                                t.Errorf("CalcTotalSize() error = %v, wantErr %v", err, tt.wantErr)
                                return
                        }
-                       if !reflect.DeepEqual(got, tt.want) {
+                       if !assert.Equal(t, tt.want, got) {
                                t.Errorf("CalcTotalSize() got = %v, want %v", got, tt.want)
                        }
                })

diff --git a/hotline/tracker_test.go b/hotline/tracker_test.go
index 14c0363e7b25472f2e5585eac873b14100e71d7d..5457e473ac5c773331b4e04f307d5267e4dab90c 100644 (file)
--- a/hotline/tracker_test.go
+++ b/hotline/tracker_test.go
@@ -6,7 +6,6 @@ import (
        "github.com/stretchr/testify/assert"
        "github.com/stretchr/testify/require"
        "io"
-       "reflect"
        "testing"
 )
 
@@ -42,6 +41,7 @@ func TestTrackerRegistration_Payload(t *testing.T) {
                                0x54, 0x65, 0x73, 0x74, 0x20, 0x53, 0x65, 0x72, 0x76,
                                0x04,
                                0x46, 0x6f, 0x6f, 0x7a,
+                               0x00,
                        },
                },
        }
@@ -55,7 +55,7 @@ func TestTrackerRegistration_Payload(t *testing.T) {
                                Description: tt.fields.Description,
                        }
 
-                       if got, _ := io.ReadAll(tr); !reflect.DeepEqual(got, tt.want) {
+                       if got, _ := io.ReadAll(tr); !assert.Equal(t, tt.want, got) {
                                t.Errorf("Read() = %v, want %v", got, tt.want)
                        }
                })