28 userIdleSeconds = 300 // time in seconds before an inactive user is marked idle
29 idleCheckInterval = 10 // time in seconds to check for idle users
30 trackerUpdateFrequency = 300 // time in seconds between tracker re-registration
35 Accounts map[string]*Account
37 Clients map[uint16]*ClientConn
39 ThreadedNews *ThreadedNews
40 FileTransfers map[uint32]*FileTransfer
43 Logger *zap.SugaredLogger
44 PrivateChats map[uint32]*PrivateChat
49 APIListener net.Listener
50 FileListener net.Listener
52 // newsReader io.Reader
53 // newsWriter io.WriteCloser
55 outbox chan Transaction
58 flatNewsMux sync.Mutex
61 type PrivateChat struct {
63 ClientConn map[uint16]*ClientConn
66 func (s *Server) ListenAndServe(ctx context.Context, cancelRoot context.CancelFunc) error {
67 s.Logger.Infow("Hotline server started", "version", VERSION)
71 go func() { s.Logger.Fatal(s.Serve(ctx, cancelRoot, s.APIListener)) }()
74 go func() { s.Logger.Fatal(s.ServeFileTransfers(s.FileListener)) }()
81 func (s *Server) APIPort() int {
82 return s.APIListener.Addr().(*net.TCPAddr).Port
85 func (s *Server) ServeFileTransfers(ln net.Listener) error {
86 s.Logger.Infow("Hotline file transfer server started", "Addr", fmt.Sprintf(":%v", s.Port+1))
89 conn, err := ln.Accept()
95 if err := s.handleFileTransfer(conn); err != nil {
96 s.Logger.Errorw("file transfer error", "reason", err)
102 func (s *Server) sendTransaction(t Transaction) error {
103 requestNum := binary.BigEndian.Uint16(t.Type)
104 clientID, err := byteToInt(*t.clientID)
110 client := s.Clients[uint16(clientID)]
113 return fmt.Errorf("invalid client id %v", *t.clientID)
115 userName := string(client.UserName)
116 login := client.Account.Login
118 handler := TransactionHandlers[requestNum]
120 b, err := t.MarshalBinary()
125 if n, err = client.Connection.Write(b); err != nil {
128 s.Logger.Debugw("Sent Transaction",
131 "IsReply", t.IsReply,
132 "type", handler.Name,
134 "remoteAddr", client.Connection.RemoteAddr(),
139 func (s *Server) Serve(ctx context.Context, cancelRoot context.CancelFunc, ln net.Listener) error {
140 s.Logger.Infow("Hotline server started", "Addr", fmt.Sprintf(":%v", s.Port))
143 conn, err := ln.Accept()
145 s.Logger.Errorw("error accepting connection", "err", err)
152 if err := s.sendTransaction(t); err != nil {
153 s.Logger.Errorw("error sending transaction", "err", err)
159 if err := s.handleNewConnection(conn); err != nil {
161 s.Logger.Infow("Client disconnected", "RemoteAddr", conn.RemoteAddr())
163 s.Logger.Errorw("error serving request", "RemoteAddr", conn.RemoteAddr(), "err", err)
171 agreementFile = "Agreement.txt"
174 // NewServer constructs a new Server from a config dir
175 func NewServer(configDir, netInterface string, netPort int, logger *zap.SugaredLogger) (*Server, error) {
178 Accounts: make(map[string]*Account),
180 Clients: make(map[uint16]*ClientConn),
181 FileTransfers: make(map[uint32]*FileTransfer),
182 PrivateChats: make(map[uint32]*PrivateChat),
183 ConfigDir: configDir,
185 NextGuestID: new(uint16),
186 outbox: make(chan Transaction),
187 Stats: &Stats{StartTime: time.Now()},
188 ThreadedNews: &ThreadedNews{},
189 TrackerPassID: make([]byte, 4),
192 ln, err := net.Listen("tcp", fmt.Sprintf("%s:%v", netInterface, netPort))
196 server.APIListener = ln
202 ln2, err := net.Listen("tcp", fmt.Sprintf("%s:%v", netInterface, netPort))
203 server.FileListener = ln2
208 // generate a new random passID for tracker registration
209 if _, err := rand.Read(server.TrackerPassID); err != nil {
213 server.Logger.Debugw("Loading Agreement", "path", configDir+agreementFile)
214 if server.Agreement, err = os.ReadFile(configDir + agreementFile); err != nil {
218 if server.FlatNews, err = os.ReadFile(configDir + "MessageBoard.txt"); err != nil {
222 if err := server.loadThreadedNews(configDir + "ThreadedNews.yaml"); err != nil {
226 if err := server.loadConfig(configDir + "config.yaml"); err != nil {
230 if err := server.loadAccounts(configDir + "Users/"); err != nil {
234 server.Config.FileRoot = configDir + "Files/"
236 *server.NextGuestID = 1
238 if server.Config.EnableTrackerRegistration {
241 tr := TrackerRegistration{
242 Port: []byte{0x15, 0x7c},
243 UserCount: server.userCount(),
244 PassID: server.TrackerPassID,
245 Name: server.Config.Name,
246 Description: server.Config.Description,
248 for _, t := range server.Config.Trackers {
249 server.Logger.Infof("Registering with tracker %v", t)
251 if err := register(t, tr); err != nil {
252 server.Logger.Errorw("unable to register with tracker %v", "error", err)
256 time.Sleep(trackerUpdateFrequency * time.Second)
261 // Start Client Keepalive go routine
262 go server.keepaliveHandler()
267 func (s *Server) userCount() int {
271 return len(s.Clients)
274 func (s *Server) keepaliveHandler() {
276 time.Sleep(idleCheckInterval * time.Second)
279 for _, c := range s.Clients {
280 c.IdleTime += idleCheckInterval
281 if c.IdleTime > userIdleSeconds && !c.Idle {
284 flagBitmap := big.NewInt(int64(binary.BigEndian.Uint16(*c.Flags)))
285 flagBitmap.SetBit(flagBitmap, userFlagAway, 1)
286 binary.BigEndian.PutUint16(*c.Flags, uint16(flagBitmap.Int64()))
289 tranNotifyChangeUser,
290 NewField(fieldUserID, *c.ID),
291 NewField(fieldUserFlags, *c.Flags),
292 NewField(fieldUserName, c.UserName),
293 NewField(fieldUserIconID, *c.Icon),
301 func (s *Server) writeThreadedNews() error {
305 out, err := yaml.Marshal(s.ThreadedNews)
309 err = ioutil.WriteFile(
310 s.ConfigDir+"ThreadedNews.yaml",
317 func (s *Server) NewClientConn(conn net.Conn) *ClientConn {
321 clientConn := &ClientConn{
324 Flags: &[]byte{0, 0},
330 Transfers: make(map[int][]*FileTransfer),
336 binary.BigEndian.PutUint16(*clientConn.ID, ID)
337 s.Clients[ID] = clientConn
342 // NewUser creates a new user account entry in the server map and config file
343 func (s *Server) NewUser(login, name, password string, access []byte) error {
350 Password: hashAndSalt([]byte(password)),
353 out, err := yaml.Marshal(&account)
357 s.Accounts[login] = &account
359 return FS.WriteFile(s.ConfigDir+"Users/"+login+".yaml", out, 0666)
362 // DeleteUser deletes the user account
363 func (s *Server) DeleteUser(login string) error {
367 delete(s.Accounts, login)
369 return FS.Remove(s.ConfigDir + "Users/" + login + ".yaml")
372 func (s *Server) connectedUsers() []Field {
376 var connectedUsers []Field
377 for _, c := range sortedClients(s.Clients) {
385 Name: string(c.UserName),
387 connectedUsers = append(connectedUsers, NewField(fieldUsernameWithInfo, user.Payload()))
389 return connectedUsers
392 // loadThreadedNews loads the threaded news data from disk
393 func (s *Server) loadThreadedNews(threadedNewsPath string) error {
394 fh, err := os.Open(threadedNewsPath)
398 decoder := yaml.NewDecoder(fh)
400 return decoder.Decode(s.ThreadedNews)
403 // loadAccounts loads account data from disk
404 func (s *Server) loadAccounts(userDir string) error {
405 matches, err := filepath.Glob(path.Join(userDir, "*.yaml"))
410 if len(matches) == 0 {
411 return errors.New("no user accounts found in " + userDir)
414 for _, file := range matches {
415 fh, err := FS.Open(file)
421 decoder := yaml.NewDecoder(fh)
422 if err := decoder.Decode(&account); err != nil {
426 s.Accounts[account.Login] = &account
431 func (s *Server) loadConfig(path string) error {
432 fh, err := FS.Open(path)
437 decoder := yaml.NewDecoder(fh)
438 err = decoder.Decode(s.Config)
446 minTransactionLen = 22 // minimum length of any transaction
449 // handleNewConnection takes a new net.Conn and performs the initial login sequence
450 func (s *Server) handleNewConnection(conn net.Conn) error {
451 handshakeBuf := make([]byte, 12) // handshakes are always 12 bytes in length
452 if _, err := conn.Read(handshakeBuf); err != nil {
455 if err := Handshake(conn, handshakeBuf[:12]); err != nil {
459 buf := make([]byte, 1024)
460 readLen, err := conn.Read(buf)
461 if readLen < minTransactionLen {
468 clientLogin, _, err := ReadTransaction(buf[:readLen])
473 c := s.NewClientConn(conn)
476 if r := recover(); r != nil {
477 fmt.Println("stacktrace from panic: \n" + string(debug.Stack()))
478 c.Server.Logger.Errorw("PANIC", "err", r, "trace", string(debug.Stack()))
483 encodedLogin := clientLogin.GetField(fieldUserLogin).Data
484 encodedPassword := clientLogin.GetField(fieldUserPassword).Data
485 *c.Version = clientLogin.GetField(fieldVersion).Data
488 for _, char := range encodedLogin {
489 login += string(rune(255 - uint(char)))
495 // If authentication fails, send error reply and close connection
496 if !c.Authenticate(login, encodedPassword) {
497 t := c.NewErrReply(clientLogin, "Incorrect login.")
498 b, err := t.MarshalBinary()
502 if _, err := conn.Write(b); err != nil {
505 return fmt.Errorf("incorrect login")
508 if clientLogin.GetField(fieldUserName).Data != nil {
509 c.UserName = clientLogin.GetField(fieldUserName).Data
512 if clientLogin.GetField(fieldUserIconID).Data != nil {
513 *c.Icon = clientLogin.GetField(fieldUserIconID).Data
516 c.Account = c.Server.Accounts[login]
518 if c.Authorize(accessDisconUser) {
519 *c.Flags = []byte{0, 2}
522 s.Logger.Infow("Client connection received", "login", login, "version", *c.Version, "RemoteAddr", conn.RemoteAddr().String())
524 s.outbox <- c.NewReply(clientLogin,
525 NewField(fieldVersion, []byte{0x00, 0xbe}),
526 NewField(fieldCommunityBannerID, []byte{0x00, 0x01}),
527 NewField(fieldServerName, []byte(s.Config.Name)),
530 // Send user access privs so client UI knows how to behave
531 c.Server.outbox <- *NewTransaction(tranUserAccess, c.ID, NewField(fieldUserAccess, *c.Account.Access))
533 // Show agreement to client
534 c.Server.outbox <- *NewTransaction(tranShowAgreement, c.ID, NewField(fieldData, s.Agreement))
536 // assume simplified hotline v1.2.3 login flow that does not require agreement
537 if *c.Version == nil {
542 tranNotifyChangeUser, nil,
543 NewField(fieldUserName, c.UserName),
544 NewField(fieldUserID, *c.ID),
545 NewField(fieldUserIconID, *c.Icon),
546 NewField(fieldUserFlags, *c.Flags),
551 c.Server.Stats.LoginCount += 1
553 const readBuffSize = 1024000 // 1KB - TODO: what should this be?
554 tranBuff := make([]byte, 0)
556 // Infinite loop where take action on incoming client requests until the connection is closed
558 buf = make([]byte, readBuffSize)
559 tranBuff = tranBuff[tReadlen:]
561 readLen, err := c.Connection.Read(buf)
565 tranBuff = append(tranBuff, buf[:readLen]...)
567 // We may have read multiple requests worth of bytes from Connection.Read. readTransactions splits them
568 // into a slice of transactions
569 var transactions []Transaction
570 if transactions, tReadlen, err = readTransactions(tranBuff); err != nil {
571 c.Server.Logger.Errorw("Error handling transaction", "err", err)
574 // iterate over all of the transactions that were parsed from the byte slice and handle them
575 for _, t := range transactions {
576 if err := c.handleTransaction(&t); err != nil {
577 c.Server.Logger.Errorw("Error handling transaction", "err", err)
583 // NewTransactionRef generates a random ID for the file transfer. The Hotline client includes this ID
584 // in the file transfer request payload, and the file transfer server will use it to map the request
586 func (s *Server) NewTransactionRef() []byte {
587 transactionRef := make([]byte, 4)
588 rand.Read(transactionRef)
590 return transactionRef
593 func (s *Server) NewPrivateChat(cc *ClientConn) []byte {
597 randID := make([]byte, 4)
599 data := binary.BigEndian.Uint32(randID[:])
601 s.PrivateChats[data] = &PrivateChat{
603 ClientConn: make(map[uint16]*ClientConn),
605 s.PrivateChats[data].ClientConn[cc.uint16ID()] = cc
610 const dlFldrActionSendFile = 1
611 const dlFldrActionResumeFile = 2
612 const dlFldrActionNextFile = 3
614 // handleFileTransfer receives a client net.Conn from the file transfer server, performs the requested transfer type, then closes the connection
615 func (s *Server) handleFileTransfer(conn io.ReadWriteCloser) error {
617 if err := conn.Close(); err != nil {
618 s.Logger.Errorw("error closing connection", "error", err)
622 txBuf := make([]byte, 16)
623 _, err := conn.Read(txBuf)
629 _, err = t.Write(txBuf)
634 transferRefNum := binary.BigEndian.Uint32(t.ReferenceNumber[:])
635 fileTransfer := s.FileTransfers[transferRefNum]
637 // delete single use transferRefNum
638 delete(s.FileTransfers, transferRefNum)
640 switch fileTransfer.Type {
642 fullFilePath, err := readPath(s.Config.FileRoot, fileTransfer.FilePath, fileTransfer.FileName)
648 if fileTransfer.fileResumeData != nil {
649 dataOffset = int64(binary.BigEndian.Uint32(fileTransfer.fileResumeData.ForkInfoList[0].DataSize[:]))
652 ffo, err := NewFlattenedFileObject(s.Config.FileRoot, fileTransfer.FilePath, fileTransfer.FileName, dataOffset)
657 s.Logger.Infow("File download started", "filePath", fullFilePath, "transactionRef", fileTransfer.ReferenceNumber)
659 // Start by sending flat file object to client
660 if _, err := conn.Write(ffo.BinaryMarshal()); err != nil {
664 file, err := FS.Open(fullFilePath)
669 sendBuffer := make([]byte, 1048576)
673 if bytesRead, err = file.ReadAt(sendBuffer, dataOffset+totalSent); err == io.EOF {
674 if _, err := conn.Write(sendBuffer[:bytesRead]); err != nil {
682 totalSent += int64(bytesRead)
684 fileTransfer.BytesSent += bytesRead
686 if _, err := conn.Write(sendBuffer[:bytesRead]); err != nil {
691 destinationFile := s.Config.FileRoot + ReadFilePath(fileTransfer.FilePath) + "/" + string(fileTransfer.FileName)
692 tmpFile := destinationFile + ".incomplete"
694 file, err := effectiveFile(destinationFile)
695 if errors.Is(err, fs.ErrNotExist) {
696 file, err = FS.Create(tmpFile)
702 defer func() { _ = file.Close() }()
704 s.Logger.Infow("File upload started", "transactionRef", fileTransfer.ReferenceNumber, "dstFile", destinationFile)
706 // TODO: replace io.Discard with a real file when ready to implement storing of resource fork data
707 if err := receiveFile(conn, file, io.Discard); err != nil {
711 if err := os.Rename(destinationFile+".incomplete", destinationFile); err != nil {
715 s.Logger.Infow("File upload complete", "transactionRef", fileTransfer.ReferenceNumber, "dstFile", destinationFile)
717 // Folder Download flow:
718 // 1. Get filePath from the transfer
719 // 2. Iterate over files
721 // Send file header to client
722 // The client can reply in 3 ways:
724 // 1. If type is an odd number (unknown type?), or file download for the current file is completed:
725 // client sends []byte{0x00, 0x03} to tell the server to continue to the next file
727 // 2. If download of a file is to be resumed:
729 // []byte{0x00, 0x02} // download folder action
730 // [2]byte // Resume data size
731 // []byte file resume data (see myField_FileResumeData)
733 // 3. Otherwise, download of the file is requested and client sends []byte{0x00, 0x01}
735 // When download is requested (case 2 or 3), server replies with:
736 // [4]byte - file size
737 // []byte - Flattened File Object
739 // After every file download, client could request next file with:
740 // []byte{0x00, 0x03}
742 // This notifies the server to send the next item header
744 fullFilePath, err := readPath(s.Config.FileRoot, fileTransfer.FilePath, fileTransfer.FileName)
749 basePathLen := len(fullFilePath)
751 s.Logger.Infow("Start folder download", "path", fullFilePath, "ReferenceNumber", fileTransfer.ReferenceNumber)
753 nextAction := make([]byte, 2)
754 if _, err := conn.Read(nextAction); err != nil {
759 err = filepath.Walk(fullFilePath+"/", func(path string, info os.FileInfo, err error) error {
764 subPath := path[basePathLen+1:]
765 s.Logger.Infow("Sending fileheader", "i", i, "path", path, "fullFilePath", fullFilePath, "subPath", subPath, "IsDir", info.IsDir())
771 fileHeader := NewFileHeader(subPath, info.IsDir())
773 // Send the file header to client
774 if _, err := conn.Write(fileHeader.Payload()); err != nil {
775 s.Logger.Errorf("error sending file header: %v", err)
779 // Read the client's Next Action request
780 if _, err := conn.Read(nextAction); err != nil {
784 s.Logger.Infow("Client folder download action", "action", fmt.Sprintf("%X", nextAction[0:2]))
788 switch nextAction[1] {
789 case dlFldrActionResumeFile:
790 // client asked to resume this file
791 var frd FileResumeData
792 // get size of resumeData
793 if _, err := conn.Read(nextAction); err != nil {
797 resumeDataLen := binary.BigEndian.Uint16(nextAction)
798 resumeDataBytes := make([]byte, resumeDataLen)
799 if _, err := conn.Read(resumeDataBytes); err != nil {
803 if err := frd.UnmarshalBinary(resumeDataBytes); err != nil {
806 dataOffset = int64(binary.BigEndian.Uint32(frd.ForkInfoList[0].DataSize[:]))
807 case dlFldrActionNextFile:
808 // client asked to skip this file
816 splitPath := strings.Split(path, "/")
818 ffo, err := NewFlattenedFileObject(strings.Join(splitPath[:len(splitPath)-1], "/"), nil, []byte(info.Name()), dataOffset)
822 s.Logger.Infow("File download started",
823 "fileName", info.Name(),
824 "transactionRef", fileTransfer.ReferenceNumber,
825 "TransferSize", fmt.Sprintf("%x", ffo.TransferSize()),
828 // Send file size to client
829 if _, err := conn.Write(ffo.TransferSize()); err != nil {
834 // Send ffo bytes to client
835 if _, err := conn.Write(ffo.BinaryMarshal()); err != nil {
840 file, err := FS.Open(path)
845 // // Copy N bytes from file to connection
846 // _, err = io.CopyN(conn, file, int64(binary.BigEndian.Uint32(ffo.FlatFileDataForkHeader.DataSize[:])))
851 sendBuffer := make([]byte, 1048576)
855 if bytesRead, err = file.ReadAt(sendBuffer, dataOffset+totalSent); err == io.EOF {
856 if _, err := conn.Write(sendBuffer[:bytesRead]); err != nil {
864 totalSent += int64(bytesRead)
866 fileTransfer.BytesSent += bytesRead
868 if _, err := conn.Write(sendBuffer[:bytesRead]); err != nil {
873 // TODO: optionally send resource fork header and resource fork data
875 // Read the client's Next Action request. This is always 3, I think?
876 if _, err := conn.Read(nextAction); err != nil {
884 dstPath, err := readPath(s.Config.FileRoot, fileTransfer.FilePath, fileTransfer.FileName)
889 "Folder upload started",
890 "transactionRef", fileTransfer.ReferenceNumber,
892 "TransferSize", fmt.Sprintf("%x", fileTransfer.TransferSize),
893 "FolderItemCount", fileTransfer.FolderItemCount,
896 // Check if the target folder exists. If not, create it.
897 if _, err := FS.Stat(dstPath); os.IsNotExist(err) {
898 if err := FS.Mkdir(dstPath, 0777); err != nil {
903 // Begin the folder upload flow by sending the "next file action" to client
904 if _, err := conn.Write([]byte{0, dlFldrActionNextFile}); err != nil {
908 fileSize := make([]byte, 4)
909 readBuffer := make([]byte, 1024)
911 for i := 0; i < fileTransfer.ItemCount(); i++ {
913 _, err := conn.Read(readBuffer)
917 fu := readFolderUpload(readBuffer)
920 "Folder upload continued",
921 "transactionRef", fmt.Sprintf("%x", fileTransfer.ReferenceNumber),
922 "FormattedPath", fu.FormattedPath(),
923 "IsFolder", fmt.Sprintf("%x", fu.IsFolder),
924 "PathItemCount", binary.BigEndian.Uint16(fu.PathItemCount[:]),
927 if fu.IsFolder == [2]byte{0, 1} {
928 if _, err := os.Stat(dstPath + "/" + fu.FormattedPath()); os.IsNotExist(err) {
929 if err := os.Mkdir(dstPath+"/"+fu.FormattedPath(), 0777); err != nil {
934 // Tell client to send next file
935 if _, err := conn.Write([]byte{0, dlFldrActionNextFile}); err != nil {
939 nextAction := dlFldrActionSendFile
941 // Check if we have the full file already. If so, send dlFldrAction_NextFile to client to skip.
942 _, err := os.Stat(dstPath + "/" + fu.FormattedPath())
943 if err != nil && !errors.Is(err, fs.ErrNotExist) {
947 nextAction = dlFldrActionNextFile
950 // Check if we have a partial file already. If so, send dlFldrAction_ResumeFile to client to resume upload.
951 inccompleteFile, err := os.Stat(dstPath + "/" + fu.FormattedPath() + incompleteFileSuffix)
952 if err != nil && !errors.Is(err, fs.ErrNotExist) {
956 nextAction = dlFldrActionResumeFile
959 fmt.Printf("Next Action: %v\n", nextAction)
961 if _, err := conn.Write([]byte{0, uint8(nextAction)}); err != nil {
966 case dlFldrActionNextFile:
968 case dlFldrActionResumeFile:
969 offset := make([]byte, 4)
970 binary.BigEndian.PutUint32(offset, uint32(inccompleteFile.Size()))
972 file, err := os.OpenFile(dstPath+"/"+fu.FormattedPath()+incompleteFileSuffix, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0644)
977 fileResumeData := NewFileResumeData([]ForkInfoList{
978 *NewForkInfoList(offset),
981 b, _ := fileResumeData.BinaryMarshal()
983 bs := make([]byte, 2)
984 binary.BigEndian.PutUint16(bs, uint16(len(b)))
986 if _, err := conn.Write(append(bs, b...)); err != nil {
990 if _, err := conn.Read(fileSize); err != nil {
994 if err := receiveFile(conn, file, ioutil.Discard); err != nil {
998 err = os.Rename(dstPath+"/"+fu.FormattedPath()+".incomplete", dstPath+"/"+fu.FormattedPath())
1003 case dlFldrActionSendFile:
1004 if _, err := conn.Read(fileSize); err != nil {
1008 filePath := dstPath + "/" + fu.FormattedPath()
1009 s.Logger.Infow("Starting file transfer", "path", filePath, "fileNum", i+1, "totalFiles", "zz", "fileSize", binary.BigEndian.Uint32(fileSize))
1011 newFile, err := FS.Create(filePath + ".incomplete")
1016 if err := receiveFile(conn, newFile, ioutil.Discard); err != nil {
1020 if err := os.Rename(filePath+".incomplete", filePath); err != nil {
1025 // Tell client to send next file
1026 if _, err := conn.Write([]byte{0, dlFldrActionNextFile}); err != nil {
1031 s.Logger.Infof("Folder upload complete")
1037 // sortedClients is a utility function that takes a map of *ClientConn and returns a sorted slice of the values.
1038 // The purpose of this is to ensure that the ordering of client connections is deterministic so that test assertions work.
1039 func sortedClients(unsortedClients map[uint16]*ClientConn) (clients []*ClientConn) {
1040 for _, c := range unsortedClients {
1041 clients = append(clients, c)
1043 sort.Sort(byClientID(clients))