aboutsummaryrefslogtreecommitdiff
path: root/hotline/access_test.go
blob: fa2f6f62523e8f1274591d62abf3eb593e377779 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
package hotline

import (
	"github.com/stretchr/testify/assert"
	"github.com/stretchr/testify/require"
	"gopkg.in/yaml.v3"
	"strings"
	"testing"
)

func Test_accessBitmap_IsSet(t *testing.T) {
	type args struct {
		i int
	}
	tests := []struct {
		name string
		bits AccessBitmap
		args args
		want bool
	}{
		{
			name: "returns true when bit is set",
			bits: func() (access AccessBitmap) {
				access.Set(22)
				return access
			}(),
			args: args{i: 22},
			want: true,
		},
		{
			name: "returns false when bit is unset",
			bits: AccessBitmap{},
			args: args{i: 22},
			want: false,
		},
	}
	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			assert.Equalf(t, tt.want, tt.bits.IsSet(tt.args.i), "IsSet(%v)", tt.args.i)
		})
	}
}

func Test_accessBitmap_UnmarshalYAML(t *testing.T) {
	// Test direct method call for explicit coverage
	t.Run("direct method call", func(t *testing.T) {
		var bits AccessBitmap
		err := bits.UnmarshalYAML(func(v interface{}) error {
			switch ptr := v.(type) {
			case *interface{}:
				*ptr = map[string]interface{}{
					"DownloadFile": true,
					"UploadFile":   true,
				}
			}
			return nil
		})
		require.NoError(t, err)
		assert.True(t, bits.IsSet(AccessDownloadFile))
		assert.True(t, bits.IsSet(AccessUploadFile))
	})

	// Original YAML unmarshaling tests
	tests := []struct {
		name     string
		yamlData string
		expected AccessBitmap
		wantErr  bool
	}{
		{
			name:     "unmarshal array format (legacy)",
			yamlData: "access: [96, 112, 12, 32, 3, 128, 0, 0]",
			expected: AccessBitmap{96, 112, 12, 32, 3, 128, 0, 0},
			wantErr:  false,
		},
		{
			name: "unmarshal map format with true values",
			yamlData: `access:
  DownloadFile: true
  UploadFile: true
  DeleteFile: true`,
			expected: func() AccessBitmap {
				var bits AccessBitmap
				bits.Set(AccessDownloadFile)
				bits.Set(AccessUploadFile)
				bits.Set(AccessDeleteFile)
				return bits
			}(),
			wantErr: false,
		},
		{
			name: "unmarshal map format with false values",
			yamlData: `access:
  DownloadFile: false
  UploadFile: false
  DeleteFile: false`,
			expected: AccessBitmap{},
			wantErr:  false,
		},
		{
			name: "unmarshal map format with mixed values",
			yamlData: `access:
  DownloadFile: true
  UploadFile: false
  DeleteFile: true
  CreateFolder: true`,
			expected: func() AccessBitmap {
				var bits AccessBitmap
				bits.Set(AccessDownloadFile)
				bits.Set(AccessDeleteFile)
				bits.Set(AccessCreateFolder)
				return bits
			}(),
			wantErr: false,
		},
		{
			name: "unmarshal map format with all permissions",
			yamlData: `access:
  DeleteFile: true
  UploadFile: true
  DownloadFile: true
  RenameFile: true
  MoveFile: true
  CreateFolder: true
  DeleteFolder: true
  RenameFolder: true
  MoveFolder: true
  ReadChat: true
  SendChat: true
  OpenChat: true
  CloseChat: true
  ShowInList: true
  CreateUser: true
  DeleteUser: true
  OpenUser: true
  ModifyUser: true
  ChangeOwnPass: true
  NewsReadArt: true
  NewsPostArt: true
  DisconnectUser: true
  CannotBeDisconnected: true
  GetClientInfo: true
  UploadAnywhere: true
  AnyName: true
  NoAgreement: true
  SetFileComment: true
  SetFolderComment: true
  ViewDropBoxes: true
  MakeAlias: true
  Broadcast: true
  NewsDeleteArt: true
  NewsCreateCat: true
  NewsDeleteCat: true
  NewsCreateFldr: true
  NewsDeleteFldr: true
  SendPrivMsg: true
  UploadFolder: true
  DownloadFolder: true`,
			expected: func() AccessBitmap {
				var bits AccessBitmap
				bits.Set(AccessDeleteFile)
				bits.Set(AccessUploadFile)
				bits.Set(AccessDownloadFile)
				bits.Set(AccessRenameFile)
				bits.Set(AccessMoveFile)
				bits.Set(AccessCreateFolder)
				bits.Set(AccessDeleteFolder)
				bits.Set(AccessRenameFolder)
				bits.Set(AccessMoveFolder)
				bits.Set(AccessReadChat)
				bits.Set(AccessSendChat)
				bits.Set(AccessOpenChat)
				bits.Set(AccessCloseChat)
				bits.Set(AccessShowInList)
				bits.Set(AccessCreateUser)
				bits.Set(AccessDeleteUser)
				bits.Set(AccessOpenUser)
				bits.Set(AccessModifyUser)
				bits.Set(AccessChangeOwnPass)
				bits.Set(AccessNewsReadArt)
				bits.Set(AccessNewsPostArt)
				bits.Set(AccessDisconUser)
				bits.Set(AccessCannotBeDiscon)
				bits.Set(AccessGetClientInfo)
				bits.Set(AccessUploadAnywhere)
				bits.Set(AccessAnyName)
				bits.Set(AccessNoAgreement)
				bits.Set(AccessSetFileComment)
				bits.Set(AccessSetFolderComment)
				bits.Set(AccessViewDropBoxes)
				bits.Set(AccessMakeAlias)
				bits.Set(AccessBroadcast)
				bits.Set(AccessNewsDeleteArt)
				bits.Set(AccessNewsCreateCat)
				bits.Set(AccessNewsDeleteCat)
				bits.Set(AccessNewsCreateFldr)
				bits.Set(AccessNewsDeleteFldr)
				bits.Set(AccessSendPrivMsg)
				bits.Set(AccessUploadFolder)
				bits.Set(AccessDownloadFolder)
				return bits
			}(),
			wantErr: false,
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			var data struct {
				Access AccessBitmap `yaml:"access"`
			}

			err := yaml.Unmarshal([]byte(tt.yamlData), &data)

			if tt.wantErr {
				require.Error(t, err)
				return
			}

			require.NoError(t, err)
			assert.Equal(t, tt.expected, data.Access)
		})
	}
}

func Test_accessBitmap_MarshalYAML(t *testing.T) {
	tests := []struct {
		name     string
		bits     AccessBitmap
		expected string
	}{
		{
			name: "empty access bitmap",
			bits: AccessBitmap{},
			expected: `    DownloadFile: false
    DownloadFolder: false
    UploadFile: false
    UploadFolder: false
    DeleteFile: false
    RenameFile: false
    MoveFile: false
    CreateFolder: false
    DeleteFolder: false
    RenameFolder: false
    MoveFolder: false
    ReadChat: false
    SendChat: false
    OpenChat: false
    CloseChat: false
    ShowInList: false
    CreateUser: false
    DeleteUser: false
    OpenUser: false
    ModifyUser: false
    ChangeOwnPass: false
    NewsReadArt: false
    NewsPostArt: false
    DisconnectUser: false
    CannotBeDisconnected: false
    GetClientInfo: false
    UploadAnywhere: false
    AnyName: false
    NoAgreement: false
    SetFileComment: false
    SetFolderComment: false
    ViewDropBoxes: false
    MakeAlias: false
    Broadcast: false
    NewsDeleteArt: false
    NewsCreateCat: false
    NewsDeleteCat: false
    NewsCreateFldr: false
    NewsDeleteFldr: false
    SendPrivMsg: false
`,
		},
		{
			name: "access bitmap with some permissions",
			bits: func() AccessBitmap {
				var bits AccessBitmap
				bits.Set(AccessDownloadFile)
				bits.Set(AccessUploadFile)
				bits.Set(AccessCreateFolder)
				bits.Set(AccessReadChat)
				return bits
			}(),
			expected: `    DownloadFile: true
    DownloadFolder: false
    UploadFile: true
    UploadFolder: false
    DeleteFile: false
    RenameFile: false
    MoveFile: false
    CreateFolder: true
    DeleteFolder: false
    RenameFolder: false
    MoveFolder: false
    ReadChat: true
    SendChat: false
    OpenChat: false
    CloseChat: false
    ShowInList: false
    CreateUser: false
    DeleteUser: false
    OpenUser: false
    ModifyUser: false
    ChangeOwnPass: false
    NewsReadArt: false
    NewsPostArt: false
    DisconnectUser: false
    CannotBeDisconnected: false
    GetClientInfo: false
    UploadAnywhere: false
    AnyName: false
    NoAgreement: false
    SetFileComment: false
    SetFolderComment: false
    ViewDropBoxes: false
    MakeAlias: false
    Broadcast: false
    NewsDeleteArt: false
    NewsCreateCat: false
    NewsDeleteCat: false
    NewsCreateFldr: false
    NewsDeleteFldr: false
    SendPrivMsg: false
`,
		},
		{
			name: "access bitmap with all permissions",
			bits: func() AccessBitmap {
				var bits AccessBitmap
				bits.Set(AccessDeleteFile)
				bits.Set(AccessUploadFile)
				bits.Set(AccessDownloadFile)
				bits.Set(AccessRenameFile)
				bits.Set(AccessMoveFile)
				bits.Set(AccessCreateFolder)
				bits.Set(AccessDeleteFolder)
				bits.Set(AccessRenameFolder)
				bits.Set(AccessMoveFolder)
				bits.Set(AccessReadChat)
				bits.Set(AccessSendChat)
				bits.Set(AccessOpenChat)
				bits.Set(AccessCloseChat)
				bits.Set(AccessShowInList)
				bits.Set(AccessCreateUser)
				bits.Set(AccessDeleteUser)
				bits.Set(AccessOpenUser)
				bits.Set(AccessModifyUser)
				bits.Set(AccessChangeOwnPass)
				bits.Set(AccessNewsReadArt)
				bits.Set(AccessNewsPostArt)
				bits.Set(AccessDisconUser)
				bits.Set(AccessCannotBeDiscon)
				bits.Set(AccessGetClientInfo)
				bits.Set(AccessUploadAnywhere)
				bits.Set(AccessAnyName)
				bits.Set(AccessNoAgreement)
				bits.Set(AccessSetFileComment)
				bits.Set(AccessSetFolderComment)
				bits.Set(AccessViewDropBoxes)
				bits.Set(AccessMakeAlias)
				bits.Set(AccessBroadcast)
				bits.Set(AccessNewsDeleteArt)
				bits.Set(AccessNewsCreateCat)
				bits.Set(AccessNewsDeleteCat)
				bits.Set(AccessNewsCreateFldr)
				bits.Set(AccessNewsDeleteFldr)
				bits.Set(AccessSendPrivMsg)
				bits.Set(AccessUploadFolder)
				bits.Set(AccessDownloadFolder)
				return bits
			}(),
			expected: `    DownloadFile: true
    DownloadFolder: true
    UploadFile: true
    UploadFolder: true
    DeleteFile: true
    RenameFile: true
    MoveFile: true
    CreateFolder: true
    DeleteFolder: true
    RenameFolder: true
    MoveFolder: true
    ReadChat: true
    SendChat: true
    OpenChat: true
    CloseChat: true
    ShowInList: true
    CreateUser: true
    DeleteUser: true
    OpenUser: true
    ModifyUser: true
    ChangeOwnPass: true
    NewsReadArt: true
    NewsPostArt: true
    DisconnectUser: true
    CannotBeDisconnected: true
    GetClientInfo: true
    UploadAnywhere: true
    AnyName: true
    NoAgreement: true
    SetFileComment: true
    SetFolderComment: true
    ViewDropBoxes: true
    MakeAlias: true
    Broadcast: true
    NewsDeleteArt: true
    NewsCreateCat: true
    NewsDeleteCat: true
    NewsCreateFldr: true
    NewsDeleteFldr: true
    SendPrivMsg: true
`,
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			// Test via YAML marshaling
			yamlData, err := yaml.Marshal(struct {
				Access AccessBitmap `yaml:"access"`
			}{Access: tt.bits})

			require.NoError(t, err)

			// Extract just the access portion
			lines := strings.Split(string(yamlData), "\n")
			var accessLines []string
			inAccess := false
			for _, line := range lines {
				if strings.HasPrefix(line, "access:") {
					inAccess = true
					continue
				}
				if inAccess && strings.HasPrefix(line, "    ") {
					accessLines = append(accessLines, line)
				}
			}

			actualAccess := strings.Join(accessLines, "\n") + "\n"
			assert.Equal(t, tt.expected, actualAccess)
		})
	}
}