Replace inappropriate panic calls with proper error handling

- Convert panic in news article processing to return error instead
- Replace panic in API stats endpoint with HTTP error response
- Update ThreadedNewsMgr interface to return errors from ListArticles
- Ensure server stability by handling errors gracefully

1 files changed, 6 insertions, 7 deletions

diff --git a/hotline/news.go b/hotline/news.go
index a490a89..c61a76f 100644
--- a/hotline/news.go
+++ b/hotline/news.go
@@ -14,7 +14,7 @@ var (
 )
 
 type ThreadedNewsMgr interface {
-	ListArticles(newsPath []string) NewsArtListData
+	ListArticles(newsPath []string) (NewsArtListData, error)
 	GetArticle(newsPath []string, articleID uint32) *NewsArtData
 	DeleteArticle(newsPath []string, articleID uint32, recursive bool) error
 	PostArticle(newsPath []string, parentArticleID uint32, article NewsArtData) error
@@ -41,7 +41,7 @@ type NewsCategoryListData15 struct {
 	readOffset int // Internal offset to track read progress
 }
 
-func (newscat *NewsCategoryListData15) GetNewsArtListData() NewsArtListData {
+func (newscat *NewsCategoryListData15) GetNewsArtListData() (NewsArtListData, error) {
 	var newsArts []NewsArtList
 	var newsArtsPayload []byte
 
@@ -70,8 +70,7 @@ func (newscat *NewsCategoryListData15) GetNewsArtListData() NewsArtListData {
 	for _, v := range newsArts {
 		b, err := io.ReadAll(&v)
 		if err != nil {
-			// TODO
-			panic(err)
+			return NewsArtListData{}, err
 		}
 		newsArtsPayload = append(newsArtsPayload, b...)
 	}
@@ -81,7 +80,7 @@ func (newscat *NewsCategoryListData15) GetNewsArtListData() NewsArtListData {
 		Name:        []byte{},
 		Description: []byte{},
 		NewsArtList: newsArtsPayload,
-	}
+	}, nil
 }
 
 // NewsArtData represents an individual news article.
@@ -242,10 +241,10 @@ type MockThreadNewsMgr struct {
 	mock.Mock
 }
 
-func (m *MockThreadNewsMgr) ListArticles(newsPath []string) NewsArtListData {
+func (m *MockThreadNewsMgr) ListArticles(newsPath []string) (NewsArtListData, error) {
 	args := m.Called(newsPath)
 
-	return args.Get(0).(NewsArtListData)
+	return args.Get(0).(NewsArtListData), args.Error(1)
 }
 
 func (m *MockThreadNewsMgr) GetArticle(newsPath []string, articleID uint32) *NewsArtData {