Fix threaded news bugs

1. Fix handling of article IDs sent as 4 bytes instead of 2
2. Fix incorrect article count listing that strangely only affects third party clients

1 files changed, 47 insertions, 0 deletions

diff --git a/hotline/util_test.go b/hotline/util_test.go
new file mode 100644
index 0000000..30ae2b6
--- /dev/null
+++ b/hotline/util_test.go
@@ -0,0 +1,47 @@
+package hotline
+
+import (
+	"fmt"
+	"github.com/stretchr/testify/assert"
+	"testing"
+)
+
+func Test_byteToInt(t *testing.T) {
+	type args struct {
+		bytes []byte
+	}
+	tests := []struct {
+		name    string
+		args    args
+		want    int
+		wantErr assert.ErrorAssertionFunc
+	}{
+		{
+			name:    "with 2 bytes of input",
+			args:    args{bytes: []byte{0, 1}},
+			want:    1,
+			wantErr: assert.NoError,
+		},
+		{
+			name:    "with 4 bytes of input",
+			args:    args{bytes: []byte{0, 1, 0, 0}},
+			want:    65536,
+			wantErr: assert.NoError,
+		},
+		{
+			name:    "with invalid number of bytes of input",
+			args:    args{bytes: []byte{1, 0, 0, 0, 0, 0, 0, 0}},
+			want:    0,
+			wantErr: assert.Error,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got, err := byteToInt(tt.args.bytes)
+			if !tt.wantErr(t, err, fmt.Sprintf("byteToInt(%v)", tt.args.bytes)) {
+				return
+			}
+			assert.Equalf(t, tt.want, got, "byteToInt(%v)", tt.args.bytes)
+		})
+	}
+}