diff options
| author | Jeff Halter <868228+jhalter@users.noreply.github.com> | 2022-05-26 18:19:24 -0700 |
|---|---|---|
| committer | Jeff Halter <868228+jhalter@users.noreply.github.com> | 2022-05-26 18:20:05 -0700 |
| commit | bd1ce11306527514218acbe0d12f7bcc23114239 (patch) | |
| tree | 315487896b2e350d2af183d0662b3ccd7487bbdf /hotline/transaction_handlers.go | |
| parent | 301990cbc43d93dddb3ba308c490a55ac03fa915 (diff) | |
Fix multiple issues with v1.8+ login sequence
Squashed bugs:
* A v1.8+ user that has connected but not agreed will show up in chat and the userlist as a blank user name
* Race condition where a v1.8+ user in connected but not agreed state duplicated the ID of the next user to connect
* A v1.8+ user that is connected but not agreed will receive the user list
Diffstat (limited to 'hotline/transaction_handlers.go')
| -rw-r--r-- | hotline/transaction_handlers.go | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/hotline/transaction_handlers.go b/hotline/transaction_handlers.go index ea46499..ade024c 100644 --- a/hotline/transaction_handlers.go +++ b/hotline/transaction_handlers.go @@ -821,11 +821,8 @@ func (cc *ClientConn) notifyNewUserHasJoined() (res []Transaction, err error) { } func HandleTranAgreed(cc *ClientConn, t *Transaction) (res []Transaction, err error) { - bs := make([]byte, 2) - binary.BigEndian.PutUint16(bs, *cc.Server.NextGuestID) - + cc.Agreed = true cc.UserName = t.GetField(fieldUserName).Data - *cc.ID = bs *cc.Icon = t.GetField(fieldUserIconID).Data options := t.GetField(fieldOptions).Data |