Extensive refactor, quality of life enhancements

* Added ability to reload config, agreement, news, and user accounts without restarting the server by sending SIGHUP to the running process
* Added ability to use modern unix or windows line breaks in Agreement.txt and MessageBoard.txt instead of classic MacOS `\r` breaks.
* Extensive refactor towards swappable backends for the active server state
* Extensive refactored towards making the hotline package generic and re-usable for alternate server implemenations
* Fix bug where users whose accounts have been deleted would not be disconnected

1 files changed, 1 insertions, 60 deletions

diff --git a/hotline/server_test.go b/hotline/server_test.go
index 0487d2e..c3d38da 100644
--- a/hotline/server_test.go
+++ b/hotline/server_test.go
@@ -110,7 +110,7 @@ func TestServer_handleFileTransfer(t *testing.T) {
 				FileTransferMgr: &MemFileTransferMgr{
 					fileTransfers: map[FileTransferID]*FileTransfer{
 						{0, 0, 0, 5}: {
-							refNum:   [4]byte{0, 0, 0, 5},
+							RefNum:   [4]byte{0, 0, 0, 5},
 							Type:     FileDownload,
 							FileName: []byte("testfile-8b"),
 							FilePath: []byte{},
@@ -171,7 +171,6 @@ func TestServer_handleFileTransfer(t *testing.T) {
 			s := &Server{
 				FileTransferMgr: tt.fields.FileTransferMgr,
 				Config:          tt.fields.Config,
-				ConfigDir:       tt.fields.ConfigDir,
 				Logger:          tt.fields.Logger,
 				Stats:           tt.fields.Stats,
 				FS:              tt.fields.FS,
@@ -183,61 +182,3 @@ func TestServer_handleFileTransfer(t *testing.T) {
 		})
 	}
 }
-
-type TestData struct {
-	Name  string `yaml:"name"`
-	Value int    `yaml:"value"`
-}
-
-func TestLoadFromYAMLFile(t *testing.T) {
-	tests := []struct {
-		name     string
-		fileName string
-		content  string
-		wantData TestData
-		wantErr  bool
-	}{
-		{
-			name:     "Valid YAML file",
-			fileName: "valid.yaml",
-			content:  "name: Test\nvalue: 123\n",
-			wantData: TestData{Name: "Test", Value: 123},
-			wantErr:  false,
-		},
-		{
-			name:     "File not found",
-			fileName: "nonexistent.yaml",
-			content:  "",
-			wantData: TestData{},
-			wantErr:  true,
-		},
-		{
-			name:     "Invalid YAML content",
-			fileName: "invalid.yaml",
-			content:  "name: Test\nvalue: invalid_int\n",
-			wantData: TestData{},
-			wantErr:  true,
-		},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			// Setup: Create a temporary file with the provided content if content is not empty
-			if tt.content != "" {
-				err := os.WriteFile(tt.fileName, []byte(tt.content), 0644)
-				assert.NoError(t, err)
-				defer os.Remove(tt.fileName) // Cleanup the file after the test
-			}
-
-			var data TestData
-			err := loadFromYAMLFile(tt.fileName, &data)
-
-			if tt.wantErr {
-				assert.Error(t, err)
-			} else {
-				assert.NoError(t, err)
-				assert.Equal(t, tt.wantData, data)
-			}
-		})
-	}
-}