diff options
| author | Jeff Halter <868228+jhalter@users.noreply.github.com> | 2024-06-15 11:13:16 -0700 |
|---|---|---|
| committer | Jeff Halter <868228+jhalter@users.noreply.github.com> | 2024-06-15 11:13:16 -0700 |
| commit | 95159e5585762c06c654945070ba54262b7dcec9 (patch) | |
| tree | 23609018c1460b056ce22067290ea12ee851d483 /hotline/client_conn.go | |
| parent | a6216dd89252fa01dc176f98f1e4ecfd3f637566 (diff) | |
Refactoring and cleanup
* Split CLI client into separate project
* Convert more functions to follow common Golang idioms e.g io.Reader, io.Writer
* Use ldflags for versioning
* Misc cleanup and simplification
Diffstat (limited to 'hotline/client_conn.go')
| -rw-r--r-- | hotline/client_conn.go | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/hotline/client_conn.go b/hotline/client_conn.go index f73265d..8e66218 100644 --- a/hotline/client_conn.go +++ b/hotline/client_conn.go @@ -60,7 +60,7 @@ func (cc *ClientConn) handleTransaction(transaction Transaction) error { field := transaction.GetField(reqField.ID) // Validate that required field is present - if field.ID == nil { + if field.ID == [2]byte{0, 0} { cc.logger.Error( "Missing required field", "RequestType", handler.Name, "FieldID", reqField.ID, @@ -166,7 +166,7 @@ func (cc *ClientConn) notifyOthers(t Transaction) (trans []Transaction) { // NewReply returns a reply Transaction with fields for the ClientConn func (cc *ClientConn) NewReply(t *Transaction, fields ...Field) Transaction { - reply := Transaction{ + return Transaction{ Flags: 0x00, IsReply: 0x01, Type: []byte{0x00, 0x00}, @@ -175,8 +175,6 @@ func (cc *ClientConn) NewReply(t *Transaction, fields ...Field) Transaction { ErrorCode: []byte{0, 0, 0, 0}, Fields: fields, } - - return reply } // NewErrReply returns an error reply Transaction with errMsg |