Improve error handling, logging, and fix race condition in Disconnect

- Add logging for unhandled transaction types in Client.HandleTransaction
- Fix race condition in Client.Disconnect by protecting done channel with mutex
- Add TranServerMsg to transaction type names map
- Use Time type instead of raw byte array in File.flattenedFileObject
- Improve error message in handleFileTransfer to include reference number
- Simplify return statement in HandleGetFileInfo

1 files changed, 5 insertions, 0 deletions

diff --git a/hotline/client.go b/hotline/client.go
index f8d9c34..23bfe9c 100644
--- a/hotline/client.go
+++ b/hotline/client.go
@@ -186,15 +186,20 @@ func (c *Client) HandleTransaction(ctx context.Context, t *Transaction) error {
 				return err
 			}
 		}
+	} else {
+		c.Logger.Info("Unhandled transaction", "type", tranTypeNames[t.Type], "id", int(binary.BigEndian.Uint16(t.Type[:])))
 	}
 
 	return nil
 }
 
 func (c *Client) Disconnect() error {
+	c.mu.Lock()
 	if c.done != nil {
 		close(c.done)
+		c.done = nil
 	}
+	c.mu.Unlock()
 	return c.Connection.Close()
 }