aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorgrunfink <grunfink@comam.es>2025-12-18 08:09:10 +0100
committergrunfink <grunfink@comam.es>2025-12-18 08:09:10 +0100
commit7c065cbc9879582985cef3d3ad8b2ae197b8b851 (patch)
tree568ca6194ba6071c1f1a0ab20347e4852cb122b5
parent85ed0eb0d535700a5df837c37f51848811e461a0 (diff)
Fixed some xs_dup() leaks.
-rw-r--r--activitypub.c2
-rw-r--r--data.c2
-rw-r--r--html.c4
3 files changed, 4 insertions, 4 deletions
diff --git a/activitypub.c b/activitypub.c
index 19f0cc6..d19a428 100644
--- a/activitypub.c
+++ b/activitypub.c
@@ -1643,7 +1643,7 @@ xs_dict *msg_emoji_init(snac *snac, const char *mid, const char *eid)
n_msg = xs_dict_set(n_msg, "content", content);
n_msg = xs_dict_set(n_msg, "accounts", accounts);
- n_msg = xs_dict_set(n_msg, "attributedTo", xs_list_get(xs_dup(xs_dict_get(n_msg, "to")), 1));
+ n_msg = xs_dict_set(n_msg, "attributedTo", xs_list_get(xs_dict_get(n_msg, "to"), 1));
n_msg = xs_dict_set(n_msg, "accountId", snac->uid);
n_msg = xs_dict_set(n_msg, "tag", tag);
diff --git a/data.c b/data.c
index 07eea3c..bbe92b8 100644
--- a/data.c
+++ b/data.c
@@ -1599,7 +1599,7 @@ int timeline_admire(snac *snac, const char *id,
/* use utf <3 as a like, as it is ugly */
if (type && xs_match(type, "Like|EmojiReact|Emoji") &&
content && strcmp(content, "❤") != 0) {
- ret = timeline_emoji_react(xs_dup(snac->actor), id, xs_dup(msg));
+ ret = timeline_emoji_react(snac->actor, id, xs_dup(msg));
snac_debug(snac, 1, xs_fmt("timeline_emoji_react %s", id));
}
diff --git a/html.c b/html.c
index 8cc0067..dae84b7 100644
--- a/html.c
+++ b/html.c
@@ -5173,9 +5173,9 @@ int html_post_handler(const xs_dict *req, const char *q_path,
}
else
if (strcmp(action, L("EmojiReact")) == 0) { /** **/
- const char *eid = xs_dict_get(p_vars, "eid");
+ xs *eid = xs_dup(xs_dict_get(p_vars, "eid"));
- eid = xs_strip_chars_i(xs_dup(eid), ":");
+ eid = xs_strip_chars_i(eid, ":");
const xs_dict *ret = msg_emoji_init(&snac, id, eid);
/* fails if either invalid or already reacted */