import (
"errors"
- "fmt"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/mock"
"io"
"os"
"path/filepath"
"strings"
+ "sync"
"testing"
"time"
)
func TestHandleSetChatSubject(t *testing.T) {
type args struct {
cc *ClientConn
- t *Transaction
+ t Transaction
}
tests := []struct {
- name string
- args args
- want []Transaction
- wantErr bool
+ name string
+ args args
+ want []Transaction
}{
{
name: "sends chat subject to private chat members",
cc: &ClientConn{
UserName: []byte{0x00, 0x01},
Server: &Server{
- PrivateChats: map[uint32]*PrivateChat{
- uint32(1): {
+ PrivateChats: map[[4]byte]*PrivateChat{
+ [4]byte{0, 0, 0, 1}: {
Subject: "unset",
- ClientConn: map[uint16]*ClientConn{
- uint16(1): {
+ ClientConn: map[[2]byte]*ClientConn{
+ [2]byte{0, 1}: {
Account: &Account{
Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
},
- ID: &[]byte{0, 1},
+ ID: [2]byte{0, 1},
},
- uint16(2): {
+ [2]byte{0, 2}: {
Account: &Account{
Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
},
- ID: &[]byte{0, 2},
+ ID: [2]byte{0, 2},
},
},
},
},
- Clients: map[uint16]*ClientConn{
- uint16(1): {
+ Clients: map[[2]byte]*ClientConn{
+ [2]byte{0, 1}: {
Account: &Account{
Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
},
- ID: &[]byte{0, 1},
+ ID: [2]byte{0, 1},
},
- uint16(2): {
+ [2]byte{0, 2}: {
Account: &Account{
Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
},
- ID: &[]byte{0, 2},
+ ID: [2]byte{0, 2},
},
},
},
},
- t: &Transaction{
+ t: Transaction{
Type: [2]byte{0, 0x6a},
ID: [4]byte{0, 0, 0, 1},
Fields: []Field{
},
want: []Transaction{
{
- clientID: &[]byte{0, 1},
+ clientID: [2]byte{0, 1},
Type: [2]byte{0, 0x77},
Fields: []Field{
NewField(FieldChatID, []byte{0, 0, 0, 1}),
},
},
{
- clientID: &[]byte{0, 2},
+ clientID: [2]byte{0, 2},
Type: [2]byte{0, 0x77},
Fields: []Field{
NewField(FieldChatID, []byte{0, 0, 0, 1}),
},
},
},
- wantErr: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- got, err := HandleSetChatSubject(tt.args.cc, tt.args.t)
- if (err != nil) != tt.wantErr {
- t.Errorf("HandleSetChatSubject() error = %v, wantErr %v", err, tt.wantErr)
- return
- }
+ got := HandleSetChatSubject(tt.args.cc, &tt.args.t)
if !tranAssertEqual(t, tt.want, got) {
t.Errorf("HandleSetChatSubject() got = %v, want %v", got, tt.want)
}
func TestHandleLeaveChat(t *testing.T) {
type args struct {
cc *ClientConn
- t *Transaction
+ t Transaction
}
tests := []struct {
- name string
- args args
- want []Transaction
- wantErr bool
+ name string
+ args args
+ want []Transaction
}{
{
name: "returns expected transactions",
args: args{
cc: &ClientConn{
- ID: &[]byte{0, 2},
+ ID: [2]byte{0, 2},
Server: &Server{
- PrivateChats: map[uint32]*PrivateChat{
- uint32(1): {
- ClientConn: map[uint16]*ClientConn{
- uint16(1): {
+ PrivateChats: map[[4]byte]*PrivateChat{
+ [4]byte{0, 0, 0, 1}: {
+ ClientConn: map[[2]byte]*ClientConn{
+ [2]byte{0, 1}: {
Account: &Account{
Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
},
- ID: &[]byte{0, 1},
+ ID: [2]byte{0, 1},
},
- uint16(2): {
+ [2]byte{0, 2}: {
Account: &Account{
Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
},
- ID: &[]byte{0, 2},
+ ID: [2]byte{0, 2},
},
},
},
},
- Clients: map[uint16]*ClientConn{
- uint16(1): {
+ Clients: map[[2]byte]*ClientConn{
+ [2]byte{0, 1}: {
Account: &Account{
Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
},
- ID: &[]byte{0, 1},
+ ID: [2]byte{0, 1},
},
- uint16(2): {
+ [2]byte{0, 2}: {
Account: &Account{
Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
},
- ID: &[]byte{0, 2},
+ ID: [2]byte{0, 2},
},
},
},
},
- t: NewTransaction(TranDeleteUser, nil, NewField(FieldChatID, []byte{0, 0, 0, 1})),
+ t: NewTransaction(TranDeleteUser, [2]byte{}, NewField(FieldChatID, []byte{0, 0, 0, 1})),
},
want: []Transaction{
{
- clientID: &[]byte{0, 1},
- Flags: 0x00,
- IsReply: 0x00,
+ clientID: [2]byte{0, 1},
Type: [2]byte{0, 0x76},
Fields: []Field{
NewField(FieldChatID, []byte{0, 0, 0, 1}),
},
},
},
- wantErr: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- got, err := HandleLeaveChat(tt.args.cc, tt.args.t)
- if (err != nil) != tt.wantErr {
- t.Errorf("HandleLeaveChat() error = %v, wantErr %v", err, tt.wantErr)
- return
- }
+ got := HandleLeaveChat(tt.args.cc, &tt.args.t)
if !tranAssertEqual(t, tt.want, got) {
t.Errorf("HandleLeaveChat() got = %v, want %v", got, tt.want)
}
func TestHandleGetUserNameList(t *testing.T) {
type args struct {
cc *ClientConn
- t *Transaction
+ t Transaction
}
tests := []struct {
- name string
- args args
- want []Transaction
- wantErr bool
+ name string
+ args args
+ want []Transaction
}{
{
name: "replies with userlist transaction",
args: args{
cc: &ClientConn{
-
- ID: &[]byte{1, 1},
+ ID: [2]byte{0, 1},
Server: &Server{
- Clients: map[uint16]*ClientConn{
- uint16(1): {
- ID: &[]byte{0, 1},
+ Clients: map[[2]byte]*ClientConn{
+ [2]byte{0, 1}: {
+ ID: [2]byte{0, 1},
Icon: []byte{0, 2},
- Flags: []byte{0, 3},
+ Flags: [2]byte{0, 3},
UserName: []byte{0, 4},
},
- uint16(2): {
- ID: &[]byte{0, 2},
+ [2]byte{0, 2}: {
+ ID: [2]byte{0, 2},
Icon: []byte{0, 2},
- Flags: []byte{0, 3},
+ Flags: [2]byte{0, 3},
UserName: []byte{0, 4},
},
},
},
},
- t: &Transaction{},
+ t: Transaction{},
},
want: []Transaction{
{
- clientID: &[]byte{1, 1},
+ clientID: [2]byte{0, 1},
IsReply: 0x01,
Fields: []Field{
NewField(
},
},
},
- wantErr: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- got, err := HandleGetUserNameList(tt.args.cc, tt.args.t)
- if (err != nil) != tt.wantErr {
- t.Errorf("HandleGetUserNameList() error = %v, wantErr %v", err, tt.wantErr)
- return
- }
+ got := HandleGetUserNameList(tt.args.cc, &tt.args.t)
assert.Equal(t, tt.want, got)
})
}
func TestHandleChatSend(t *testing.T) {
type args struct {
cc *ClientConn
- t *Transaction
+ t Transaction
}
tests := []struct {
- name string
- args args
- want []Transaction
- wantErr bool
+ name string
+ args args
+ want []Transaction
}{
{
name: "sends chat msg transaction to all clients",
},
UserName: []byte{0x00, 0x01},
Server: &Server{
- Clients: map[uint16]*ClientConn{
- uint16(1): {
+ Clients: map[[2]byte]*ClientConn{
+ [2]byte{0, 1}: {
Account: &Account{
Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
},
- ID: &[]byte{0, 1},
+ ID: [2]byte{0, 1},
},
- uint16(2): {
+ [2]byte{0, 2}: {
Account: &Account{
Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
},
- ID: &[]byte{0, 2},
+ ID: [2]byte{0, 2},
},
},
},
},
- t: &Transaction{
+ t: Transaction{
Fields: []Field{
NewField(FieldData, []byte("hai")),
},
},
want: []Transaction{
{
- clientID: &[]byte{0, 1},
+ clientID: [2]byte{0, 1},
Flags: 0x00,
IsReply: 0x00,
Type: [2]byte{0, 0x6a},
},
},
{
- clientID: &[]byte{0, 2},
+ clientID: [2]byte{0, 2},
Flags: 0x00,
IsReply: 0x00,
Type: [2]byte{0, 0x6a},
},
},
},
- wantErr: false,
},
{
name: "treats Chat ID 00 00 00 00 as a public chat message",
},
UserName: []byte{0x00, 0x01},
Server: &Server{
- Clients: map[uint16]*ClientConn{
- uint16(1): {
+ Clients: map[[2]byte]*ClientConn{
+ [2]byte{0, 1}: {
Account: &Account{
Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
},
- ID: &[]byte{0, 1},
+ ID: [2]byte{0, 1},
},
- uint16(2): {
+ [2]byte{0, 2}: {
Account: &Account{
Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
},
- ID: &[]byte{0, 2},
+ ID: [2]byte{0, 2},
},
},
},
},
- t: &Transaction{
+ t: Transaction{
Fields: []Field{
NewField(FieldData, []byte("hai")),
NewField(FieldChatID, []byte{0, 0, 0, 0}),
},
want: []Transaction{
{
- clientID: &[]byte{0, 1},
+ clientID: [2]byte{0, 1},
Type: [2]byte{0, 0x6a},
Fields: []Field{
NewField(FieldData, []byte{0x0d, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x00, 0x01, 0x3a, 0x20, 0x20, 0x68, 0x61, 0x69}),
},
},
{
- clientID: &[]byte{0, 2},
+ clientID: [2]byte{0, 2},
Type: [2]byte{0, 0x6a},
Fields: []Field{
NewField(FieldData, []byte{0x0d, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x00, 0x01, 0x3a, 0x20, 0x20, 0x68, 0x61, 0x69}),
},
},
},
- wantErr: false,
},
{
name: "when user does not have required permission",
},
},
t: NewTransaction(
- TranChatSend, &[]byte{0, 1},
+ TranChatSend, [2]byte{0, 1},
NewField(FieldData, []byte("hai")),
),
},
},
},
},
- wantErr: false,
},
{
name: "sends chat msg as emote if FieldChatOptions is set to 1",
},
UserName: []byte("Testy McTest"),
Server: &Server{
- Clients: map[uint16]*ClientConn{
- uint16(1): {
+ Clients: map[[2]byte]*ClientConn{
+ [2]byte{0, 1}: {
Account: &Account{
Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
},
- ID: &[]byte{0, 1},
+ ID: [2]byte{0, 1},
},
- uint16(2): {
+ [2]byte{0, 2}: {
Account: &Account{
Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
},
- ID: &[]byte{0, 2},
+ ID: [2]byte{0, 2},
},
},
},
},
- t: &Transaction{
+ t: Transaction{
Fields: []Field{
NewField(FieldData, []byte("performed action")),
NewField(FieldChatOptions, []byte{0x00, 0x01}),
},
want: []Transaction{
{
- clientID: &[]byte{0, 1},
+ clientID: [2]byte{0, 1},
Flags: 0x00,
IsReply: 0x00,
Type: [2]byte{0, 0x6a},
},
},
{
- clientID: &[]byte{0, 2},
+ clientID: [2]byte{0, 2},
Flags: 0x00,
IsReply: 0x00,
Type: [2]byte{0, 0x6a},
},
},
},
- wantErr: false,
},
{
name: "does not send chat msg as emote if FieldChatOptions is set to 0",
},
UserName: []byte("Testy McTest"),
Server: &Server{
- Clients: map[uint16]*ClientConn{
- uint16(1): {
+ Clients: map[[2]byte]*ClientConn{
+ [2]byte{0, 1}: {
Account: &Account{
Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
},
- ID: &[]byte{0, 1},
+ ID: [2]byte{0, 1},
},
- uint16(2): {
+ [2]byte{0, 2}: {
Account: &Account{
Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
},
- ID: &[]byte{0, 2},
+ ID: [2]byte{0, 2},
},
},
},
},
- t: &Transaction{
+ t: Transaction{
Fields: []Field{
NewField(FieldData, []byte("hello")),
NewField(FieldChatOptions, []byte{0x00, 0x00}),
},
want: []Transaction{
{
- clientID: &[]byte{0, 1},
+ clientID: [2]byte{0, 1},
Type: [2]byte{0, 0x6a},
Fields: []Field{
NewField(FieldData, []byte("\r Testy McTest: hello")),
},
},
{
- clientID: &[]byte{0, 2},
+ clientID: [2]byte{0, 2},
Type: [2]byte{0, 0x6a},
Fields: []Field{
NewField(FieldData, []byte("\r Testy McTest: hello")),
},
},
},
- wantErr: false,
},
{
name: "only sends chat msg to clients with accessReadChat permission",
},
UserName: []byte{0x00, 0x01},
Server: &Server{
- Clients: map[uint16]*ClientConn{
- uint16(1): {
+ Clients: map[[2]byte]*ClientConn{
+ [2]byte{0, 1}: {
Account: &Account{
Access: func() accessBitmap {
var bits accessBitmap
bits.Set(accessReadChat)
return bits
}()},
- ID: &[]byte{0, 1},
+ ID: [2]byte{0, 1},
},
- uint16(2): {
+ [2]byte{0, 2}: {
Account: &Account{
Access: accessBitmap{0, 0, 0, 0, 0, 0, 0, 0},
},
- ID: &[]byte{0, 2},
+ ID: [2]byte{0, 2},
},
},
},
},
- t: &Transaction{
+ t: Transaction{
Fields: []Field{
NewField(FieldData, []byte("hai")),
},
},
want: []Transaction{
{
- clientID: &[]byte{0, 1},
+ clientID: [2]byte{0, 1},
Type: [2]byte{0, 0x6a},
Fields: []Field{
NewField(FieldData, []byte{0x0d, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x00, 0x01, 0x3a, 0x20, 0x20, 0x68, 0x61, 0x69}),
},
},
},
- wantErr: false,
},
{
name: "only sends private chat msg to members of private chat",
},
UserName: []byte{0x00, 0x01},
Server: &Server{
- PrivateChats: map[uint32]*PrivateChat{
- uint32(1): {
- ClientConn: map[uint16]*ClientConn{
- uint16(1): {
- ID: &[]byte{0, 1},
+ PrivateChats: map[[4]byte]*PrivateChat{
+ [4]byte{0, 0, 0, 1}: {
+ ClientConn: map[[2]byte]*ClientConn{
+ [2]byte{0, 1}: {
+ ID: [2]byte{0, 1},
},
- uint16(2): {
- ID: &[]byte{0, 2},
+ [2]byte{0, 2}: {
+ ID: [2]byte{0, 2},
},
},
},
},
- Clients: map[uint16]*ClientConn{
- uint16(1): {
+ Clients: map[[2]byte]*ClientConn{
+ [2]byte{0, 1}: {
Account: &Account{
Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
},
- ID: &[]byte{0, 1},
+ ID: [2]byte{0, 1},
},
- uint16(2): {
+ [2]byte{0, 2}: {
Account: &Account{
Access: accessBitmap{0, 0, 0, 0, 0, 0, 0, 0},
},
- ID: &[]byte{0, 2},
+ ID: [2]byte{0, 2},
},
- uint16(3): {
+ [2]byte{0, 3}: {
Account: &Account{
Access: accessBitmap{0, 0, 0, 0, 0, 0, 0, 0},
},
- ID: &[]byte{0, 3},
+ ID: [2]byte{0, 3},
},
},
},
},
- t: &Transaction{
+ t: Transaction{
Fields: []Field{
NewField(FieldData, []byte("hai")),
NewField(FieldChatID, []byte{0, 0, 0, 1}),
},
want: []Transaction{
{
- clientID: &[]byte{0, 1},
+ clientID: [2]byte{0, 1},
Type: [2]byte{0, 0x6a},
Fields: []Field{
NewField(FieldChatID, []byte{0, 0, 0, 1}),
},
},
{
- clientID: &[]byte{0, 2},
+ clientID: [2]byte{0, 2},
Type: [2]byte{0, 0x6a},
Fields: []Field{
NewField(FieldChatID, []byte{0, 0, 0, 1}),
},
},
},
- wantErr: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- got, err := HandleChatSend(tt.args.cc, tt.args.t)
-
- if (err != nil) != tt.wantErr {
- t.Errorf("HandleChatSend() error = %v, wantErr %v", err, tt.wantErr)
- return
- }
+ got := HandleChatSend(tt.args.cc, &tt.args.t)
tranAssertEqual(t, tt.want, got)
})
}
func TestHandleGetFileInfo(t *testing.T) {
type args struct {
cc *ClientConn
- t *Transaction
+ t Transaction
}
tests := []struct {
name string
args args
wantRes []Transaction
- wantErr bool
}{
{
name: "returns expected fields when a valid file is requested",
args: args{
cc: &ClientConn{
- ID: &[]byte{0x00, 0x01},
+ ID: [2]byte{0x00, 0x01},
Server: &Server{
FS: &OSFileStore{},
Config: &Config{
},
},
t: NewTransaction(
- TranGetFileInfo, nil,
+ TranGetFileInfo, [2]byte{},
NewField(FieldFileName, []byte("testfile.txt")),
NewField(FieldFilePath, []byte{0x00, 0x00}),
),
},
wantRes: []Transaction{
{
- clientID: &[]byte{0, 1},
+ clientID: [2]byte{0, 1},
IsReply: 0x01,
Type: [2]byte{0, 0},
Fields: []Field{
},
},
},
- wantErr: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- gotRes, err := HandleGetFileInfo(tt.args.cc, tt.args.t)
- if (err != nil) != tt.wantErr {
- t.Errorf("HandleGetFileInfo() error = %v, wantErr %v", err, tt.wantErr)
- return
- }
+ gotRes := HandleGetFileInfo(tt.args.cc, &tt.args.t)
- // Clear the fileWrapper timestamp fields to work around problems running the tests in multiple timezones
+ // Clear the file timestamp fields to work around problems running the tests in multiple timezones
// TODO: revisit how to test this by mocking the stat calls
gotRes[0].Fields[4].Data = make([]byte, 8)
gotRes[0].Fields[5].Data = make([]byte, 8)
func TestHandleNewFolder(t *testing.T) {
type args struct {
cc *ClientConn
- t *Transaction
+ t Transaction
}
tests := []struct {
name string
args args
wantRes []Transaction
- wantErr bool
}{
{
name: "without required permission",
},
},
t: NewTransaction(
- accessCreateFolder,
- &[]byte{0, 0},
+ TranNewFolder,
+ [2]byte{0, 0},
),
},
wantRes: []Transaction{
},
},
},
- wantErr: false,
},
{
name: "when path is nested",
return bits
}(),
},
- ID: &[]byte{0, 1},
+ ID: [2]byte{0, 1},
Server: &Server{
Config: &Config{
FileRoot: "/Files/",
},
},
t: NewTransaction(
- TranNewFolder, &[]byte{0, 1},
+ TranNewFolder, [2]byte{0, 1},
NewField(FieldFileName, []byte("testFolder")),
NewField(FieldFilePath, []byte{
0x00, 0x01,
},
wantRes: []Transaction{
{
- clientID: &[]byte{0, 1},
+ clientID: [2]byte{0, 1},
IsReply: 0x01,
},
},
- wantErr: false,
},
{
name: "when path is not nested",
return bits
}(),
},
- ID: &[]byte{0, 1},
+ ID: [2]byte{0, 1},
Server: &Server{
Config: &Config{
FileRoot: "/Files",
},
},
t: NewTransaction(
- TranNewFolder, &[]byte{0, 1},
+ TranNewFolder, [2]byte{0, 1},
NewField(FieldFileName, []byte("testFolder")),
),
},
wantRes: []Transaction{
{
- clientID: &[]byte{0, 1},
+ clientID: [2]byte{0, 1},
IsReply: 0x01,
},
},
- wantErr: false,
},
{
name: "when Write returns an err",
return bits
}(),
},
- ID: &[]byte{0, 1},
+ ID: [2]byte{0, 1},
Server: &Server{
Config: &Config{
FileRoot: "/Files/",
},
},
t: NewTransaction(
- TranNewFolder, &[]byte{0, 1},
+ TranNewFolder, [2]byte{0, 1},
NewField(FieldFileName, []byte("testFolder")),
NewField(FieldFilePath, []byte{
0x00,
),
},
wantRes: []Transaction{},
- wantErr: true,
},
{
name: "FieldFileName does not allow directory traversal",
return bits
}(),
},
- ID: &[]byte{0, 1},
+ ID: [2]byte{0, 1},
Server: &Server{
Config: &Config{
FileRoot: "/Files/",
},
},
t: NewTransaction(
- TranNewFolder, &[]byte{0, 1},
+ TranNewFolder, [2]byte{0, 1},
NewField(FieldFileName, []byte("../../testFolder")),
),
},
wantRes: []Transaction{
{
- clientID: &[]byte{0, 1},
+ clientID: [2]byte{0, 1},
IsReply: 0x01,
},
- }, wantErr: false,
+ },
},
{
name: "FieldFilePath does not allow directory traversal",
return bits
}(),
},
- ID: &[]byte{0, 1},
+ ID: [2]byte{0, 1},
Server: &Server{
Config: &Config{
FileRoot: "/Files/",
},
},
t: NewTransaction(
- TranNewFolder, &[]byte{0, 1},
+ TranNewFolder, [2]byte{0, 1},
NewField(FieldFileName, []byte("testFolder")),
NewField(FieldFilePath, []byte{
0x00, 0x02,
},
wantRes: []Transaction{
{
- clientID: &[]byte{0, 1},
+ clientID: [2]byte{0, 1},
IsReply: 0x01,
},
- }, wantErr: false,
+ },
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- gotRes, err := HandleNewFolder(tt.args.cc, tt.args.t)
- if (err != nil) != tt.wantErr {
- t.Errorf("HandleNewFolder() error = %v, wantErr %v", err, tt.wantErr)
- return
- }
+ gotRes := HandleNewFolder(tt.args.cc, &tt.args.t)
if !tranAssertEqual(t, tt.wantRes, gotRes) {
t.Errorf("HandleNewFolder() gotRes = %v, want %v", gotRes, tt.wantRes)
func TestHandleUploadFile(t *testing.T) {
type args struct {
cc *ClientConn
- t *Transaction
+ t Transaction
}
tests := []struct {
name string
args args
wantRes []Transaction
- wantErr bool
}{
{
name: "when request is valid and user has Upload Anywhere permission",
},
},
t: NewTransaction(
- TranUploadFile, &[]byte{0, 1},
+ TranUploadFile, [2]byte{0, 1},
NewField(FieldFileName, []byte("testFile")),
NewField(FieldFilePath, []byte{
0x00, 0x01,
},
},
},
- wantErr: false,
},
{
name: "when user does not have required access",
},
},
t: NewTransaction(
- TranUploadFile, &[]byte{0, 1},
+ TranUploadFile, [2]byte{0, 1},
NewField(FieldFileName, []byte("testFile")),
NewField(FieldFilePath, []byte{
0x00, 0x01,
},
},
},
- wantErr: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- gotRes, err := HandleUploadFile(tt.args.cc, tt.args.t)
- if (err != nil) != tt.wantErr {
- t.Errorf("HandleUploadFile() error = %v, wantErr %v", err, tt.wantErr)
- return
- }
-
+ gotRes := HandleUploadFile(tt.args.cc, &tt.args.t)
tranAssertEqual(t, tt.wantRes, gotRes)
})
}
func TestHandleMakeAlias(t *testing.T) {
type args struct {
cc *ClientConn
- t *Transaction
+ t Transaction
}
tests := []struct {
name string
args args
wantRes []Transaction
- wantErr bool
}{
{
name: "with valid input and required permissions",
},
},
t: NewTransaction(
- TranMakeFileAlias, &[]byte{0, 1},
+ TranMakeFileAlias, [2]byte{0, 1},
NewField(FieldFileName, []byte("testFile")),
NewField(FieldFilePath, EncodeFilePath(strings.Join([]string{"foo"}, "/"))),
NewField(FieldFileNewPath, EncodeFilePath(strings.Join([]string{"bar"}, "/"))),
Fields: []Field(nil),
},
},
- wantErr: false,
},
{
name: "when symlink returns an error",
},
},
t: NewTransaction(
- TranMakeFileAlias, &[]byte{0, 1},
+ TranMakeFileAlias, [2]byte{0, 1},
NewField(FieldFileName, []byte("testFile")),
NewField(FieldFilePath, EncodeFilePath(strings.Join([]string{"foo"}, "/"))),
NewField(FieldFileNewPath, EncodeFilePath(strings.Join([]string{"bar"}, "/"))),
},
},
},
- wantErr: false,
},
{
name: "when user does not have required permission",
},
},
t: NewTransaction(
- TranMakeFileAlias, &[]byte{0, 1},
+ TranMakeFileAlias, [2]byte{0, 1},
NewField(FieldFileName, []byte("testFile")),
NewField(FieldFilePath, []byte{
0x00, 0x01,
},
},
},
- wantErr: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- gotRes, err := HandleMakeAlias(tt.args.cc, tt.args.t)
- if (err != nil) != tt.wantErr {
- t.Errorf("HandleMakeAlias(%v, %v)", tt.args.cc, tt.args.t)
- return
- }
-
+ gotRes := HandleMakeAlias(tt.args.cc, &tt.args.t)
tranAssertEqual(t, tt.wantRes, gotRes)
})
}
func TestHandleGetUser(t *testing.T) {
type args struct {
cc *ClientConn
- t *Transaction
+ t Transaction
}
tests := []struct {
name string
args args
wantRes []Transaction
- wantErr assert.ErrorAssertionFunc
}{
{
name: "when account is valid",
},
},
t: NewTransaction(
- TranGetUser, &[]byte{0, 1},
+ TranGetUser, [2]byte{0, 1},
NewField(FieldUserLogin, []byte("guest")),
),
},
},
},
},
- wantErr: assert.NoError,
},
{
name: "when user does not have required permission",
},
},
t: NewTransaction(
- TranGetUser, &[]byte{0, 1},
+ TranGetUser, [2]byte{0, 1},
NewField(FieldUserLogin, []byte("nonExistentUser")),
),
},
},
},
},
- wantErr: assert.NoError,
},
{
name: "when account does not exist",
},
},
t: NewTransaction(
- TranGetUser, &[]byte{0, 1},
+ TranGetUser, [2]byte{0, 1},
NewField(FieldUserLogin, []byte("nonExistentUser")),
),
},
},
},
},
- wantErr: assert.NoError,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- gotRes, err := HandleGetUser(tt.args.cc, tt.args.t)
- if !tt.wantErr(t, err, fmt.Sprintf("HandleGetUser(%v, %v)", tt.args.cc, tt.args.t)) {
- return
- }
-
+ gotRes := HandleGetUser(tt.args.cc, &tt.args.t)
tranAssertEqual(t, tt.wantRes, gotRes)
})
}
func TestHandleDeleteUser(t *testing.T) {
type args struct {
cc *ClientConn
- t *Transaction
+ t Transaction
}
tests := []struct {
name string
args args
wantRes []Transaction
- wantErr assert.ErrorAssertionFunc
}{
{
name: "when user dataFile",
},
},
t: NewTransaction(
- TranDeleteUser, &[]byte{0, 1},
+ TranDeleteUser, [2]byte{0, 1},
NewField(FieldUserLogin, encodeString([]byte("testuser"))),
),
},
Fields: []Field(nil),
},
},
- wantErr: assert.NoError,
},
{
name: "when user does not have required permission",
},
},
t: NewTransaction(
- TranDeleteUser, &[]byte{0, 1},
+ TranDeleteUser, [2]byte{0, 1},
NewField(FieldUserLogin, encodeString([]byte("testuser"))),
),
},
},
},
},
- wantErr: assert.NoError,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- gotRes, err := HandleDeleteUser(tt.args.cc, tt.args.t)
- if !tt.wantErr(t, err, fmt.Sprintf("HandleDeleteUser(%v, %v)", tt.args.cc, tt.args.t)) {
- return
- }
-
+ gotRes := HandleDeleteUser(tt.args.cc, &tt.args.t)
tranAssertEqual(t, tt.wantRes, gotRes)
})
}
func TestHandleGetMsgs(t *testing.T) {
type args struct {
cc *ClientConn
- t *Transaction
+ t Transaction
}
tests := []struct {
name string
args args
wantRes []Transaction
- wantErr assert.ErrorAssertionFunc
}{
{
name: "returns news data",
},
},
t: NewTransaction(
- TranGetMsgs, &[]byte{0, 1},
+ TranGetMsgs, [2]byte{0, 1},
),
},
wantRes: []Transaction{
},
},
},
- wantErr: assert.NoError,
},
{
name: "when user does not have required permission",
},
},
t: NewTransaction(
- TranGetMsgs, &[]byte{0, 1},
+ TranGetMsgs, [2]byte{0, 1},
),
},
wantRes: []Transaction{
},
},
},
- wantErr: assert.NoError,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- gotRes, err := HandleGetMsgs(tt.args.cc, tt.args.t)
- if !tt.wantErr(t, err, fmt.Sprintf("HandleGetMsgs(%v, %v)", tt.args.cc, tt.args.t)) {
- return
- }
-
+ gotRes := HandleGetMsgs(tt.args.cc, &tt.args.t)
tranAssertEqual(t, tt.wantRes, gotRes)
})
}
func TestHandleNewUser(t *testing.T) {
type args struct {
cc *ClientConn
- t *Transaction
+ t Transaction
}
tests := []struct {
name string
args args
wantRes []Transaction
- wantErr assert.ErrorAssertionFunc
}{
{
name: "when user does not have required permission",
},
},
t: NewTransaction(
- TranNewUser, &[]byte{0, 1},
+ TranNewUser, [2]byte{0, 1},
),
},
wantRes: []Transaction{
},
},
},
- wantErr: assert.NoError,
},
{
name: "when user attempts to create account with greater access",
},
},
t: NewTransaction(
- TranNewUser, &[]byte{0, 1},
+ TranNewUser, [2]byte{0, 1},
NewField(FieldUserLogin, []byte("userB")),
NewField(
FieldUserAccess,
},
},
},
- wantErr: assert.NoError,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- gotRes, err := HandleNewUser(tt.args.cc, tt.args.t)
- if !tt.wantErr(t, err, fmt.Sprintf("HandleNewUser(%v, %v)", tt.args.cc, tt.args.t)) {
- return
- }
-
+ gotRes := HandleNewUser(tt.args.cc, &tt.args.t)
tranAssertEqual(t, tt.wantRes, gotRes)
})
}
func TestHandleListUsers(t *testing.T) {
type args struct {
cc *ClientConn
- t *Transaction
+ t Transaction
}
tests := []struct {
name string
args args
wantRes []Transaction
- wantErr assert.ErrorAssertionFunc
}{
{
name: "when user does not have required permission",
},
},
t: NewTransaction(
- TranNewUser, &[]byte{0, 1},
+ TranNewUser, [2]byte{0, 1},
),
},
wantRes: []Transaction{
},
},
},
- wantErr: assert.NoError,
},
{
name: "when user has required permission",
},
},
t: NewTransaction(
- TranGetClientInfoText, &[]byte{0, 1},
+ TranGetClientInfoText, [2]byte{0, 1},
NewField(FieldUserID, []byte{0, 1}),
),
},
},
},
},
- wantErr: assert.NoError,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- gotRes, err := HandleListUsers(tt.args.cc, tt.args.t)
- if !tt.wantErr(t, err, fmt.Sprintf("HandleListUsers(%v, %v)", tt.args.cc, tt.args.t)) {
- return
- }
+ gotRes := HandleListUsers(tt.args.cc, &tt.args.t)
tranAssertEqual(t, tt.wantRes, gotRes)
})
func TestHandleDownloadFile(t *testing.T) {
type args struct {
cc *ClientConn
- t *Transaction
+ t Transaction
}
tests := []struct {
name string
args args
wantRes []Transaction
- wantErr assert.ErrorAssertionFunc
}{
{
name: "when user does not have required permission",
},
Server: &Server{},
},
- t: NewTransaction(TranDownloadFile, &[]byte{0, 1}),
+ t: NewTransaction(TranDownloadFile, [2]byte{0, 1}),
},
wantRes: []Transaction{
{
},
},
},
- wantErr: assert.NoError,
},
{
name: "with a valid file",
},
},
t: NewTransaction(
- accessDownloadFile,
- &[]byte{0, 1},
+ TranDownloadFile,
+ [2]byte{0, 1},
NewField(FieldFileName, []byte("testfile.txt")),
NewField(FieldFilePath, []byte{0x0, 0x00}),
),
},
},
},
- wantErr: assert.NoError,
},
{
name: "when client requests to resume 1k test file at offset 256",
},
},
t: NewTransaction(
- accessDownloadFile,
- &[]byte{0, 1},
+ TranDownloadFile,
+ [2]byte{0, 1},
NewField(FieldFileName, []byte("testfile-1k")),
NewField(FieldFilePath, []byte{0x00, 0x00}),
NewField(
FieldFileResumeData,
func() []byte {
frd := FileResumeData{
- Format: [4]byte{},
- Version: [2]byte{},
- RSVD: [34]byte{},
ForkCount: [2]byte{0, 2},
ForkInfoList: []ForkInfoList{
{
Fork: [4]byte{0x44, 0x41, 0x54, 0x41}, // "DATA"
DataSize: [4]byte{0, 0, 0x01, 0x00}, // request offset 256
- RSVDA: [4]byte{},
- RSVDB: [4]byte{},
},
{
Fork: [4]byte{0x4d, 0x41, 0x43, 0x52}, // "MACR"
DataSize: [4]byte{0, 0, 0, 0},
- RSVDA: [4]byte{},
- RSVDB: [4]byte{},
},
},
}
},
},
},
- wantErr: assert.NoError,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- gotRes, err := HandleDownloadFile(tt.args.cc, tt.args.t)
- if !tt.wantErr(t, err, fmt.Sprintf("HandleDownloadFile(%v, %v)", tt.args.cc, tt.args.t)) {
- return
- }
-
+ gotRes := HandleDownloadFile(tt.args.cc, &tt.args.t)
tranAssertEqual(t, tt.wantRes, gotRes)
})
}
func TestHandleUpdateUser(t *testing.T) {
type args struct {
cc *ClientConn
- t *Transaction
+ t Transaction
}
tests := []struct {
name string
args args
wantRes []Transaction
- wantErr assert.ErrorAssertionFunc
}{
{
name: "when action is create user without required permission",
},
t: NewTransaction(
TranUpdateUser,
- &[]byte{0, 0},
+ [2]byte{0, 0},
NewField(FieldData, []byte{
0x00, 0x04, // field count
},
},
},
- wantErr: assert.NoError,
},
{
name: "when action is modify user without required permission",
},
t: NewTransaction(
TranUpdateUser,
- &[]byte{0, 0},
+ [2]byte{0, 0},
NewField(FieldData, []byte{
0x00, 0x04, // field count
},
},
},
- wantErr: assert.NoError,
},
{
name: "when action is delete user without required permission",
},
t: NewTransaction(
TranUpdateUser,
- &[]byte{0, 0},
+ [2]byte{0, 0},
NewField(FieldData, []byte{
0x00, 0x01,
0x00, 0x65,
},
},
},
- wantErr: assert.NoError,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- gotRes, err := HandleUpdateUser(tt.args.cc, tt.args.t)
- if !tt.wantErr(t, err, fmt.Sprintf("HandleUpdateUser(%v, %v)", tt.args.cc, tt.args.t)) {
- return
- }
-
+ gotRes := HandleUpdateUser(tt.args.cc, &tt.args.t)
tranAssertEqual(t, tt.wantRes, gotRes)
})
}
func TestHandleDelNewsArt(t *testing.T) {
type args struct {
cc *ClientConn
- t *Transaction
+ t Transaction
}
tests := []struct {
name string
args args
wantRes []Transaction
- wantErr assert.ErrorAssertionFunc
}{
{
name: "without required permission",
},
t: NewTransaction(
TranDelNewsArt,
- &[]byte{0, 0},
+ [2]byte{0, 0},
),
},
wantRes: []Transaction{
},
},
},
- wantErr: assert.NoError,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- gotRes, err := HandleDelNewsArt(tt.args.cc, tt.args.t)
- if !tt.wantErr(t, err, fmt.Sprintf("HandleDelNewsArt(%v, %v)", tt.args.cc, tt.args.t)) {
- return
- }
+ gotRes := HandleDelNewsArt(tt.args.cc, &tt.args.t)
tranAssertEqual(t, tt.wantRes, gotRes)
})
}
func TestHandleDisconnectUser(t *testing.T) {
type args struct {
cc *ClientConn
- t *Transaction
+ t Transaction
}
tests := []struct {
name string
args args
wantRes []Transaction
- wantErr assert.ErrorAssertionFunc
}{
{
name: "without required permission",
},
t: NewTransaction(
TranDelNewsArt,
- &[]byte{0, 0},
+ [2]byte{0, 0},
),
},
wantRes: []Transaction{
},
},
},
- wantErr: assert.NoError,
},
{
name: "when target user has 'cannot be disconnected' priv",
args: args{
cc: &ClientConn{
Server: &Server{
- Clients: map[uint16]*ClientConn{
- uint16(1): {
+ Clients: map[[2]byte]*ClientConn{
+ [2]byte{0, 1}: {
Account: &Account{
Login: "unnamed",
Access: func() accessBitmap {
},
t: NewTransaction(
TranDelNewsArt,
- &[]byte{0, 0},
+ [2]byte{0, 0},
NewField(FieldUserID, []byte{0, 1}),
),
},
},
},
},
- wantErr: assert.NoError,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- gotRes, err := HandleDisconnectUser(tt.args.cc, tt.args.t)
- if !tt.wantErr(t, err, fmt.Sprintf("HandleDisconnectUser(%v, %v)", tt.args.cc, tt.args.t)) {
- return
- }
+ gotRes := HandleDisconnectUser(tt.args.cc, &tt.args.t)
tranAssertEqual(t, tt.wantRes, gotRes)
})
}
func TestHandleSendInstantMsg(t *testing.T) {
type args struct {
cc *ClientConn
- t *Transaction
+ t Transaction
}
tests := []struct {
name string
args args
wantRes []Transaction
- wantErr assert.ErrorAssertionFunc
}{
{
name: "without required permission",
},
t: NewTransaction(
TranDelNewsArt,
- &[]byte{0, 0},
+ [2]byte{0, 0},
),
},
wantRes: []Transaction{
},
},
},
- wantErr: assert.Error,
},
{
name: "when client 1 sends a message to client 2",
return bits
}(),
},
- ID: &[]byte{0, 1},
+ ID: [2]byte{0, 1},
UserName: []byte("User1"),
Server: &Server{
- Clients: map[uint16]*ClientConn{
- uint16(2): {
+ Clients: map[[2]byte]*ClientConn{
+ [2]byte{0, 2}: {
AutoReply: []byte(nil),
- Flags: []byte{0, 0},
+ Flags: [2]byte{0, 0},
},
},
},
},
t: NewTransaction(
TranSendInstantMsg,
- &[]byte{0, 1},
+ [2]byte{0, 1},
NewField(FieldData, []byte("hai")),
NewField(FieldUserID, []byte{0, 2}),
),
},
wantRes: []Transaction{
- *NewTransaction(
+ NewTransaction(
TranServerMsg,
- &[]byte{0, 2},
+ [2]byte{0, 2},
NewField(FieldData, []byte("hai")),
NewField(FieldUserName, []byte("User1")),
NewField(FieldUserID, []byte{0, 1}),
NewField(FieldOptions, []byte{0, 1}),
),
{
- clientID: &[]byte{0, 1},
+ clientID: [2]byte{0, 1},
IsReply: 0x01,
Fields: []Field(nil),
},
},
- wantErr: assert.NoError,
},
{
name: "when client 2 has autoreply enabled",
return bits
}(),
},
- ID: &[]byte{0, 1},
+ ID: [2]byte{0, 1},
UserName: []byte("User1"),
Server: &Server{
- Clients: map[uint16]*ClientConn{
- uint16(2): {
- Flags: []byte{0, 0},
- ID: &[]byte{0, 2},
+ Clients: map[[2]byte]*ClientConn{
+ [2]byte{0, 2}: {
+ Flags: [2]byte{0, 0},
+ ID: [2]byte{0, 2},
UserName: []byte("User2"),
AutoReply: []byte("autohai"),
},
},
t: NewTransaction(
TranSendInstantMsg,
- &[]byte{0, 1},
+ [2]byte{0, 1},
NewField(FieldData, []byte("hai")),
NewField(FieldUserID, []byte{0, 2}),
),
},
wantRes: []Transaction{
- *NewTransaction(
+ NewTransaction(
TranServerMsg,
- &[]byte{0, 2},
+ [2]byte{0, 2},
NewField(FieldData, []byte("hai")),
NewField(FieldUserName, []byte("User1")),
NewField(FieldUserID, []byte{0, 1}),
NewField(FieldOptions, []byte{0, 1}),
),
- *NewTransaction(
+ NewTransaction(
TranServerMsg,
- &[]byte{0, 1},
+ [2]byte{0, 1},
NewField(FieldData, []byte("autohai")),
NewField(FieldUserName, []byte("User2")),
NewField(FieldUserID, []byte{0, 2}),
NewField(FieldOptions, []byte{0, 1}),
),
{
- clientID: &[]byte{0, 1},
+ clientID: [2]byte{0, 1},
IsReply: 0x01,
Fields: []Field(nil),
},
},
- wantErr: assert.NoError,
},
{
name: "when client 2 has refuse private messages enabled",
return bits
}(),
},
- ID: &[]byte{0, 1},
+ ID: [2]byte{0, 1},
UserName: []byte("User1"),
Server: &Server{
- Clients: map[uint16]*ClientConn{
- uint16(2): {
- Flags: []byte{255, 255},
- ID: &[]byte{0, 2},
+ Clients: map[[2]byte]*ClientConn{
+ [2]byte{0, 2}: {
+ Flags: [2]byte{255, 255},
+ ID: [2]byte{0, 2},
UserName: []byte("User2"),
},
},
},
t: NewTransaction(
TranSendInstantMsg,
- &[]byte{0, 1},
+ [2]byte{0, 1},
NewField(FieldData, []byte("hai")),
NewField(FieldUserID, []byte{0, 2}),
),
},
wantRes: []Transaction{
- *NewTransaction(
+ NewTransaction(
TranServerMsg,
- &[]byte{0, 1},
+ [2]byte{0, 1},
NewField(FieldData, []byte("User2 does not accept private messages.")),
NewField(FieldUserName, []byte("User2")),
NewField(FieldUserID, []byte{0, 2}),
NewField(FieldOptions, []byte{0, 2}),
),
{
- clientID: &[]byte{0, 1},
+ clientID: [2]byte{0, 1},
IsReply: 0x01,
Fields: []Field(nil),
},
},
- wantErr: assert.NoError,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- gotRes, err := HandleSendInstantMsg(tt.args.cc, tt.args.t)
- if !tt.wantErr(t, err, fmt.Sprintf("HandleSendInstantMsg(%v, %v)", tt.args.cc, tt.args.t)) {
- return
- }
-
+ gotRes := HandleSendInstantMsg(tt.args.cc, &tt.args.t)
tranAssertEqual(t, tt.wantRes, gotRes)
})
}
func TestHandleDeleteFile(t *testing.T) {
type args struct {
cc *ClientConn
- t *Transaction
+ t Transaction
}
tests := []struct {
name string
args args
wantRes []Transaction
- wantErr assert.ErrorAssertionFunc
}{
{
name: "when user does not have required permission to delete a folder",
},
},
t: NewTransaction(
- TranDeleteFile, &[]byte{0, 1},
+ TranDeleteFile, [2]byte{0, 1},
NewField(FieldFileName, []byte("testfile")),
NewField(FieldFilePath, []byte{
0x00, 0x01,
},
},
},
- wantErr: assert.NoError,
},
{
name: "deletes all associated metadata files",
},
},
t: NewTransaction(
- TranDeleteFile, &[]byte{0, 1},
+ TranDeleteFile, [2]byte{0, 1},
NewField(FieldFileName, []byte("testfile")),
NewField(FieldFilePath, []byte{
0x00, 0x01,
Fields: []Field(nil),
},
},
- wantErr: assert.NoError,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- gotRes, err := HandleDeleteFile(tt.args.cc, tt.args.t)
- if !tt.wantErr(t, err, fmt.Sprintf("HandleDeleteFile(%v, %v)", tt.args.cc, tt.args.t)) {
- return
- }
-
+ gotRes := HandleDeleteFile(tt.args.cc, &tt.args.t)
tranAssertEqual(t, tt.wantRes, gotRes)
tt.args.cc.Server.FS.(*MockFileStore).AssertExpectations(t)
func TestHandleGetFileNameList(t *testing.T) {
type args struct {
cc *ClientConn
- t *Transaction
+ t Transaction
}
tests := []struct {
name string
args args
wantRes []Transaction
- wantErr assert.ErrorAssertionFunc
}{
{
name: "when FieldFilePath is a drop box, but user does not have accessViewDropBoxes ",
},
},
t: NewTransaction(
- TranGetFileNameList, &[]byte{0, 1},
+ TranGetFileNameList, [2]byte{0, 1},
NewField(FieldFilePath, []byte{
0x00, 0x01,
0x00, 0x00,
},
},
},
- wantErr: assert.NoError,
},
{
name: "with file root",
},
},
t: NewTransaction(
- TranGetFileNameList, &[]byte{0, 1},
+ TranGetFileNameList, [2]byte{0, 1},
NewField(FieldFilePath, []byte{
0x00, 0x00,
0x00, 0x00,
},
},
},
- wantErr: assert.NoError,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- gotRes, err := HandleGetFileNameList(tt.args.cc, tt.args.t)
- if !tt.wantErr(t, err, fmt.Sprintf("HandleGetFileNameList(%v, %v)", tt.args.cc, tt.args.t)) {
- return
- }
-
+ gotRes := HandleGetFileNameList(tt.args.cc, &tt.args.t)
tranAssertEqual(t, tt.wantRes, gotRes)
})
}
func TestHandleGetClientInfoText(t *testing.T) {
type args struct {
cc *ClientConn
- t *Transaction
+ t Transaction
}
tests := []struct {
name string
args args
wantRes []Transaction
- wantErr assert.ErrorAssertionFunc
}{
{
name: "when user does not have required permission",
},
},
t: NewTransaction(
- TranGetClientInfoText, &[]byte{0, 1},
+ TranGetClientInfoText, [2]byte{0, 1},
NewField(FieldUserID, []byte{0, 1}),
),
},
},
},
},
- wantErr: assert.NoError,
},
{
name: "with a valid user",
},
Server: &Server{
Accounts: map[string]*Account{},
- Clients: map[uint16]*ClientConn{
- uint16(1): {
+ Clients: map[[2]byte]*ClientConn{
+ [2]byte{0, 1}: {
UserName: []byte("Testy McTest"),
RemoteAddr: "1.2.3.4:12345",
Account: &Account{
},
},
t: NewTransaction(
- TranGetClientInfoText, &[]byte{0, 1},
+ TranGetClientInfoText, [2]byte{0, 1},
NewField(FieldUserID, []byte{0, 1}),
),
},
},
},
},
- wantErr: assert.NoError,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- gotRes, err := HandleGetClientInfoText(tt.args.cc, tt.args.t)
- if !tt.wantErr(t, err, fmt.Sprintf("HandleGetClientInfoText(%v, %v)", tt.args.cc, tt.args.t)) {
- return
- }
+ gotRes := HandleGetClientInfoText(tt.args.cc, &tt.args.t)
tranAssertEqual(t, tt.wantRes, gotRes)
})
}
func TestHandleTranAgreed(t *testing.T) {
type args struct {
cc *ClientConn
- t *Transaction
+ t Transaction
}
tests := []struct {
name string
args args
wantRes []Transaction
- wantErr assert.ErrorAssertionFunc
}{
{
name: "normal request flow",
return bits
}()},
Icon: []byte{0, 1},
- Flags: []byte{0, 1},
+ Flags: [2]byte{0, 1},
Version: []byte{0, 1},
- ID: &[]byte{0, 1},
+ ID: [2]byte{0, 1},
logger: NewTestLogger(),
Server: &Server{
Config: &Config{
},
},
t: NewTransaction(
- TranAgreed, nil,
+ TranAgreed, [2]byte{},
NewField(FieldUserName, []byte("username")),
NewField(FieldUserIconID, []byte{0, 1}),
NewField(FieldOptions, []byte{0, 0}),
},
wantRes: []Transaction{
{
- clientID: &[]byte{0, 1},
+ clientID: [2]byte{0, 1},
Type: [2]byte{0, 0x7a},
Fields: []Field{
NewField(FieldBannerType, []byte("JPEG")),
},
},
{
- clientID: &[]byte{0, 1},
+ clientID: [2]byte{0, 1},
IsReply: 0x01,
Fields: []Field{},
},
},
- wantErr: assert.NoError,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- gotRes, err := HandleTranAgreed(tt.args.cc, tt.args.t)
- if !tt.wantErr(t, err, fmt.Sprintf("HandleTranAgreed(%v, %v)", tt.args.cc, tt.args.t)) {
- return
- }
+ gotRes := HandleTranAgreed(tt.args.cc, &tt.args.t)
tranAssertEqual(t, tt.wantRes, gotRes)
})
}
func TestHandleSetClientUserInfo(t *testing.T) {
type args struct {
cc *ClientConn
- t *Transaction
+ t Transaction
}
tests := []struct {
name string
args args
wantRes []Transaction
- wantErr assert.ErrorAssertionFunc
}{
{
name: "when client does not have accessAnyName",
return bits
}(),
},
- ID: &[]byte{0, 1},
+ ID: [2]byte{0, 1},
UserName: []byte("Guest"),
- Flags: []byte{0, 1},
+ Flags: [2]byte{0, 1},
Server: &Server{
- Clients: map[uint16]*ClientConn{
- uint16(1): {
- ID: &[]byte{0, 1},
+ Clients: map[[2]byte]*ClientConn{
+ [2]byte{0, 1}: {
+ ID: [2]byte{0, 1},
},
},
},
},
t: NewTransaction(
- TranSetClientUserInfo, nil,
+ TranSetClientUserInfo, [2]byte{},
NewField(FieldUserIconID, []byte{0, 1}),
NewField(FieldUserName, []byte("NOPE")),
),
},
wantRes: []Transaction{
{
- clientID: &[]byte{0, 1},
+ clientID: [2]byte{0, 1},
Type: [2]byte{0x01, 0x2d},
Fields: []Field{
NewField(FieldUserID, []byte{0, 1}),
NewField(FieldUserName, []byte("Guest"))},
},
},
- wantErr: assert.NoError,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- gotRes, err := HandleSetClientUserInfo(tt.args.cc, tt.args.t)
- if !tt.wantErr(t, err, fmt.Sprintf("HandleSetClientUserInfo(%v, %v)", tt.args.cc, tt.args.t)) {
- return
- }
-
+ gotRes := HandleSetClientUserInfo(tt.args.cc, &tt.args.t)
tranAssertEqual(t, tt.wantRes, gotRes)
})
}
func TestHandleDelNewsItem(t *testing.T) {
type args struct {
cc *ClientConn
- t *Transaction
+ t Transaction
}
tests := []struct {
name string
args args
wantRes []Transaction
- wantErr assert.ErrorAssertionFunc
}{
{
name: "when user does not have permission to delete a news category",
Account: &Account{
Access: accessBitmap{},
},
- ID: &[]byte{0, 1},
+ ID: [2]byte{0, 1},
Server: &Server{
ThreadedNews: &ThreadedNews{Categories: map[string]NewsCategoryListData15{
"test": {
},
},
t: NewTransaction(
- TranDelNewsItem, nil,
+ TranDelNewsItem, [2]byte{},
NewField(FieldNewsPath,
[]byte{
0, 1,
},
wantRes: []Transaction{
{
- clientID: &[]byte{0, 1},
+ clientID: [2]byte{0, 1},
IsReply: 0x01,
ErrorCode: [4]byte{0, 0, 0, 1},
Fields: []Field{
},
},
},
- wantErr: assert.NoError,
},
{
name: "when user does not have permission to delete a news folder",
Account: &Account{
Access: accessBitmap{},
},
- ID: &[]byte{0, 1},
+ ID: [2]byte{0, 1},
Server: &Server{
ThreadedNews: &ThreadedNews{Categories: map[string]NewsCategoryListData15{
"testcat": {
},
},
t: NewTransaction(
- TranDelNewsItem, nil,
+ TranDelNewsItem, [2]byte{},
NewField(FieldNewsPath,
[]byte{
0, 1,
},
wantRes: []Transaction{
{
- clientID: &[]byte{0, 1},
+ clientID: [2]byte{0, 1},
IsReply: 0x01,
ErrorCode: [4]byte{0, 0, 0, 1},
Fields: []Field{
},
},
},
- wantErr: assert.NoError,
},
{
name: "when user deletes a news folder",
return bits
}(),
},
- ID: &[]byte{0, 1},
+ ID: [2]byte{0, 1},
Server: &Server{
ConfigDir: "/fakeConfigRoot",
FS: func() *MockFileStore {
},
},
t: NewTransaction(
- TranDelNewsItem, nil,
+ TranDelNewsItem, [2]byte{},
NewField(FieldNewsPath,
[]byte{
0, 1,
},
wantRes: []Transaction{
{
- clientID: &[]byte{0, 1},
+ clientID: [2]byte{0, 1},
IsReply: 0x01,
Fields: []Field{},
},
},
- wantErr: assert.NoError,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- gotRes, err := HandleDelNewsItem(tt.args.cc, tt.args.t)
- if !tt.wantErr(t, err, fmt.Sprintf("HandleDelNewsItem(%v, %v)", tt.args.cc, tt.args.t)) {
- return
- }
+ gotRes := HandleDelNewsItem(tt.args.cc, &tt.args.t)
+
tranAssertEqual(t, tt.wantRes, gotRes)
})
}
func TestHandleTranOldPostNews(t *testing.T) {
type args struct {
cc *ClientConn
- t *Transaction
+ t Transaction
}
tests := []struct {
name string
args args
wantRes []Transaction
- wantErr assert.ErrorAssertionFunc
}{
{
name: "when user does not have required permission",
},
},
t: NewTransaction(
- TranOldPostNews, &[]byte{0, 1},
+ TranOldPostNews, [2]byte{0, 1},
NewField(FieldData, []byte("hai")),
),
},
},
},
},
- wantErr: assert.NoError,
},
{
name: "when user posts news update",
},
},
t: NewTransaction(
- TranOldPostNews, &[]byte{0, 1},
+ TranOldPostNews, [2]byte{0, 1},
NewField(FieldData, []byte("hai")),
),
},
IsReply: 0x01,
},
},
- wantErr: assert.NoError,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- gotRes, err := HandleTranOldPostNews(tt.args.cc, tt.args.t)
- if !tt.wantErr(t, err, fmt.Sprintf("HandleTranOldPostNews(%v, %v)", tt.args.cc, tt.args.t)) {
- return
- }
+ gotRes := HandleTranOldPostNews(tt.args.cc, &tt.args.t)
tranAssertEqual(t, tt.wantRes, gotRes)
})
func TestHandleInviteNewChat(t *testing.T) {
type args struct {
cc *ClientConn
- t *Transaction
+ t Transaction
}
tests := []struct {
name string
args args
wantRes []Transaction
- wantErr assert.ErrorAssertionFunc
}{
{
name: "when user does not have required permission",
}(),
},
},
- t: NewTransaction(TranInviteNewChat, &[]byte{0, 1}),
+ t: NewTransaction(TranInviteNewChat, [2]byte{0, 1}),
},
wantRes: []Transaction{
{
},
},
},
- wantErr: assert.NoError,
},
{
name: "when userA invites userB to new private chat",
args: args{
cc: &ClientConn{
- ID: &[]byte{0, 1},
+ ID: [2]byte{0, 1},
Account: &Account{
Access: func() accessBitmap {
var bits accessBitmap
},
UserName: []byte("UserA"),
Icon: []byte{0, 1},
- Flags: []byte{0, 0},
+ Flags: [2]byte{0, 0},
Server: &Server{
- Clients: map[uint16]*ClientConn{
- uint16(2): {
- ID: &[]byte{0, 2},
+ Clients: map[[2]byte]*ClientConn{
+ [2]byte{0, 2}: {
+ ID: [2]byte{0, 2},
UserName: []byte("UserB"),
- Flags: []byte{0, 0},
},
},
- PrivateChats: make(map[uint32]*PrivateChat),
+ PrivateChats: make(map[[4]byte]*PrivateChat),
},
},
t: NewTransaction(
- TranInviteNewChat, &[]byte{0, 1},
+ TranInviteNewChat, [2]byte{0, 1},
NewField(FieldUserID, []byte{0, 2}),
),
},
wantRes: []Transaction{
{
- clientID: &[]byte{0, 2},
+ clientID: [2]byte{0, 2},
Type: [2]byte{0, 0x71},
Fields: []Field{
NewField(FieldChatID, []byte{0x52, 0xfd, 0xfc, 0x07}),
},
{
- clientID: &[]byte{0, 1},
+ clientID: [2]byte{0, 1},
IsReply: 0x01,
Fields: []Field{
NewField(FieldChatID, []byte{0x52, 0xfd, 0xfc, 0x07}),
},
},
},
- wantErr: assert.NoError,
},
{
name: "when userA invites userB to new private chat, but UserB has refuse private chat enabled",
args: args{
cc: &ClientConn{
- ID: &[]byte{0, 1},
+ ID: [2]byte{0, 1},
Account: &Account{
Access: func() accessBitmap {
var bits accessBitmap
},
UserName: []byte("UserA"),
Icon: []byte{0, 1},
- Flags: []byte{0, 0},
+ Flags: [2]byte{0, 0},
Server: &Server{
- Clients: map[uint16]*ClientConn{
- uint16(2): {
- ID: &[]byte{0, 2},
+ Clients: map[[2]byte]*ClientConn{
+ [2]byte{0, 2}: {
+ ID: [2]byte{0, 2},
UserName: []byte("UserB"),
- Flags: []byte{255, 255},
+ Flags: [2]byte{255, 255},
},
},
- PrivateChats: make(map[uint32]*PrivateChat),
+ PrivateChats: make(map[[4]byte]*PrivateChat),
},
},
t: NewTransaction(
- TranInviteNewChat, &[]byte{0, 1},
+ TranInviteNewChat, [2]byte{0, 1},
NewField(FieldUserID, []byte{0, 2}),
),
},
wantRes: []Transaction{
{
- clientID: &[]byte{0, 1},
+ clientID: [2]byte{0, 1},
Type: [2]byte{0, 0x68},
Fields: []Field{
NewField(FieldData, []byte("UserB does not accept private chats.")),
},
},
{
- clientID: &[]byte{0, 1},
+ clientID: [2]byte{0, 1},
IsReply: 0x01,
Fields: []Field{
NewField(FieldChatID, []byte{0x52, 0xfd, 0xfc, 0x07}),
},
},
},
- wantErr: assert.NoError,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- gotRes, err := HandleInviteNewChat(tt.args.cc, tt.args.t)
- if !tt.wantErr(t, err, fmt.Sprintf("HandleInviteNewChat(%v, %v)", tt.args.cc, tt.args.t)) {
- return
- }
+ gotRes := HandleInviteNewChat(tt.args.cc, &tt.args.t)
+
tranAssertEqual(t, tt.wantRes, gotRes)
})
}
func TestHandleGetNewsArtData(t *testing.T) {
type args struct {
cc *ClientConn
- t *Transaction
+ t Transaction
}
tests := []struct {
name string
args args
wantRes []Transaction
- wantErr assert.ErrorAssertionFunc
}{
{
name: "when user does not have required permission",
},
},
t: NewTransaction(
- TranGetNewsArtData, &[]byte{0, 1},
+ TranGetNewsArtData, [2]byte{0, 1},
),
},
wantRes: []Transaction{
},
},
},
- wantErr: assert.NoError,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- gotRes, err := HandleGetNewsArtData(tt.args.cc, tt.args.t)
- if !tt.wantErr(t, err, fmt.Sprintf("HandleGetNewsArtData(%v, %v)", tt.args.cc, tt.args.t)) {
- return
- }
+ gotRes := HandleGetNewsArtData(tt.args.cc, &tt.args.t)
tranAssertEqual(t, tt.wantRes, gotRes)
})
}
func TestHandleGetNewsArtNameList(t *testing.T) {
type args struct {
cc *ClientConn
- t *Transaction
+ t Transaction
}
tests := []struct {
name string
args args
wantRes []Transaction
- wantErr assert.ErrorAssertionFunc
}{
{
name: "when user does not have required permission",
},
},
t: NewTransaction(
- TranGetNewsArtNameList, &[]byte{0, 1},
+ TranGetNewsArtNameList, [2]byte{0, 1},
),
},
wantRes: []Transaction{
},
},
},
- wantErr: assert.NoError,
},
{
name: "when user has required access",
},
t: NewTransaction(
TranGetNewsArtNameList,
- &[]byte{0, 1},
+ [2]byte{0, 1},
// 00000000 00 01 00 00 10 45 78 61 6d 70 6c 65 20 43 61 74 |.....Example Cat|
// 00000010 65 67 6f 72 79 |egory|
NewField(FieldNewsPath, []byte{
},
},
},
- wantErr: assert.NoError,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- gotRes, err := HandleGetNewsArtNameList(tt.args.cc, tt.args.t)
- if !tt.wantErr(t, err, fmt.Sprintf("HandleGetNewsArtNameList(%v, %v)", tt.args.cc, tt.args.t)) {
- return
- }
+ gotRes := HandleGetNewsArtNameList(tt.args.cc, &tt.args.t)
+
tranAssertEqual(t, tt.wantRes, gotRes)
})
}
func TestHandleNewNewsFldr(t *testing.T) {
type args struct {
cc *ClientConn
- t *Transaction
+ t Transaction
}
tests := []struct {
name string
args args
wantRes []Transaction
- wantErr assert.ErrorAssertionFunc
}{
{
name: "when user does not have required permission",
},
},
t: NewTransaction(
- TranGetNewsArtNameList, &[]byte{0, 1},
+ TranGetNewsArtNameList, [2]byte{0, 1},
),
},
wantRes: []Transaction{
},
},
},
- wantErr: assert.NoError,
},
{
name: "with a valid request",
}(),
},
logger: NewTestLogger(),
- ID: &[]byte{0, 1},
+ ID: [2]byte{0, 1},
Server: &Server{
ConfigDir: "/fakeConfigRoot",
FS: func() *MockFileStore {
},
},
t: NewTransaction(
- TranGetNewsArtNameList, &[]byte{0, 1},
+ TranGetNewsArtNameList, [2]byte{0, 1},
NewField(FieldFileName, []byte("testFolder")),
NewField(FieldNewsPath,
[]byte{
},
wantRes: []Transaction{
{
- clientID: &[]byte{0, 1},
+ clientID: [2]byte{0, 1},
IsReply: 0x01,
Fields: []Field{},
},
},
- wantErr: assert.NoError,
},
//{
// Name: "when there is an error writing the threaded news file",
// }(),
// },
// logger: NewTestLogger(),
- // ID: &[]byte{0, 1},
+ // ID: [2]byte{0, 1},
// Server: &Server{
// ConfigDir: "/fakeConfigRoot",
// FS: func() *MockFileStore {
// },
// },
// t: NewTransaction(
- // TranGetNewsArtNameList, &[]byte{0, 1},
+ // TranGetNewsArtNameList, [2]byte{0, 1},
// NewField(FieldFileName, []byte("testFolder")),
// NewField(FieldNewsPath,
// []byte{
// },
// wantRes: []Transaction{
// {
- // clientID: &[]byte{0, 1},
+ // clientID: [2]byte{0, 1},
// Flags: 0x00,
// IsReply: 0x01,
// Type: [2]byte{0, 0},
// },
// },
// },
- // wantErr: assert.Error,
- // },
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- gotRes, err := HandleNewNewsFldr(tt.args.cc, tt.args.t)
- if !tt.wantErr(t, err, fmt.Sprintf("HandleNewNewsFldr(%v, %v)", tt.args.cc, tt.args.t)) {
- return
- }
+ gotRes := HandleNewNewsFldr(tt.args.cc, &tt.args.t)
+
tranAssertEqual(t, tt.wantRes, gotRes)
})
}
func TestHandleDownloadBanner(t *testing.T) {
type args struct {
cc *ClientConn
- t *Transaction
+ t Transaction
}
tests := []struct {
name string
args args
wantRes []Transaction
- wantErr assert.ErrorAssertionFunc
}{
// TODO: Add test cases.
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- gotRes, err := HandleDownloadBanner(tt.args.cc, tt.args.t)
- if !tt.wantErr(t, err, fmt.Sprintf("HandleDownloadBanner(%v, %v)", tt.args.cc, tt.args.t)) {
- return
- }
- assert.Equalf(t, tt.wantRes, gotRes, "HandleDownloadBanner(%v, %v)", tt.args.cc, tt.args.t)
+ gotRes := HandleDownloadBanner(tt.args.cc, &tt.args.t)
+
+ assert.Equalf(t, tt.wantRes, gotRes, "HandleDownloadBanner(%v, %v)", tt.args.cc, &tt.args.t)
+ })
+ }
+}
+
+func TestHandlePostNewsArt(t *testing.T) {
+ type args struct {
+ cc *ClientConn
+ t Transaction
+ }
+ tests := []struct {
+ name string
+ args args
+ wantRes []Transaction
+ }{
+ {
+ name: "without required permission",
+ args: args{
+ cc: &ClientConn{
+ Account: &Account{
+ Access: func() accessBitmap {
+ var bits accessBitmap
+ return bits
+ }(),
+ },
+ },
+ t: NewTransaction(
+ TranPostNewsArt,
+ [2]byte{0, 0},
+ ),
+ },
+ wantRes: []Transaction{
+ {
+ IsReply: 0x01,
+ ErrorCode: [4]byte{0, 0, 0, 1},
+ Fields: []Field{
+ NewField(FieldError, []byte("You are not allowed to post news articles.")),
+ },
+ },
+ },
+ },
+ {
+ name: "with required permission",
+ args: args{
+ cc: &ClientConn{
+ Server: &Server{
+ FS: func() *MockFileStore {
+ mfs := &MockFileStore{}
+ mfs.On("WriteFile", "ThreadedNews.yaml", mock.Anything, mock.Anything).Return(nil, os.ErrNotExist)
+ return mfs
+ }(),
+ mux: sync.Mutex{},
+ threadedNewsMux: sync.Mutex{},
+ ThreadedNews: &ThreadedNews{
+ Categories: map[string]NewsCategoryListData15{
+ "www": {
+ Type: [2]byte{},
+ Name: "www",
+ Articles: map[uint32]*NewsArtData{},
+ SubCats: nil,
+ GUID: [16]byte{},
+ AddSN: [4]byte{},
+ DeleteSN: [4]byte{},
+ readOffset: 0,
+ },
+ },
+ },
+ },
+ Account: &Account{
+ Access: func() accessBitmap {
+ var bits accessBitmap
+ bits.Set(accessNewsPostArt)
+ return bits
+ }(),
+ },
+ },
+ t: NewTransaction(
+ TranPostNewsArt,
+ [2]byte{0, 0},
+ NewField(FieldNewsPath, []byte{0x00, 0x01, 0x00, 0x00, 0x03, 0x77, 0x77, 0x77}),
+ NewField(FieldNewsArtID, []byte{0x00, 0x00, 0x00, 0x00}),
+ ),
+ },
+ wantRes: []Transaction{
+ {
+ IsReply: 0x01,
+ ErrorCode: [4]byte{0, 0, 0, 0},
+ Fields: []Field{},
+ },
+ },
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ tranAssertEqual(t, tt.wantRes, HandlePostNewsArt(tt.args.cc, &tt.args.t))
})
}
}
git.r.bdr.sh / rbdr / mobius / blobdiff