Fix account management edge cases

[rbdr/mobius] / hotline / transfer.go

diff --git a/hotline/transfer.go b/hotline/transfer.go
index 73331970e33648900b0642de8754a234da933f0f..2acb5d6b6e6b689c59e776daca8db8e2ef2f5f28 100644 (file)
--- a/hotline/transfer.go
+++ b/hotline/transfer.go
@@ -1,11 +1,12 @@
 package hotline
 
 import (
 package hotline
 
 import (

-       "bufio"

        "bytes"
        "encoding/binary"
        "errors"
        "io"
        "bytes"
        "encoding/binary"
        "errors"
        "io"

+       "os"
+       "path/filepath"

 )
 
 type transfer struct {
 )
 
 type transfer struct {


@@ -29,9 +30,7 @@ func (tf *transfer) Write(b []byte) (int, error) {
        return len(b), nil
 }
 
        return len(b), nil
 }
 

-const fileCopyBufSize = 4096
-
-func receiveFile(r io.Reader, targetFile, resForkFile, infoFork io.Writer) error {
+func receiveFile(r io.Reader, targetFile, resForkFile, infoFork, counterWriter io.Writer) error {

        var ffo flattenedFileObject
        if _, err := ffo.ReadFrom(r); err != nil {
                return err
        var ffo flattenedFileObject
        if _, err := ffo.ReadFrom(r); err != nil {
                return err


@@ -43,12 +42,7 @@ func receiveFile(r io.Reader, targetFile, resForkFile, infoFork io.Writer) error
                return err
        }
 
                return err
        }
 

-       // read and write the data fork
-       bw := bufio.NewWriterSize(targetFile, fileCopyBufSize)
-       if _, err = io.CopyN(bw, r, ffo.dataSize()); err != nil {
-               return err
-       }
-       if err := bw.Flush(); err != nil {
+       if _, err = io.CopyN(targetFile, io.TeeReader(r, counterWriter), ffo.dataSize()); err != nil {

                return err
        }
 
                return err
        }
 


@@ -57,44 +51,19 @@ func receiveFile(r io.Reader, targetFile, resForkFile, infoFork io.Writer) error
                        return err
                }
 
                        return err
                }
 

-               bw = bufio.NewWriterSize(resForkFile, fileCopyBufSize)
-               _, err = io.CopyN(resForkFile, r, ffo.rsrcSize())
-               if err != nil {
-                       return err
-               }
-               if err := bw.Flush(); err != nil {
+               if _, err = io.CopyN(resForkFile, io.TeeReader(r, counterWriter), ffo.rsrcSize()); err != nil {

                        return err
                }
        }
        return nil
 }
 
                        return err
                }
        }
        return nil
 }
 

-func sendFile(w io.Writer, r io.Reader, offset int) (err error) {
-       br := bufio.NewReader(r)
-       if _, err := br.Discard(offset); err != nil {
+func (s *Server) bannerDownload(w io.Writer) error {
+       bannerBytes, err := os.ReadFile(filepath.Join(s.ConfigDir, s.Config.BannerFile))
+       if err != nil {

                return err
        }
                return err
        }

+       _, err = w.Write(bannerBytes)

 
 

-       rSendBuffer := make([]byte, 1024)
-       for {
-               var bytesRead int
-
-               if bytesRead, err = br.Read(rSendBuffer); err == io.EOF {
-                       if _, err := w.Write(rSendBuffer[:bytesRead]); err != nil {
-                               return err
-                       }
-                       return nil
-               }
-               if err != nil {
-                       return err
-               }
-               // totalSent += int64(bytesRead)
-
-               // fileTransfer.BytesSent += bytesRead
-
-               if _, err := w.Write(rSendBuffer[:bytesRead]); err != nil {
-                       return err
-               }
-       }
-
+       return err

 }
 }