"errors"
"fmt"
"github.com/stretchr/testify/assert"
+ "github.com/stretchr/testify/mock"
+ "io"
"io/fs"
"math/rand"
"os"
ClientConn: map[uint16]*ClientConn{
uint16(1): {
Account: &Account{
- Access: &[]byte{255, 255, 255, 255, 255, 255, 255, 255},
+ Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
},
ID: &[]byte{0, 1},
},
uint16(2): {
Account: &Account{
- Access: &[]byte{255, 255, 255, 255, 255, 255, 255, 255},
+ Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
},
ID: &[]byte{0, 2},
},
Clients: map[uint16]*ClientConn{
uint16(1): {
Account: &Account{
- Access: &[]byte{255, 255, 255, 255, 255, 255, 255, 255},
+ Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
},
ID: &[]byte{0, 1},
},
uint16(2): {
Account: &Account{
- Access: &[]byte{255, 255, 255, 255, 255, 255, 255, 255},
+ Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
},
ID: &[]byte{0, 2},
},
ID: []byte{0, 0, 0, 1},
ErrorCode: []byte{0, 0, 0, 0},
Fields: []Field{
- NewField(fieldChatID, []byte{0, 0, 0, 1}),
- NewField(fieldChatSubject, []byte("Test Subject")),
+ NewField(FieldChatID, []byte{0, 0, 0, 1}),
+ NewField(FieldChatSubject, []byte("Test Subject")),
},
},
},
ID: []byte{0x9a, 0xcb, 0x04, 0x42}, // Random ID from rand.Seed(1)
ErrorCode: []byte{0, 0, 0, 0},
Fields: []Field{
- NewField(fieldChatID, []byte{0, 0, 0, 1}),
- NewField(fieldChatSubject, []byte("Test Subject")),
+ NewField(FieldChatID, []byte{0, 0, 0, 1}),
+ NewField(FieldChatSubject, []byte("Test Subject")),
},
},
{
ID: []byte{0xf0, 0xc5, 0x34, 0x1e}, // Random ID from rand.Seed(1)
ErrorCode: []byte{0, 0, 0, 0},
Fields: []Field{
- NewField(fieldChatID, []byte{0, 0, 0, 1}),
- NewField(fieldChatSubject, []byte("Test Subject")),
+ NewField(FieldChatID, []byte{0, 0, 0, 1}),
+ NewField(FieldChatSubject, []byte("Test Subject")),
},
},
},
ClientConn: map[uint16]*ClientConn{
uint16(1): {
Account: &Account{
- Access: &[]byte{255, 255, 255, 255, 255, 255, 255, 255},
+ Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
},
ID: &[]byte{0, 1},
},
uint16(2): {
Account: &Account{
- Access: &[]byte{255, 255, 255, 255, 255, 255, 255, 255},
+ Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
},
ID: &[]byte{0, 2},
},
Clients: map[uint16]*ClientConn{
uint16(1): {
Account: &Account{
- Access: &[]byte{255, 255, 255, 255, 255, 255, 255, 255},
+ Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
},
ID: &[]byte{0, 1},
},
uint16(2): {
Account: &Account{
- Access: &[]byte{255, 255, 255, 255, 255, 255, 255, 255},
+ Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
},
ID: &[]byte{0, 2},
},
},
},
},
- t: NewTransaction(tranDeleteUser, nil, NewField(fieldChatID, []byte{0, 0, 0, 1})),
+ t: NewTransaction(TranDeleteUser, nil, NewField(FieldChatID, []byte{0, 0, 0, 1})),
},
want: []Transaction{
{
ID: []byte{0x9a, 0xcb, 0x04, 0x42}, // Random ID from rand.Seed(1)
ErrorCode: []byte{0, 0, 0, 0},
Fields: []Field{
- NewField(fieldChatID, []byte{0, 0, 0, 1}),
- NewField(fieldUserID, []byte{0, 2}),
+ NewField(FieldChatID, []byte{0, 0, 0, 1}),
+ NewField(FieldUserID, []byte{0, 2}),
},
},
},
Icon: []byte{0, 2},
Flags: []byte{0, 3},
UserName: []byte{0, 4},
- Agreed: true,
},
uint16(2): {
ID: &[]byte{0, 2},
Icon: []byte{0, 2},
Flags: []byte{0, 3},
UserName: []byte{0, 4},
- Agreed: true,
- },
- uint16(3): {
- ID: &[]byte{0, 3},
- Icon: []byte{0, 2},
- Flags: []byte{0, 3},
- UserName: []byte{0, 4},
- Agreed: false,
},
},
},
clientID: &[]byte{1, 1},
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 1},
+ Type: []byte{0, 0},
ID: []byte{0, 0, 0, 1},
ErrorCode: []byte{0, 0, 0, 0},
Fields: []Field{
NewField(
- fieldUsernameWithInfo,
+ FieldUsernameWithInfo,
[]byte{00, 01, 00, 02, 00, 03, 00, 02, 00, 04},
),
NewField(
- fieldUsernameWithInfo,
+ FieldUsernameWithInfo,
[]byte{00, 02, 00, 02, 00, 03, 00, 02, 00, 04},
),
},
args: args{
cc: &ClientConn{
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
+ var bits accessBitmap
+ bits.Set(accessSendChat)
+ return bits
+ }(),
+ },
+ UserName: []byte{0x00, 0x01},
+ Server: &Server{
+ Clients: map[uint16]*ClientConn{
+ uint16(1): {
+ Account: &Account{
+ Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
+ },
+ ID: &[]byte{0, 1},
+ },
+ uint16(2): {
+ Account: &Account{
+ Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
+ },
+ ID: &[]byte{0, 2},
+ },
+ },
+ },
+ },
+ t: &Transaction{
+ Fields: []Field{
+ NewField(FieldData, []byte("hai")),
+ },
+ },
+ },
+ want: []Transaction{
+ {
+ clientID: &[]byte{0, 1},
+ Flags: 0x00,
+ IsReply: 0x00,
+ Type: []byte{0, 0x6a},
+ ID: []byte{0x9a, 0xcb, 0x04, 0x42}, // Random ID from rand.Seed(1)
+ ErrorCode: []byte{0, 0, 0, 0},
+ Fields: []Field{
+ NewField(FieldData, []byte{0x0d, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x00, 0x01, 0x3a, 0x20, 0x20, 0x68, 0x61, 0x69}),
+ },
+ },
+ {
+ clientID: &[]byte{0, 2},
+ Flags: 0x00,
+ IsReply: 0x00,
+ Type: []byte{0, 0x6a},
+ ID: []byte{0xf0, 0xc5, 0x34, 0x1e}, // Random ID from rand.Seed(1)
+ ErrorCode: []byte{0, 0, 0, 0},
+ Fields: []Field{
+ NewField(FieldData, []byte{0x0d, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x00, 0x01, 0x3a, 0x20, 0x20, 0x68, 0x61, 0x69}),
+ },
+ },
+ },
+ wantErr: false,
+ },
+ {
+ name: "treats Chat ID 00 00 00 00 as a public chat message",
+ args: args{
+ cc: &ClientConn{
+ Account: &Account{
+ Access: func() accessBitmap {
var bits accessBitmap
bits.Set(accessSendChat)
- access := bits[:]
- return &access
+ return bits
}(),
},
UserName: []byte{0x00, 0x01},
Clients: map[uint16]*ClientConn{
uint16(1): {
Account: &Account{
- Access: &[]byte{255, 255, 255, 255, 255, 255, 255, 255},
+ Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
},
ID: &[]byte{0, 1},
},
uint16(2): {
Account: &Account{
- Access: &[]byte{255, 255, 255, 255, 255, 255, 255, 255},
+ Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
},
ID: &[]byte{0, 2},
},
},
t: &Transaction{
Fields: []Field{
- NewField(fieldData, []byte("hai")),
+ NewField(FieldData, []byte("hai")),
+ NewField(FieldChatID, []byte{0, 0, 0, 0}),
},
},
},
ID: []byte{0x9a, 0xcb, 0x04, 0x42}, // Random ID from rand.Seed(1)
ErrorCode: []byte{0, 0, 0, 0},
Fields: []Field{
- NewField(fieldData, []byte{0x0d, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x00, 0x01, 0x3a, 0x20, 0x20, 0x68, 0x61, 0x69}),
+ NewField(FieldData, []byte{0x0d, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x00, 0x01, 0x3a, 0x20, 0x20, 0x68, 0x61, 0x69}),
},
},
{
ID: []byte{0xf0, 0xc5, 0x34, 0x1e}, // Random ID from rand.Seed(1)
ErrorCode: []byte{0, 0, 0, 0},
Fields: []Field{
- NewField(fieldData, []byte{0x0d, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x00, 0x01, 0x3a, 0x20, 0x20, 0x68, 0x61, 0x69}),
+ NewField(FieldData, []byte{0x0d, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x00, 0x01, 0x3a, 0x20, 0x20, 0x68, 0x61, 0x69}),
},
},
},
args: args{
cc: &ClientConn{
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
- access := bits[:]
- return &access
+ return bits
}(),
},
Server: &Server{
},
},
t: NewTransaction(
- tranChatSend, &[]byte{0, 1},
- NewField(fieldData, []byte("hai")),
+ TranChatSend, &[]byte{0, 1},
+ NewField(FieldData, []byte("hai")),
),
},
want: []Transaction{
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0x00},
+ Type: []byte{0, 0},
ID: []byte{0x9a, 0xcb, 0x04, 0x42},
ErrorCode: []byte{0, 0, 0, 1},
Fields: []Field{
- NewField(fieldError, []byte("You are not allowed to participate in chat.")),
+ NewField(FieldError, []byte("You are not allowed to participate in chat.")),
+ },
+ },
+ },
+ wantErr: false,
+ },
+ {
+ name: "sends chat msg as emote if FieldChatOptions is set to 1",
+ args: args{
+ cc: &ClientConn{
+ Account: &Account{
+ Access: func() accessBitmap {
+ var bits accessBitmap
+ bits.Set(accessSendChat)
+ return bits
+ }(),
+ },
+ UserName: []byte("Testy McTest"),
+ Server: &Server{
+ Clients: map[uint16]*ClientConn{
+ uint16(1): {
+ Account: &Account{
+ Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
+ },
+ ID: &[]byte{0, 1},
+ },
+ uint16(2): {
+ Account: &Account{
+ Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
+ },
+ ID: &[]byte{0, 2},
+ },
+ },
+ },
+ },
+ t: &Transaction{
+ Fields: []Field{
+ NewField(FieldData, []byte("performed action")),
+ NewField(FieldChatOptions, []byte{0x00, 0x01}),
+ },
+ },
+ },
+ want: []Transaction{
+ {
+ clientID: &[]byte{0, 1},
+ Flags: 0x00,
+ IsReply: 0x00,
+ Type: []byte{0, 0x6a},
+ ID: []byte{0x9a, 0xcb, 0x04, 0x42},
+ ErrorCode: []byte{0, 0, 0, 0},
+ Fields: []Field{
+ NewField(FieldData, []byte("\r*** Testy McTest performed action")),
+ },
+ },
+ {
+ clientID: &[]byte{0, 2},
+ Flags: 0x00,
+ IsReply: 0x00,
+ Type: []byte{0, 0x6a},
+ ID: []byte{0xf0, 0xc5, 0x34, 0x1e},
+ ErrorCode: []byte{0, 0, 0, 0},
+ Fields: []Field{
+ NewField(FieldData, []byte("\r*** Testy McTest performed action")),
},
},
},
wantErr: false,
},
{
- name: "sends chat msg as emote if fieldChatOptions is set",
+ name: "does not send chat msg as emote if FieldChatOptions is set to 0",
args: args{
cc: &ClientConn{
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
bits.Set(accessSendChat)
- access := bits[:]
- return &access
+ return bits
}(),
},
UserName: []byte("Testy McTest"),
Clients: map[uint16]*ClientConn{
uint16(1): {
Account: &Account{
- Access: &[]byte{255, 255, 255, 255, 255, 255, 255, 255},
+ Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
},
ID: &[]byte{0, 1},
},
uint16(2): {
Account: &Account{
- Access: &[]byte{255, 255, 255, 255, 255, 255, 255, 255},
+ Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
},
ID: &[]byte{0, 2},
},
},
t: &Transaction{
Fields: []Field{
- NewField(fieldData, []byte("performed action")),
- NewField(fieldChatOptions, []byte{0x00, 0x01}),
+ NewField(FieldData, []byte("hello")),
+ NewField(FieldChatOptions, []byte{0x00, 0x00}),
},
},
},
ID: []byte{0x9a, 0xcb, 0x04, 0x42},
ErrorCode: []byte{0, 0, 0, 0},
Fields: []Field{
- NewField(fieldData, []byte("\r*** Testy McTest performed action")),
+ NewField(FieldData, []byte("\r Testy McTest: hello")),
},
},
{
ID: []byte{0xf0, 0xc5, 0x34, 0x1e},
ErrorCode: []byte{0, 0, 0, 0},
Fields: []Field{
- NewField(fieldData, []byte("\r*** Testy McTest performed action")),
+ NewField(FieldData, []byte("\r Testy McTest: hello")),
},
},
},
args: args{
cc: &ClientConn{
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
bits.Set(accessSendChat)
- access := bits[:]
- return &access
+ return bits
}(),
},
UserName: []byte{0x00, 0x01},
Clients: map[uint16]*ClientConn{
uint16(1): {
Account: &Account{
- Access: &[]byte{255, 255, 255, 255, 255, 255, 255, 255},
- },
+ Access: func() accessBitmap {
+ var bits accessBitmap
+ bits.Set(accessReadChat)
+ return bits
+ }()},
ID: &[]byte{0, 1},
},
uint16(2): {
Account: &Account{
- Access: &[]byte{0, 0, 0, 0, 0, 0, 0, 0},
+ Access: accessBitmap{0, 0, 0, 0, 0, 0, 0, 0},
},
ID: &[]byte{0, 2},
},
},
t: &Transaction{
Fields: []Field{
- NewField(fieldData, []byte("hai")),
+ NewField(FieldData, []byte("hai")),
},
},
},
ID: []byte{0x9a, 0xcb, 0x04, 0x42}, // Random ID from rand.Seed(1)
ErrorCode: []byte{0, 0, 0, 0},
Fields: []Field{
- NewField(fieldData, []byte{0x0d, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x00, 0x01, 0x3a, 0x20, 0x20, 0x68, 0x61, 0x69}),
+ NewField(FieldData, []byte{0x0d, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x00, 0x01, 0x3a, 0x20, 0x20, 0x68, 0x61, 0x69}),
},
},
},
args: args{
cc: &ClientConn{
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
bits.Set(accessSendChat)
- access := bits[:]
- return &access
+ return bits
}(),
},
UserName: []byte{0x00, 0x01},
Clients: map[uint16]*ClientConn{
uint16(1): {
Account: &Account{
- Access: &[]byte{255, 255, 255, 255, 255, 255, 255, 255},
+ Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
},
ID: &[]byte{0, 1},
},
uint16(2): {
Account: &Account{
- Access: &[]byte{0, 0, 0, 0, 0, 0, 0, 0},
+ Access: accessBitmap{0, 0, 0, 0, 0, 0, 0, 0},
},
ID: &[]byte{0, 2},
},
uint16(3): {
Account: &Account{
- Access: &[]byte{0, 0, 0, 0, 0, 0, 0, 0},
+ Access: accessBitmap{0, 0, 0, 0, 0, 0, 0, 0},
},
ID: &[]byte{0, 3},
},
},
t: &Transaction{
Fields: []Field{
- NewField(fieldData, []byte("hai")),
- NewField(fieldChatID, []byte{0, 0, 0, 1}),
+ NewField(FieldData, []byte("hai")),
+ NewField(FieldChatID, []byte{0, 0, 0, 1}),
},
},
},
ID: []byte{0x9a, 0xcb, 0x04, 0x42},
ErrorCode: []byte{0, 0, 0, 0},
Fields: []Field{
- NewField(fieldChatID, []byte{0, 0, 0, 1}),
- NewField(fieldData, []byte{0x0d, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x00, 0x01, 0x3a, 0x20, 0x20, 0x68, 0x61, 0x69}),
+ NewField(FieldChatID, []byte{0, 0, 0, 1}),
+ NewField(FieldData, []byte{0x0d, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x00, 0x01, 0x3a, 0x20, 0x20, 0x68, 0x61, 0x69}),
},
},
{
ID: []byte{0x9a, 0xcb, 0x04, 0x42},
ErrorCode: []byte{0, 0, 0, 0},
Fields: []Field{
- NewField(fieldChatID, []byte{0, 0, 0, 1}),
- NewField(fieldData, []byte{0x0d, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x00, 0x01, 0x3a, 0x20, 0x20, 0x68, 0x61, 0x69}),
+ NewField(FieldChatID, []byte{0, 0, 0, 1}),
+ NewField(FieldData, []byte{0x0d, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x00, 0x01, 0x3a, 0x20, 0x20, 0x68, 0x61, 0x69}),
},
},
},
},
},
t: NewTransaction(
- tranGetFileInfo, nil,
- NewField(fieldFileName, []byte("testfile.txt")),
- NewField(fieldFilePath, []byte{0x00, 0x00}),
+ TranGetFileInfo, nil,
+ NewField(FieldFileName, []byte("testfile.txt")),
+ NewField(FieldFilePath, []byte{0x00, 0x00}),
),
},
wantRes: []Transaction{
clientID: &[]byte{0, 1},
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0xce},
+ Type: []byte{0, 0},
ID: []byte{0x9a, 0xcb, 0x04, 0x42}, // Random ID from rand.Seed(1)
ErrorCode: []byte{0, 0, 0, 0},
Fields: []Field{
- NewField(fieldFileName, []byte("testfile.txt")),
- NewField(fieldFileTypeString, []byte("Text File")),
- NewField(fieldFileCreatorString, []byte("ttxt")),
- NewField(fieldFileComment, []byte{}),
- NewField(fieldFileType, []byte("TEXT")),
- NewField(fieldFileCreateDate, make([]byte, 8)),
- NewField(fieldFileModifyDate, make([]byte, 8)),
- NewField(fieldFileSize, []byte{0x0, 0x0, 0x0, 0x17}),
+ NewField(FieldFileName, []byte("testfile.txt")),
+ NewField(FieldFileTypeString, []byte("Text File")),
+ NewField(FieldFileCreatorString, []byte("ttxt")),
+ NewField(FieldFileType, []byte("TEXT")),
+ NewField(FieldFileCreateDate, make([]byte, 8)),
+ NewField(FieldFileModifyDate, make([]byte, 8)),
+ NewField(FieldFileSize, []byte{0x0, 0x0, 0x0, 0x17}),
},
},
},
// Clear the fileWrapper timestamp fields to work around problems running the tests in multiple timezones
// TODO: revisit how to test this by mocking the stat calls
+ gotRes[0].Fields[4].Data = make([]byte, 8)
gotRes[0].Fields[5].Data = make([]byte, 8)
- gotRes[0].Fields[6].Data = make([]byte, 8)
if !assert.Equal(t, tt.wantRes, gotRes) {
t.Errorf("HandleGetFileInfo() gotRes = %v, want %v", gotRes, tt.wantRes)
}
args: args{
cc: &ClientConn{
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
- access := bits[:]
- return &access
+ return bits
}(),
},
},
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0x00},
+ Type: []byte{0, 0},
ID: []byte{0x9a, 0xcb, 0x04, 0x42},
ErrorCode: []byte{0, 0, 0, 1},
Fields: []Field{
- NewField(fieldError, []byte("You are not allowed to create folders.")),
+ NewField(FieldError, []byte("You are not allowed to create folders.")),
},
},
},
args: args{
cc: &ClientConn{
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
bits.Set(accessCreateFolder)
- access := bits[:]
- return &access
+ return bits
}(),
},
ID: &[]byte{0, 1},
},
},
t: NewTransaction(
- tranNewFolder, &[]byte{0, 1},
- NewField(fieldFileName, []byte("testFolder")),
- NewField(fieldFilePath, []byte{
+ TranNewFolder, &[]byte{0, 1},
+ NewField(FieldFileName, []byte("testFolder")),
+ NewField(FieldFilePath, []byte{
0x00, 0x01,
0x00, 0x00,
0x03,
clientID: &[]byte{0, 1},
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0xcd},
+ Type: []byte{0, 0},
ID: []byte{0x9a, 0xcb, 0x04, 0x42}, // Random ID from rand.Seed(1)
ErrorCode: []byte{0, 0, 0, 0},
},
args: args{
cc: &ClientConn{
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
bits.Set(accessCreateFolder)
- access := bits[:]
- return &access
+ return bits
}(),
},
ID: &[]byte{0, 1},
},
},
t: NewTransaction(
- tranNewFolder, &[]byte{0, 1},
- NewField(fieldFileName, []byte("testFolder")),
+ TranNewFolder, &[]byte{0, 1},
+ NewField(FieldFileName, []byte("testFolder")),
),
},
wantRes: []Transaction{
clientID: &[]byte{0, 1},
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0xcd},
+ Type: []byte{0, 0},
ID: []byte{0x9a, 0xcb, 0x04, 0x42}, // Random ID from rand.Seed(1)
ErrorCode: []byte{0, 0, 0, 0},
},
wantErr: false,
},
{
- name: "when UnmarshalBinary returns an err",
+ name: "when Write returns an err",
args: args{
cc: &ClientConn{
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
bits.Set(accessCreateFolder)
- access := bits[:]
- return &access
+ return bits
}(),
},
ID: &[]byte{0, 1},
},
},
t: NewTransaction(
- tranNewFolder, &[]byte{0, 1},
- NewField(fieldFileName, []byte("testFolder")),
- NewField(fieldFilePath, []byte{
+ TranNewFolder, &[]byte{0, 1},
+ NewField(FieldFileName, []byte("testFolder")),
+ NewField(FieldFilePath, []byte{
0x00,
}),
),
wantErr: true,
},
{
- name: "fieldFileName does not allow directory traversal",
+ name: "FieldFileName does not allow directory traversal",
args: args{
cc: &ClientConn{
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
bits.Set(accessCreateFolder)
- access := bits[:]
- return &access
+ return bits
}(),
},
ID: &[]byte{0, 1},
},
},
t: NewTransaction(
- tranNewFolder, &[]byte{0, 1},
- NewField(fieldFileName, []byte("../../testFolder")),
+ TranNewFolder, &[]byte{0, 1},
+ NewField(FieldFileName, []byte("../../testFolder")),
),
},
wantRes: []Transaction{
clientID: &[]byte{0, 1},
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0xcd},
+ Type: []byte{0, 0},
ID: []byte{0x9a, 0xcb, 0x04, 0x42}, // Random ID from rand.Seed(1)
ErrorCode: []byte{0, 0, 0, 0},
},
}, wantErr: false,
},
{
- name: "fieldFilePath does not allow directory traversal",
+ name: "FieldFilePath does not allow directory traversal",
args: args{
cc: &ClientConn{
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
bits.Set(accessCreateFolder)
- access := bits[:]
- return &access
+ return bits
}(),
},
ID: &[]byte{0, 1},
},
},
t: NewTransaction(
- tranNewFolder, &[]byte{0, 1},
- NewField(fieldFileName, []byte("testFolder")),
- NewField(fieldFilePath, []byte{
+ TranNewFolder, &[]byte{0, 1},
+ NewField(FieldFileName, []byte("testFolder")),
+ NewField(FieldFilePath, []byte{
0x00, 0x02,
0x00, 0x00,
0x03,
clientID: &[]byte{0, 1},
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0xcd},
+ Type: []byte{0, 0},
ID: []byte{0x9a, 0xcb, 0x04, 0x42}, // Random ID from rand.Seed(1)
ErrorCode: []byte{0, 0, 0, 0},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
-
gotRes, err := HandleNewFolder(tt.args.cc, tt.args.t)
if (err != nil) != tt.wantErr {
t.Errorf("HandleNewFolder() error = %v, wantErr %v", err, tt.wantErr)
FileUpload: {},
},
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
bits.Set(accessUploadFile)
bits.Set(accessUploadAnywhere)
- access := bits[:]
- return &access
+ return bits
}(),
},
},
t: NewTransaction(
- tranUploadFile, &[]byte{0, 1},
- NewField(fieldFileName, []byte("testFile")),
- NewField(fieldFilePath, []byte{
+ TranUploadFile, &[]byte{0, 1},
+ NewField(FieldFileName, []byte("testFile")),
+ NewField(FieldFilePath, []byte{
0x00, 0x01,
0x00, 0x00,
0x03,
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0xcb},
+ Type: []byte{0, 0},
ID: []byte{0x9a, 0xcb, 0x04, 0x42},
ErrorCode: []byte{0, 0, 0, 0},
Fields: []Field{
- NewField(fieldRefNum, []byte{0x52, 0xfd, 0xfc, 0x07}), // rand.Seed(1)
+ NewField(FieldRefNum, []byte{0x52, 0xfd, 0xfc, 0x07}), // rand.Seed(1)
},
},
},
args: args{
cc: &ClientConn{
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
- access := bits[:]
- return &access
+ return bits
}(),
},
},
t: NewTransaction(
- tranUploadFile, &[]byte{0, 1},
- NewField(fieldFileName, []byte("testFile")),
- NewField(fieldFilePath, []byte{
+ TranUploadFile, &[]byte{0, 1},
+ NewField(FieldFileName, []byte("testFile")),
+ NewField(FieldFilePath, []byte{
0x00, 0x01,
0x00, 0x00,
0x03,
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0x00},
+ Type: []byte{0, 0},
ID: []byte{0x9a, 0xcb, 0x04, 0x42},
ErrorCode: []byte{0, 0, 0, 1},
Fields: []Field{
- NewField(fieldError, []byte("You are not allowed to upload files.")), // rand.Seed(1)
+ NewField(FieldError, []byte("You are not allowed to upload files.")), // rand.Seed(1)
},
},
},
}
tranAssertEqual(t, tt.wantRes, gotRes)
-
})
}
}
cc: &ClientConn{
logger: NewTestLogger(),
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
bits.Set(accessMakeAlias)
- access := bits[:]
- return &access
+ return bits
}(),
},
Server: &Server{
},
},
t: NewTransaction(
- tranMakeFileAlias, &[]byte{0, 1},
- NewField(fieldFileName, []byte("testFile")),
- NewField(fieldFilePath, EncodeFilePath(strings.Join([]string{"foo"}, "/"))),
- NewField(fieldFileNewPath, EncodeFilePath(strings.Join([]string{"bar"}, "/"))),
+ TranMakeFileAlias, &[]byte{0, 1},
+ NewField(FieldFileName, []byte("testFile")),
+ NewField(FieldFilePath, EncodeFilePath(strings.Join([]string{"foo"}, "/"))),
+ NewField(FieldFileNewPath, EncodeFilePath(strings.Join([]string{"bar"}, "/"))),
),
},
wantRes: []Transaction{
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0xd1},
+ Type: []byte{0, 0},
ID: []byte{0x9a, 0xcb, 0x04, 0x42},
ErrorCode: []byte{0, 0, 0, 0},
Fields: []Field(nil),
cc: &ClientConn{
logger: NewTestLogger(),
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
bits.Set(accessMakeAlias)
- access := bits[:]
- return &access
+ return bits
}(),
},
Server: &Server{
},
},
t: NewTransaction(
- tranMakeFileAlias, &[]byte{0, 1},
- NewField(fieldFileName, []byte("testFile")),
- NewField(fieldFilePath, EncodeFilePath(strings.Join([]string{"foo"}, "/"))),
- NewField(fieldFileNewPath, EncodeFilePath(strings.Join([]string{"bar"}, "/"))),
+ TranMakeFileAlias, &[]byte{0, 1},
+ NewField(FieldFileName, []byte("testFile")),
+ NewField(FieldFilePath, EncodeFilePath(strings.Join([]string{"foo"}, "/"))),
+ NewField(FieldFileNewPath, EncodeFilePath(strings.Join([]string{"bar"}, "/"))),
),
},
wantRes: []Transaction{
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0x00},
+ Type: []byte{0, 0},
ID: []byte{0x9a, 0xcb, 0x04, 0x42},
ErrorCode: []byte{0, 0, 0, 1},
Fields: []Field{
- NewField(fieldError, []byte("Error creating alias")),
+ NewField(FieldError, []byte("Error creating alias")),
},
},
},
cc: &ClientConn{
logger: NewTestLogger(),
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
- access := bits[:]
- return &access
+ return bits
}(),
},
Server: &Server{
},
},
t: NewTransaction(
- tranMakeFileAlias, &[]byte{0, 1},
- NewField(fieldFileName, []byte("testFile")),
- NewField(fieldFilePath, []byte{
+ TranMakeFileAlias, &[]byte{0, 1},
+ NewField(FieldFileName, []byte("testFile")),
+ NewField(FieldFilePath, []byte{
0x00, 0x01,
0x00, 0x00,
0x03,
0x2e, 0x2e, 0x2e,
}),
- NewField(fieldFileNewPath, []byte{
+ NewField(FieldFileNewPath, []byte{
0x00, 0x01,
0x00, 0x00,
0x03,
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0x00},
+ Type: []byte{0, 0},
ID: []byte{0x9a, 0xcb, 0x04, 0x42},
ErrorCode: []byte{0, 0, 0, 1},
Fields: []Field{
- NewField(fieldError, []byte("You are not allowed to make aliases.")),
+ NewField(FieldError, []byte("You are not allowed to make aliases.")),
},
},
},
args: args{
cc: &ClientConn{
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
bits.Set(accessOpenUser)
- access := bits[:]
- return &access
+ return bits
}(),
},
Server: &Server{
Login: "guest",
Name: "Guest",
Password: "password",
- Access: &[]byte{1},
+ Access: accessBitmap{},
},
},
},
},
t: NewTransaction(
- tranGetUser, &[]byte{0, 1},
- NewField(fieldUserLogin, []byte("guest")),
+ TranGetUser, &[]byte{0, 1},
+ NewField(FieldUserLogin, []byte("guest")),
),
},
wantRes: []Transaction{
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0x01, 0x60},
+ Type: []byte{0, 0},
ID: []byte{0x9a, 0xcb, 0x04, 0x42},
ErrorCode: []byte{0, 0, 0, 0},
Fields: []Field{
- NewField(fieldUserName, []byte("Guest")),
- NewField(fieldUserLogin, negateString([]byte("guest"))),
- NewField(fieldUserPassword, []byte("password")),
- NewField(fieldUserAccess, []byte{1}),
+ NewField(FieldUserName, []byte("Guest")),
+ NewField(FieldUserLogin, encodeString([]byte("guest"))),
+ NewField(FieldUserPassword, []byte("password")),
+ NewField(FieldUserAccess, []byte{0, 0, 0, 0, 0, 0, 0, 0}),
},
},
},
args: args{
cc: &ClientConn{
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
- access := bits[:]
- return &access
+ return bits
}(),
},
Server: &Server{
},
},
t: NewTransaction(
- tranGetUser, &[]byte{0, 1},
- NewField(fieldUserLogin, []byte("nonExistentUser")),
+ TranGetUser, &[]byte{0, 1},
+ NewField(FieldUserLogin, []byte("nonExistentUser")),
),
},
wantRes: []Transaction{
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0x00},
+ Type: []byte{0, 0},
ID: []byte{0x9a, 0xcb, 0x04, 0x42},
ErrorCode: []byte{0, 0, 0, 1},
Fields: []Field{
- NewField(fieldError, []byte("You are not allowed to view accounts.")),
+ NewField(FieldError, []byte("You are not allowed to view accounts.")),
},
},
},
args: args{
cc: &ClientConn{
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
bits.Set(accessOpenUser)
- access := bits[:]
- return &access
+ return bits
}(),
},
Server: &Server{
},
},
t: NewTransaction(
- tranGetUser, &[]byte{0, 1},
- NewField(fieldUserLogin, []byte("nonExistentUser")),
+ TranGetUser, &[]byte{0, 1},
+ NewField(FieldUserLogin, []byte("nonExistentUser")),
),
},
wantRes: []Transaction{
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0x00},
+ Type: []byte{0, 0},
ID: []byte{0x9a, 0xcb, 0x04, 0x42},
ErrorCode: []byte{0, 0, 0, 1},
Fields: []Field{
- NewField(fieldError, []byte("Account does not exist.")),
+ NewField(FieldError, []byte("Account does not exist.")),
},
},
},
args: args{
cc: &ClientConn{
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
bits.Set(accessDeleteUser)
- access := bits[:]
- return &access
+ return bits
}(),
},
Server: &Server{
Login: "testuser",
Name: "Testy McTest",
Password: "password",
- Access: &[]byte{1},
+ Access: accessBitmap{},
},
},
FS: func() *MockFileStore {
},
},
t: NewTransaction(
- tranDeleteUser, &[]byte{0, 1},
- NewField(fieldUserLogin, negateString([]byte("testuser"))),
+ TranDeleteUser, &[]byte{0, 1},
+ NewField(FieldUserLogin, encodeString([]byte("testuser"))),
),
},
wantRes: []Transaction{
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0x1, 0x5f},
+ Type: []byte{0, 0},
ID: []byte{0x9a, 0xcb, 0x04, 0x42},
ErrorCode: []byte{0, 0, 0, 0},
Fields: []Field(nil),
args: args{
cc: &ClientConn{
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
- access := bits[:]
- return &access
+ return bits
}(),
},
Server: &Server{
},
},
t: NewTransaction(
- tranDeleteUser, &[]byte{0, 1},
- NewField(fieldUserLogin, negateString([]byte("testuser"))),
+ TranDeleteUser, &[]byte{0, 1},
+ NewField(FieldUserLogin, encodeString([]byte("testuser"))),
),
},
wantRes: []Transaction{
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0x00},
+ Type: []byte{0, 0},
ID: []byte{0x9a, 0xcb, 0x04, 0x42},
ErrorCode: []byte{0, 0, 0, 1},
Fields: []Field{
- NewField(fieldError, []byte("You are not allowed to delete accounts.")),
+ NewField(FieldError, []byte("You are not allowed to delete accounts.")),
},
},
},
args: args{
cc: &ClientConn{
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
bits.Set(accessNewsReadArt)
- access := bits[:]
- return &access
+ return bits
}(),
},
Server: &Server{
},
},
t: NewTransaction(
- tranGetMsgs, &[]byte{0, 1},
+ TranGetMsgs, &[]byte{0, 1},
),
},
wantRes: []Transaction{
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0x65},
+ Type: []byte{0, 0},
ID: []byte{0x9a, 0xcb, 0x04, 0x42},
ErrorCode: []byte{0, 0, 0, 0},
Fields: []Field{
- NewField(fieldData, []byte("TEST")),
+ NewField(FieldData, []byte("TEST")),
},
},
},
args: args{
cc: &ClientConn{
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
- access := bits[:]
- return &access
+ return bits
}(),
},
Server: &Server{
},
},
t: NewTransaction(
- tranGetMsgs, &[]byte{0, 1},
+ TranGetMsgs, &[]byte{0, 1},
),
},
wantRes: []Transaction{
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0x00},
+ Type: []byte{0, 0},
ID: []byte{0x9a, 0xcb, 0x04, 0x42},
ErrorCode: []byte{0, 0, 0, 1},
Fields: []Field{
- NewField(fieldError, []byte("You are not allowed to read news.")),
+ NewField(FieldError, []byte("You are not allowed to read news.")),
},
},
},
args: args{
cc: &ClientConn{
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
+ var bits accessBitmap
+ return bits
+ }(),
+ },
+ Server: &Server{
+ Accounts: map[string]*Account{},
+ },
+ },
+ t: NewTransaction(
+ TranNewUser, &[]byte{0, 1},
+ ),
+ },
+ wantRes: []Transaction{
+ {
+ Flags: 0x00,
+ IsReply: 0x01,
+ Type: []byte{0, 0},
+ ID: []byte{0x9a, 0xcb, 0x04, 0x42},
+ ErrorCode: []byte{0, 0, 0, 1},
+ Fields: []Field{
+ NewField(FieldError, []byte("You are not allowed to create new accounts.")),
+ },
+ },
+ },
+ wantErr: assert.NoError,
+ },
+ {
+ name: "when user attempts to create account with greater access",
+ args: args{
+ cc: &ClientConn{
+ Account: &Account{
+ Access: func() accessBitmap {
var bits accessBitmap
- access := bits[:]
- return &access
+ bits.Set(accessCreateUser)
+ return bits
}(),
},
Server: &Server{
},
},
t: NewTransaction(
- tranNewUser, &[]byte{0, 1},
+ TranNewUser, &[]byte{0, 1},
+ NewField(FieldUserLogin, []byte("userB")),
+ NewField(
+ FieldUserAccess,
+ func() []byte {
+ var bits accessBitmap
+ bits.Set(accessDisconUser)
+ return bits[:]
+ }(),
+ ),
),
},
wantRes: []Transaction{
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0x00},
+ Type: []byte{0, 0},
ID: []byte{0x9a, 0xcb, 0x04, 0x42},
ErrorCode: []byte{0, 0, 0, 1},
Fields: []Field{
- NewField(fieldError, []byte("You are not allowed to create new accounts.")),
+ NewField(FieldError, []byte("Cannot create account with more access than yourself.")),
},
},
},
args: args{
cc: &ClientConn{
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
- access := bits[:]
- return &access
+ return bits
}(),
},
Server: &Server{
},
},
t: NewTransaction(
- tranNewUser, &[]byte{0, 1},
+ TranNewUser, &[]byte{0, 1},
),
},
wantRes: []Transaction{
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0x00},
+ Type: []byte{0, 0},
ID: []byte{0x9a, 0xcb, 0x04, 0x42},
ErrorCode: []byte{0, 0, 0, 1},
Fields: []Field{
- NewField(fieldError, []byte("You are not allowed to view accounts.")),
+ NewField(FieldError, []byte("You are not allowed to view accounts.")),
},
},
},
args: args{
cc: &ClientConn{
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
bits.Set(accessOpenUser)
- access := bits[:]
- return &access
+ return bits
}(),
},
Server: &Server{
Name: "guest",
Login: "guest",
Password: "zz",
- Access: &[]byte{255, 255, 255, 255, 255, 255, 255, 255},
+ Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
},
},
},
},
t: NewTransaction(
- tranGetClientInfoText, &[]byte{0, 1},
- NewField(fieldUserID, []byte{0, 1}),
+ TranGetClientInfoText, &[]byte{0, 1},
+ NewField(FieldUserID, []byte{0, 1}),
),
},
wantRes: []Transaction{
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0x01, 0x2f},
+ Type: []byte{0, 0},
ID: []byte{0, 0, 0, 0},
ErrorCode: []byte{0, 0, 0, 0},
Fields: []Field{
- NewField(fieldData, []byte{
+ NewField(FieldData, []byte{
0x00, 0x04, 0x00, 0x66, 0x00, 0x05, 0x67, 0x75, 0x65, 0x73, 0x74, 0x00, 0x69, 0x00, 0x05, 0x98,
0x8a, 0x9a, 0x8c, 0x8b, 0x00, 0x6e, 0x00, 0x08, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
0x00, 0x6a, 0x00, 0x01, 0x78,
args: args{
cc: &ClientConn{
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
- access := bits[:]
- return &access
+ return bits
}(),
},
Server: &Server{},
},
- t: NewTransaction(tranDownloadFile, &[]byte{0, 1}),
+ t: NewTransaction(TranDownloadFile, &[]byte{0, 1}),
},
wantRes: []Transaction{
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0x00},
+ Type: []byte{0, 0},
ID: []byte{0x9a, 0xcb, 0x04, 0x42},
ErrorCode: []byte{0, 0, 0, 1},
Fields: []Field{
- NewField(fieldError, []byte("You are not allowed to download files.")),
+ NewField(FieldError, []byte("You are not allowed to download files.")),
},
},
},
FileDownload: {},
},
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
bits.Set(accessDownloadFile)
- access := bits[:]
- return &access
+ return bits
}(),
},
Server: &Server{
t: NewTransaction(
accessDownloadFile,
&[]byte{0, 1},
- NewField(fieldFileName, []byte("testfile.txt")),
- NewField(fieldFilePath, []byte{0x0, 0x00}),
+ NewField(FieldFileName, []byte("testfile.txt")),
+ NewField(FieldFilePath, []byte{0x0, 0x00}),
),
},
wantRes: []Transaction{
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0x2},
+ Type: []byte{0, 0},
ID: []byte{0x9a, 0xcb, 0x04, 0x42},
ErrorCode: []byte{0, 0, 0, 0},
Fields: []Field{
- NewField(fieldRefNum, []byte{0x52, 0xfd, 0xfc, 0x07}),
- NewField(fieldWaitingCount, []byte{0x00, 0x00}),
- NewField(fieldTransferSize, []byte{0x00, 0x00, 0x00, 0xa5}),
- NewField(fieldFileSize, []byte{0x00, 0x00, 0x00, 0x17}),
+ NewField(FieldRefNum, []byte{0x52, 0xfd, 0xfc, 0x07}),
+ NewField(FieldWaitingCount, []byte{0x00, 0x00}),
+ NewField(FieldTransferSize, []byte{0x00, 0x00, 0x00, 0xa5}),
+ NewField(FieldFileSize, []byte{0x00, 0x00, 0x00, 0x17}),
},
},
},
transfers: map[int]map[[4]byte]*FileTransfer{
FileDownload: {},
}, Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
bits.Set(accessDownloadFile)
- access := bits[:]
- return &access
+ return bits
}(),
},
Server: &Server{
t: NewTransaction(
accessDownloadFile,
&[]byte{0, 1},
- NewField(fieldFileName, []byte("testfile-1k")),
- NewField(fieldFilePath, []byte{0x00, 0x00}),
+ NewField(FieldFileName, []byte("testfile-1k")),
+ NewField(FieldFilePath, []byte{0x00, 0x00}),
NewField(
- fieldFileResumeData,
+ FieldFileResumeData,
func() []byte {
frd := FileResumeData{
Format: [4]byte{},
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0x2},
+ Type: []byte{0, 0},
ID: []byte{0x9a, 0xcb, 0x04, 0x42},
ErrorCode: []byte{0, 0, 0, 0},
Fields: []Field{
- NewField(fieldRefNum, []byte{0x52, 0xfd, 0xfc, 0x07}),
- NewField(fieldWaitingCount, []byte{0x00, 0x00}),
- NewField(fieldTransferSize, []byte{0x00, 0x00, 0x03, 0x8d}),
- NewField(fieldFileSize, []byte{0x00, 0x00, 0x03, 0x00}),
+ NewField(FieldRefNum, []byte{0x52, 0xfd, 0xfc, 0x07}),
+ NewField(FieldWaitingCount, []byte{0x00, 0x00}),
+ NewField(FieldTransferSize, []byte{0x00, 0x00, 0x03, 0x8d}),
+ NewField(FieldFileSize, []byte{0x00, 0x00, 0x03, 0x00}),
},
},
},
Logger: NewTestLogger(),
},
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
- access := bits[:]
- return &access
+ return bits
}(),
},
},
t: NewTransaction(
- tranUpdateUser,
+ TranUpdateUser,
&[]byte{0, 0},
- NewField(fieldData, []byte{
+ NewField(FieldData, []byte{
0x00, 0x04, // field count
- 0x00, 0x69, // fieldUserLogin = 105
+ 0x00, 0x69, // FieldUserLogin = 105
0x00, 0x03,
0x9d, 0x9d, 0x9d,
- 0x00, 0x6a, // fieldUserPassword = 106
+ 0x00, 0x6a, // FieldUserPassword = 106
0x00, 0x03,
0x9c, 0x9c, 0x9c,
- 0x00, 0x66, // fieldUserName = 102
+ 0x00, 0x66, // FieldUserName = 102
0x00, 0x03,
0x61, 0x61, 0x61,
- 0x00, 0x6e, // fieldUserAccess = 110
+ 0x00, 0x6e, // FieldUserAccess = 110
0x00, 0x08,
0x60, 0x70, 0x0c, 0x20, 0x03, 0x80, 0x00, 0x00,
}),
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0x00},
+ Type: []byte{0, 0},
ID: []byte{0x9a, 0xcb, 0x04, 0x42},
ErrorCode: []byte{0, 0, 0, 1},
Fields: []Field{
- NewField(fieldError, []byte("You are not allowed to create new accounts.")),
+ NewField(FieldError, []byte("You are not allowed to create new accounts.")),
},
},
},
},
},
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
- access := bits[:]
- return &access
+ return bits
}(),
},
},
t: NewTransaction(
- tranUpdateUser,
+ TranUpdateUser,
&[]byte{0, 0},
- NewField(fieldData, []byte{
+ NewField(FieldData, []byte{
0x00, 0x04, // field count
- 0x00, 0x69, // fieldUserLogin = 105
+ 0x00, 0x69, // FieldUserLogin = 105
0x00, 0x03,
0x9d, 0x9d, 0x9d,
- 0x00, 0x6a, // fieldUserPassword = 106
+ 0x00, 0x6a, // FieldUserPassword = 106
0x00, 0x03,
0x9c, 0x9c, 0x9c,
- 0x00, 0x66, // fieldUserName = 102
+ 0x00, 0x66, // FieldUserName = 102
0x00, 0x03,
0x61, 0x61, 0x61,
- 0x00, 0x6e, // fieldUserAccess = 110
+ 0x00, 0x6e, // FieldUserAccess = 110
0x00, 0x08,
0x60, 0x70, 0x0c, 0x20, 0x03, 0x80, 0x00, 0x00,
}),
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0x00},
+ Type: []byte{0, 0},
ID: []byte{0x9a, 0xcb, 0x04, 0x42},
ErrorCode: []byte{0, 0, 0, 1},
Fields: []Field{
- NewField(fieldError, []byte("You are not allowed to modify accounts.")),
+ NewField(FieldError, []byte("You are not allowed to modify accounts.")),
},
},
},
},
},
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
- access := bits[:]
- return &access
+ return bits
}(),
},
},
t: NewTransaction(
- tranUpdateUser,
+ TranUpdateUser,
&[]byte{0, 0},
- NewField(fieldData, []byte{
+ NewField(FieldData, []byte{
0x00, 0x01,
0x00, 0x65,
0x00, 0x03,
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0x00},
+ Type: []byte{0, 0},
ID: []byte{0x9a, 0xcb, 0x04, 0x42},
ErrorCode: []byte{0, 0, 0, 1},
Fields: []Field{
- NewField(fieldError, []byte("You are not allowed to delete accounts.")),
+ NewField(FieldError, []byte("You are not allowed to delete accounts.")),
},
},
},
args: args{
cc: &ClientConn{
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
- access := bits[:]
- return &access
+ return bits
}(),
},
},
t: NewTransaction(
- tranDelNewsArt,
+ TranDelNewsArt,
&[]byte{0, 0},
),
},
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0x00},
+ Type: []byte{0, 0},
ID: []byte{0x9a, 0xcb, 0x04, 0x42},
ErrorCode: []byte{0, 0, 0, 1},
Fields: []Field{
- NewField(fieldError, []byte("You are not allowed to delete news articles.")),
+ NewField(FieldError, []byte("You are not allowed to delete news articles.")),
},
},
},
args: args{
cc: &ClientConn{
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
- access := bits[:]
- return &access
+ return bits
}(),
},
},
t: NewTransaction(
- tranDelNewsArt,
+ TranDelNewsArt,
&[]byte{0, 0},
),
},
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0x00},
+ Type: []byte{0, 0},
ID: []byte{0x9a, 0xcb, 0x04, 0x42},
ErrorCode: []byte{0, 0, 0, 1},
Fields: []Field{
- NewField(fieldError, []byte("You are not allowed to disconnect users.")),
+ NewField(FieldError, []byte("You are not allowed to disconnect users.")),
},
},
},
uint16(1): {
Account: &Account{
Login: "unnamed",
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
bits.Set(accessCannotBeDiscon)
- access := bits[:]
- return &access
+ return bits
}(),
},
},
},
},
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
bits.Set(accessDisconUser)
- access := bits[:]
- return &access
+ return bits
}(),
},
},
t: NewTransaction(
- tranDelNewsArt,
+ TranDelNewsArt,
&[]byte{0, 0},
- NewField(fieldUserID, []byte{0, 1}),
+ NewField(FieldUserID, []byte{0, 1}),
),
},
wantRes: []Transaction{
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0x00},
+ Type: []byte{0, 0},
ID: []byte{0x9a, 0xcb, 0x04, 0x42},
ErrorCode: []byte{0, 0, 0, 1},
Fields: []Field{
- NewField(fieldError, []byte("unnamed is not allowed to be disconnected.")),
+ NewField(FieldError, []byte("unnamed is not allowed to be disconnected.")),
},
},
},
wantRes []Transaction
wantErr assert.ErrorAssertionFunc
}{
+ {
+ name: "without required permission",
+ args: args{
+ cc: &ClientConn{
+ Account: &Account{
+ Access: func() accessBitmap {
+ var bits accessBitmap
+ return bits
+ }(),
+ },
+ },
+ t: NewTransaction(
+ TranDelNewsArt,
+ &[]byte{0, 0},
+ ),
+ },
+ wantRes: []Transaction{
+ {
+ Flags: 0x00,
+ IsReply: 0x01,
+ Type: []byte{0, 0},
+ ID: []byte{0, 0, 0, 0},
+ ErrorCode: []byte{0, 0, 0, 1},
+ Fields: []Field{
+ NewField(FieldError, []byte("You are not allowed to send private messages.")),
+ },
+ },
+ },
+ wantErr: assert.Error,
+ },
{
name: "when client 1 sends a message to client 2",
args: args{
cc: &ClientConn{
+ Account: &Account{
+ Access: func() accessBitmap {
+ var bits accessBitmap
+ bits.Set(accessSendPrivMsg)
+ return bits
+ }(),
+ },
ID: &[]byte{0, 1},
UserName: []byte("User1"),
Server: &Server{
Clients: map[uint16]*ClientConn{
uint16(2): {
AutoReply: []byte(nil),
+ Flags: []byte{0, 0},
},
},
},
},
t: NewTransaction(
- tranSendInstantMsg,
+ TranSendInstantMsg,
&[]byte{0, 1},
- NewField(fieldData, []byte("hai")),
- NewField(fieldUserID, []byte{0, 2}),
+ NewField(FieldData, []byte("hai")),
+ NewField(FieldUserID, []byte{0, 2}),
),
},
wantRes: []Transaction{
*NewTransaction(
- tranServerMsg,
+ TranServerMsg,
&[]byte{0, 2},
- NewField(fieldData, []byte("hai")),
- NewField(fieldUserName, []byte("User1")),
- NewField(fieldUserID, []byte{0, 1}),
- NewField(fieldOptions, []byte{0, 1}),
+ NewField(FieldData, []byte("hai")),
+ NewField(FieldUserName, []byte("User1")),
+ NewField(FieldUserID, []byte{0, 1}),
+ NewField(FieldOptions, []byte{0, 1}),
),
{
clientID: &[]byte{0, 1},
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0x0, 0x6c},
+ Type: []byte{0, 0},
ID: []byte{0, 0, 0, 0},
ErrorCode: []byte{0, 0, 0, 0},
Fields: []Field(nil),
name: "when client 2 has autoreply enabled",
args: args{
cc: &ClientConn{
+ Account: &Account{
+ Access: func() accessBitmap {
+ var bits accessBitmap
+ bits.Set(accessSendPrivMsg)
+ return bits
+ }(),
+ },
ID: &[]byte{0, 1},
UserName: []byte("User1"),
Server: &Server{
Clients: map[uint16]*ClientConn{
uint16(2): {
+ Flags: []byte{0, 0},
ID: &[]byte{0, 2},
UserName: []byte("User2"),
AutoReply: []byte("autohai"),
},
},
t: NewTransaction(
- tranSendInstantMsg,
+ TranSendInstantMsg,
&[]byte{0, 1},
- NewField(fieldData, []byte("hai")),
- NewField(fieldUserID, []byte{0, 2}),
+ NewField(FieldData, []byte("hai")),
+ NewField(FieldUserID, []byte{0, 2}),
),
},
wantRes: []Transaction{
*NewTransaction(
- tranServerMsg,
+ TranServerMsg,
&[]byte{0, 2},
- NewField(fieldData, []byte("hai")),
- NewField(fieldUserName, []byte("User1")),
- NewField(fieldUserID, []byte{0, 1}),
- NewField(fieldOptions, []byte{0, 1}),
+ NewField(FieldData, []byte("hai")),
+ NewField(FieldUserName, []byte("User1")),
+ NewField(FieldUserID, []byte{0, 1}),
+ NewField(FieldOptions, []byte{0, 1}),
+ ),
+ *NewTransaction(
+ TranServerMsg,
+ &[]byte{0, 1},
+ NewField(FieldData, []byte("autohai")),
+ NewField(FieldUserName, []byte("User2")),
+ NewField(FieldUserID, []byte{0, 2}),
+ NewField(FieldOptions, []byte{0, 1}),
+ ),
+ {
+ clientID: &[]byte{0, 1},
+ Flags: 0x00,
+ IsReply: 0x01,
+ Type: []byte{0, 0},
+ ID: []byte{0, 0, 0, 0},
+ ErrorCode: []byte{0, 0, 0, 0},
+ Fields: []Field(nil),
+ },
+ },
+ wantErr: assert.NoError,
+ },
+ {
+ name: "when client 2 has refuse private messages enabled",
+ args: args{
+ cc: &ClientConn{
+ Account: &Account{
+ Access: func() accessBitmap {
+ var bits accessBitmap
+ bits.Set(accessSendPrivMsg)
+ return bits
+ }(),
+ },
+ ID: &[]byte{0, 1},
+ UserName: []byte("User1"),
+ Server: &Server{
+ Clients: map[uint16]*ClientConn{
+ uint16(2): {
+ Flags: []byte{255, 255},
+ ID: &[]byte{0, 2},
+ UserName: []byte("User2"),
+ },
+ },
+ },
+ },
+ t: NewTransaction(
+ TranSendInstantMsg,
+ &[]byte{0, 1},
+ NewField(FieldData, []byte("hai")),
+ NewField(FieldUserID, []byte{0, 2}),
),
+ },
+ wantRes: []Transaction{
*NewTransaction(
- tranServerMsg,
+ TranServerMsg,
&[]byte{0, 1},
- NewField(fieldData, []byte("autohai")),
- NewField(fieldUserName, []byte("User2")),
- NewField(fieldUserID, []byte{0, 2}),
- NewField(fieldOptions, []byte{0, 1}),
+ NewField(FieldData, []byte("User2 does not accept private messages.")),
+ NewField(FieldUserName, []byte("User2")),
+ NewField(FieldUserID, []byte{0, 2}),
+ NewField(FieldOptions, []byte{0, 2}),
),
{
clientID: &[]byte{0, 1},
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0x0, 0x6c},
+ Type: []byte{0, 0},
ID: []byte{0, 0, 0, 0},
ErrorCode: []byte{0, 0, 0, 0},
Fields: []Field(nil),
args: args{
cc: &ClientConn{
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
- access := bits[:]
- return &access
+ return bits
}(),
},
Server: &Server{
},
},
t: NewTransaction(
- tranDeleteFile, &[]byte{0, 1},
- NewField(fieldFileName, []byte("testfile")),
- NewField(fieldFilePath, []byte{
+ TranDeleteFile, &[]byte{0, 1},
+ NewField(FieldFileName, []byte("testfile")),
+ NewField(FieldFilePath, []byte{
0x00, 0x01,
0x00, 0x00,
0x03,
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0x00},
+ Type: []byte{0, 0},
ID: []byte{0x9a, 0xcb, 0x04, 0x42},
ErrorCode: []byte{0, 0, 0, 1},
Fields: []Field{
- NewField(fieldError, []byte("You are not allowed to delete files.")),
+ NewField(FieldError, []byte("You are not allowed to delete files.")),
},
},
},
args: args{
cc: &ClientConn{
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
bits.Set(accessDeleteFile)
- access := bits[:]
- return &access
+ return bits
}(),
},
Server: &Server{
},
},
t: NewTransaction(
- tranDeleteFile, &[]byte{0, 1},
- NewField(fieldFileName, []byte("testfile")),
- NewField(fieldFilePath, []byte{
+ TranDeleteFile, &[]byte{0, 1},
+ NewField(FieldFileName, []byte("testfile")),
+ NewField(FieldFilePath, []byte{
0x00, 0x01,
0x00, 0x00,
0x03,
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0x0, 0xcc},
+ Type: []byte{0, 0},
ID: []byte{0x0, 0x0, 0x0, 0x0},
ErrorCode: []byte{0, 0, 0, 0},
Fields: []Field(nil),
wantErr assert.ErrorAssertionFunc
}{
{
- name: "when fieldFilePath is a drop box, but user does not have accessViewDropBoxes ",
+ name: "when FieldFilePath is a drop box, but user does not have accessViewDropBoxes ",
args: args{
cc: &ClientConn{
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
- access := bits[:]
- return &access
+ return bits
}(),
},
Server: &Server{
},
},
t: NewTransaction(
- tranGetFileNameList, &[]byte{0, 1},
- NewField(fieldFilePath, []byte{
+ TranGetFileNameList, &[]byte{0, 1},
+ NewField(FieldFilePath, []byte{
0x00, 0x01,
0x00, 0x00,
0x08,
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0x00},
+ Type: []byte{0, 0},
ID: []byte{0, 0, 0, 0},
ErrorCode: []byte{0, 0, 0, 1},
Fields: []Field{
- NewField(fieldError, []byte("You are not allowed to view drop boxes.")),
+ NewField(FieldError, []byte("You are not allowed to view drop boxes.")),
},
},
},
},
},
t: NewTransaction(
- tranGetFileNameList, &[]byte{0, 1},
- NewField(fieldFilePath, []byte{
+ TranGetFileNameList, &[]byte{0, 1},
+ NewField(FieldFilePath, []byte{
0x00, 0x00,
0x00, 0x00,
}),
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0xc8},
+ Type: []byte{0, 0},
ID: []byte{0, 0, 0, 0},
ErrorCode: []byte{0, 0, 0, 0},
Fields: []Field{
NewField(
- fieldFileNameWithInfo,
+ FieldFileNameWithInfo,
func() []byte {
fnwi := FileNameWithInfo{
fileNameWithInfoHeader: fileNameWithInfoHeader{
NameScript: [2]byte{},
NameSize: [2]byte{0, 0x0b},
},
- name: []byte("testfile-1k"),
+ Name: []byte("testfile-1k"),
}
- b, _ := fnwi.MarshalBinary()
+ b, _ := io.ReadAll(&fnwi)
return b
}(),
),
args: args{
cc: &ClientConn{
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
- access := bits[:]
- return &access
+ return bits
}(),
},
Server: &Server{
},
},
t: NewTransaction(
- tranGetClientInfoText, &[]byte{0, 1},
- NewField(fieldUserID, []byte{0, 1}),
+ TranGetClientInfoText, &[]byte{0, 1},
+ NewField(FieldUserID, []byte{0, 1}),
),
},
wantRes: []Transaction{
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0x00},
+ Type: []byte{0, 0},
ID: []byte{0, 0, 0, 0},
ErrorCode: []byte{0, 0, 0, 1},
Fields: []Field{
- NewField(fieldError, []byte("You are not allowed to get client info.")),
+ NewField(FieldError, []byte("You are not allowed to get client info.")),
},
},
},
UserName: []byte("Testy McTest"),
RemoteAddr: "1.2.3.4:12345",
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
bits.Set(accessGetClientInfo)
- access := bits[:]
- return &access
+ return bits
}(),
Name: "test",
Login: "test",
UserName: []byte("Testy McTest"),
RemoteAddr: "1.2.3.4:12345",
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
bits.Set(accessGetClientInfo)
- access := bits[:]
- return &access
+ return bits
}(),
Name: "test",
Login: "test",
},
},
t: NewTransaction(
- tranGetClientInfoText, &[]byte{0, 1},
- NewField(fieldUserID, []byte{0, 1}),
+ TranGetClientInfoText, &[]byte{0, 1},
+ NewField(FieldUserID, []byte{0, 1}),
),
},
wantRes: []Transaction{
{
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0x1, 0x2f},
+ Type: []byte{0, 0},
ID: []byte{0, 0, 0, 0},
ErrorCode: []byte{0, 0, 0, 0},
Fields: []Field{
- NewField(fieldData, []byte(
- strings.Replace(`Nickname: Testy McTest
+ NewField(FieldData, []byte(
+ strings.ReplaceAll(`Nickname: Testy McTest
Name: test
Account: test
Address: 1.2.3.4:12345
None.
-`, "\n", "\r", -1)),
+`, "\n", "\r")),
),
- NewField(fieldUserName, []byte("Testy McTest")),
+ NewField(FieldUserName, []byte("Testy McTest")),
},
},
},
args: args{
cc: &ClientConn{
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
bits.Set(accessDisconUser)
bits.Set(accessAnyName)
- access := bits[:]
- return &access
+ return bits
}()},
Icon: []byte{0, 1},
Flags: []byte{0, 1},
},
},
t: NewTransaction(
- tranAgreed, nil,
- NewField(fieldUserName, []byte("username")),
- NewField(fieldUserIconID, []byte{0, 1}),
- NewField(fieldOptions, []byte{0, 0}),
+ TranAgreed, nil,
+ NewField(FieldUserName, []byte("username")),
+ NewField(FieldUserIconID, []byte{0, 1}),
+ NewField(FieldOptions, []byte{0, 0}),
),
},
wantRes: []Transaction{
ID: []byte{0, 0, 0, 0},
ErrorCode: []byte{0, 0, 0, 0},
Fields: []Field{
- NewField(fieldBannerType, []byte("JPEG")),
+ NewField(FieldBannerType, []byte("JPEG")),
},
},
{
clientID: &[]byte{0, 1},
Flags: 0x00,
IsReply: 0x01,
- Type: []byte{0, 0x79},
+ Type: []byte{0, 0},
ID: []byte{0, 0, 0, 0},
ErrorCode: []byte{0, 0, 0, 0},
Fields: []Field{},
args: args{
cc: &ClientConn{
Account: &Account{
- Access: func() *[]byte {
+ Access: func() accessBitmap {
var bits accessBitmap
- access := bits[:]
- return &access
+ return bits
}(),
},
ID: &[]byte{0, 1},
},
},
t: NewTransaction(
- tranSetClientUserInfo, nil,
- NewField(fieldUserIconID, []byte{0, 1}),
- NewField(fieldUserName, []byte("NOPE")),
+ TranSetClientUserInfo, nil,
+ NewField(FieldUserIconID, []byte{0, 1}),
+ NewField(FieldUserName, []byte("NOPE")),
),
},
wantRes: []Transaction{
ID: []byte{0, 0, 0, 0},
ErrorCode: []byte{0, 0, 0, 0},
Fields: []Field{
- NewField(fieldUserID, []byte{0, 1}),
- NewField(fieldUserIconID, []byte{0, 1}),
- NewField(fieldUserFlags, []byte{0, 1}),
- NewField(fieldUserName, []byte("Guest"))},
+ NewField(FieldUserID, []byte{0, 1}),
+ NewField(FieldUserIconID, []byte{0, 1}),
+ NewField(FieldUserFlags, []byte{0, 1}),
+ NewField(FieldUserName, []byte("Guest"))},
},
},
wantErr: assert.NoError,
})
}
}
+
+func TestHandleDelNewsItem(t *testing.T) {
+ type args struct {
+ cc *ClientConn
+ t *Transaction
+ }
+ tests := []struct {
+ name string
+ args args
+ wantRes []Transaction
+ wantErr assert.ErrorAssertionFunc
+ }{
+ {
+ name: "when user does not have permission to delete a news category",
+ args: args{
+ cc: &ClientConn{
+ Account: &Account{
+ Access: accessBitmap{},
+ },
+ ID: &[]byte{0, 1},
+ Server: &Server{
+ ThreadedNews: &ThreadedNews{Categories: map[string]NewsCategoryListData15{
+ "test": {
+ Type: [2]byte{0, 3},
+ Name: "zz",
+ },
+ }},
+ },
+ },
+ t: NewTransaction(
+ TranDelNewsItem, nil,
+ NewField(FieldNewsPath,
+ []byte{
+ 0, 1,
+ 0, 0,
+ 4,
+ 0x74, 0x65, 0x73, 0x74,
+ },
+ ),
+ ),
+ },
+ wantRes: []Transaction{
+ {
+ clientID: &[]byte{0, 1},
+ Flags: 0x00,
+ IsReply: 0x01,
+ Type: []byte{0, 0},
+ ID: []byte{0, 0, 0, 0},
+ ErrorCode: []byte{0, 0, 0, 1},
+ Fields: []Field{
+ NewField(FieldError, []byte("You are not allowed to delete news categories.")),
+ },
+ },
+ },
+ wantErr: assert.NoError,
+ },
+ {
+ name: "when user does not have permission to delete a news folder",
+ args: args{
+ cc: &ClientConn{
+ Account: &Account{
+ Access: accessBitmap{},
+ },
+ ID: &[]byte{0, 1},
+ Server: &Server{
+ ThreadedNews: &ThreadedNews{Categories: map[string]NewsCategoryListData15{
+ "testcat": {
+ Type: [2]byte{0, 2},
+ Name: "test",
+ },
+ }},
+ },
+ },
+ t: NewTransaction(
+ TranDelNewsItem, nil,
+ NewField(FieldNewsPath,
+ []byte{
+ 0, 1,
+ 0, 0,
+ 4,
+ 0x74, 0x65, 0x73, 0x74,
+ },
+ ),
+ ),
+ },
+ wantRes: []Transaction{
+ {
+ clientID: &[]byte{0, 1},
+ Flags: 0x00,
+ IsReply: 0x01,
+ Type: []byte{0, 0},
+ ID: []byte{0, 0, 0, 0},
+ ErrorCode: []byte{0, 0, 0, 1},
+ Fields: []Field{
+ NewField(FieldError, []byte("You are not allowed to delete news folders.")),
+ },
+ },
+ },
+ wantErr: assert.NoError,
+ },
+ {
+ name: "when user deletes a news folder",
+ args: args{
+ cc: &ClientConn{
+ Account: &Account{
+ Access: func() accessBitmap {
+ var bits accessBitmap
+ bits.Set(accessNewsDeleteFldr)
+ return bits
+ }(),
+ },
+ ID: &[]byte{0, 1},
+ Server: &Server{
+ ConfigDir: "/fakeConfigRoot",
+ FS: func() *MockFileStore {
+ mfs := &MockFileStore{}
+ mfs.On("WriteFile", "/fakeConfigRoot/ThreadedNews.yaml", mock.Anything, mock.Anything).Return(nil, os.ErrNotExist)
+ return mfs
+ }(),
+ ThreadedNews: &ThreadedNews{Categories: map[string]NewsCategoryListData15{
+ "testcat": {
+ Type: [2]byte{0, 2},
+ Name: "test",
+ },
+ }},
+ },
+ },
+ t: NewTransaction(
+ TranDelNewsItem, nil,
+ NewField(FieldNewsPath,
+ []byte{
+ 0, 1,
+ 0, 0,
+ 4,
+ 0x74, 0x65, 0x73, 0x74,
+ },
+ ),
+ ),
+ },
+ wantRes: []Transaction{
+ {
+ clientID: &[]byte{0, 1},
+ Flags: 0x00,
+ IsReply: 0x01,
+ Type: []byte{0, 0},
+ ID: []byte{0, 0, 0, 0},
+ ErrorCode: []byte{0, 0, 0, 0},
+ Fields: []Field{},
+ },
+ },
+ wantErr: assert.NoError,
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ gotRes, err := HandleDelNewsItem(tt.args.cc, tt.args.t)
+ if !tt.wantErr(t, err, fmt.Sprintf("HandleDelNewsItem(%v, %v)", tt.args.cc, tt.args.t)) {
+ return
+ }
+ tranAssertEqual(t, tt.wantRes, gotRes)
+ })
+ }
+}
+
+func TestHandleTranOldPostNews(t *testing.T) {
+ type args struct {
+ cc *ClientConn
+ t *Transaction
+ }
+ tests := []struct {
+ name string
+ args args
+ wantRes []Transaction
+ wantErr assert.ErrorAssertionFunc
+ }{
+ {
+ name: "when user does not have required permission",
+ args: args{
+ cc: &ClientConn{
+ Account: &Account{
+ Access: func() accessBitmap {
+ var bits accessBitmap
+ return bits
+ }(),
+ },
+ },
+ t: NewTransaction(
+ TranOldPostNews, &[]byte{0, 1},
+ NewField(FieldData, []byte("hai")),
+ ),
+ },
+ wantRes: []Transaction{
+ {
+ Flags: 0x00,
+ IsReply: 0x01,
+ Type: []byte{0, 0},
+ ID: []byte{0, 0, 0, 0},
+ ErrorCode: []byte{0, 0, 0, 1},
+ Fields: []Field{
+ NewField(FieldError, []byte("You are not allowed to post news.")),
+ },
+ },
+ },
+ wantErr: assert.NoError,
+ },
+ {
+ name: "when user posts news update",
+ args: args{
+ cc: &ClientConn{
+ Account: &Account{
+ Access: func() accessBitmap {
+ var bits accessBitmap
+ bits.Set(accessNewsPostArt)
+ return bits
+ }(),
+ },
+ Server: &Server{
+ FS: func() *MockFileStore {
+ mfs := &MockFileStore{}
+ mfs.On("WriteFile", "/fakeConfigRoot/MessageBoard.txt", mock.Anything, mock.Anything).Return(nil, os.ErrNotExist)
+ return mfs
+ }(),
+ ConfigDir: "/fakeConfigRoot",
+ Config: &Config{},
+ },
+ },
+ t: NewTransaction(
+ TranOldPostNews, &[]byte{0, 1},
+ NewField(FieldData, []byte("hai")),
+ ),
+ },
+ wantRes: []Transaction{
+ {
+ Flags: 0x00,
+ IsReply: 0x01,
+ Type: []byte{0, 0},
+ ID: []byte{0, 0, 0, 0},
+ ErrorCode: []byte{0, 0, 0, 0},
+ },
+ },
+ wantErr: assert.NoError,
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ gotRes, err := HandleTranOldPostNews(tt.args.cc, tt.args.t)
+ if !tt.wantErr(t, err, fmt.Sprintf("HandleTranOldPostNews(%v, %v)", tt.args.cc, tt.args.t)) {
+ return
+ }
+
+ tranAssertEqual(t, tt.wantRes, gotRes)
+ })
+ }
+}
+
+func TestHandleInviteNewChat(t *testing.T) {
+ type args struct {
+ cc *ClientConn
+ t *Transaction
+ }
+ tests := []struct {
+ name string
+ args args
+ wantRes []Transaction
+ wantErr assert.ErrorAssertionFunc
+ }{
+ {
+ name: "when user does not have required permission",
+ args: args{
+ cc: &ClientConn{
+ Account: &Account{
+ Access: func() accessBitmap {
+ var bits accessBitmap
+ return bits
+ }(),
+ },
+ },
+ t: NewTransaction(TranInviteNewChat, &[]byte{0, 1}),
+ },
+ wantRes: []Transaction{
+ {
+ Flags: 0x00,
+ IsReply: 0x01,
+ Type: []byte{0, 0},
+ ID: []byte{0, 0, 0, 0},
+ ErrorCode: []byte{0, 0, 0, 1},
+ Fields: []Field{
+ NewField(FieldError, []byte("You are not allowed to request private chat.")),
+ },
+ },
+ },
+ wantErr: assert.NoError,
+ },
+ {
+ name: "when userA invites userB to new private chat",
+ args: args{
+ cc: &ClientConn{
+ ID: &[]byte{0, 1},
+ Account: &Account{
+ Access: func() accessBitmap {
+ var bits accessBitmap
+ bits.Set(accessOpenChat)
+ return bits
+ }(),
+ },
+ UserName: []byte("UserA"),
+ Icon: []byte{0, 1},
+ Flags: []byte{0, 0},
+ Server: &Server{
+ Clients: map[uint16]*ClientConn{
+ uint16(2): {
+ ID: &[]byte{0, 2},
+ UserName: []byte("UserB"),
+ Flags: []byte{0, 0},
+ },
+ },
+ PrivateChats: make(map[uint32]*PrivateChat),
+ },
+ },
+ t: NewTransaction(
+ TranInviteNewChat, &[]byte{0, 1},
+ NewField(FieldUserID, []byte{0, 2}),
+ ),
+ },
+ wantRes: []Transaction{
+ {
+ clientID: &[]byte{0, 2},
+ Flags: 0x00,
+ IsReply: 0x00,
+ Type: []byte{0, 0x71},
+ ID: []byte{0, 0, 0, 0},
+ ErrorCode: []byte{0, 0, 0, 0},
+ Fields: []Field{
+ NewField(FieldChatID, []byte{0x52, 0xfd, 0xfc, 0x07}),
+ NewField(FieldUserName, []byte("UserA")),
+ NewField(FieldUserID, []byte{0, 1}),
+ },
+ },
+
+ {
+ clientID: &[]byte{0, 1},
+ Flags: 0x00,
+ IsReply: 0x01,
+ Type: []byte{0, 0},
+ ID: []byte{0, 0, 0, 0},
+ ErrorCode: []byte{0, 0, 0, 0},
+ Fields: []Field{
+ NewField(FieldChatID, []byte{0x52, 0xfd, 0xfc, 0x07}),
+ NewField(FieldUserName, []byte("UserA")),
+ NewField(FieldUserID, []byte{0, 1}),
+ NewField(FieldUserIconID, []byte{0, 1}),
+ NewField(FieldUserFlags, []byte{0, 0}),
+ },
+ },
+ },
+ wantErr: assert.NoError,
+ },
+ {
+ name: "when userA invites userB to new private chat, but UserB has refuse private chat enabled",
+ args: args{
+ cc: &ClientConn{
+ ID: &[]byte{0, 1},
+ Account: &Account{
+ Access: func() accessBitmap {
+ var bits accessBitmap
+ bits.Set(accessOpenChat)
+ return bits
+ }(),
+ },
+ UserName: []byte("UserA"),
+ Icon: []byte{0, 1},
+ Flags: []byte{0, 0},
+ Server: &Server{
+ Clients: map[uint16]*ClientConn{
+ uint16(2): {
+ ID: &[]byte{0, 2},
+ UserName: []byte("UserB"),
+ Flags: []byte{255, 255},
+ },
+ },
+ PrivateChats: make(map[uint32]*PrivateChat),
+ },
+ },
+ t: NewTransaction(
+ TranInviteNewChat, &[]byte{0, 1},
+ NewField(FieldUserID, []byte{0, 2}),
+ ),
+ },
+ wantRes: []Transaction{
+ {
+ clientID: &[]byte{0, 1},
+ Flags: 0x00,
+ IsReply: 0x00,
+ Type: []byte{0, 0x68},
+ ID: []byte{0, 0, 0, 0},
+ ErrorCode: []byte{0, 0, 0, 0},
+ Fields: []Field{
+ NewField(FieldData, []byte("UserB does not accept private chats.")),
+ NewField(FieldUserName, []byte("UserB")),
+ NewField(FieldUserID, []byte{0, 2}),
+ NewField(FieldOptions, []byte{0, 2}),
+ },
+ },
+ {
+ clientID: &[]byte{0, 1},
+ Flags: 0x00,
+ IsReply: 0x01,
+ Type: []byte{0, 0},
+ ID: []byte{0, 0, 0, 0},
+ ErrorCode: []byte{0, 0, 0, 0},
+ Fields: []Field{
+ NewField(FieldChatID, []byte{0x52, 0xfd, 0xfc, 0x07}),
+ NewField(FieldUserName, []byte("UserA")),
+ NewField(FieldUserID, []byte{0, 1}),
+ NewField(FieldUserIconID, []byte{0, 1}),
+ NewField(FieldUserFlags, []byte{0, 0}),
+ },
+ },
+ },
+ wantErr: assert.NoError,
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ rand.Seed(1)
+ gotRes, err := HandleInviteNewChat(tt.args.cc, tt.args.t)
+ if !tt.wantErr(t, err, fmt.Sprintf("HandleInviteNewChat(%v, %v)", tt.args.cc, tt.args.t)) {
+ return
+ }
+ tranAssertEqual(t, tt.wantRes, gotRes)
+ })
+ }
+}
+
+func TestHandleGetNewsArtData(t *testing.T) {
+ type args struct {
+ cc *ClientConn
+ t *Transaction
+ }
+ tests := []struct {
+ name string
+ args args
+ wantRes []Transaction
+ wantErr assert.ErrorAssertionFunc
+ }{
+ {
+ name: "when user does not have required permission",
+ args: args{
+ cc: &ClientConn{
+ Account: &Account{
+ Access: func() accessBitmap {
+ var bits accessBitmap
+ return bits
+ }(),
+ },
+ Server: &Server{
+ Accounts: map[string]*Account{},
+ },
+ },
+ t: NewTransaction(
+ TranGetNewsArtData, &[]byte{0, 1},
+ ),
+ },
+ wantRes: []Transaction{
+ {
+ Flags: 0x00,
+ IsReply: 0x01,
+ Type: []byte{0, 0},
+ ID: []byte{0x9a, 0xcb, 0x04, 0x42},
+ ErrorCode: []byte{0, 0, 0, 1},
+ Fields: []Field{
+ NewField(FieldError, []byte("You are not allowed to read news.")),
+ },
+ },
+ },
+ wantErr: assert.NoError,
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ gotRes, err := HandleGetNewsArtData(tt.args.cc, tt.args.t)
+ if !tt.wantErr(t, err, fmt.Sprintf("HandleGetNewsArtData(%v, %v)", tt.args.cc, tt.args.t)) {
+ return
+ }
+ tranAssertEqual(t, tt.wantRes, gotRes)
+ })
+ }
+}
+
+func TestHandleGetNewsArtNameList(t *testing.T) {
+ type args struct {
+ cc *ClientConn
+ t *Transaction
+ }
+ tests := []struct {
+ name string
+ args args
+ wantRes []Transaction
+ wantErr assert.ErrorAssertionFunc
+ }{
+ {
+ name: "when user does not have required permission",
+ args: args{
+ cc: &ClientConn{
+ Account: &Account{
+ Access: func() accessBitmap {
+ var bits accessBitmap
+ return bits
+ }(),
+ },
+ Server: &Server{
+ Accounts: map[string]*Account{},
+ },
+ },
+ t: NewTransaction(
+ TranGetNewsArtNameList, &[]byte{0, 1},
+ ),
+ },
+ wantRes: []Transaction{
+ {
+ Flags: 0x00,
+ IsReply: 0x01,
+ Type: []byte{0, 0},
+ ErrorCode: []byte{0, 0, 0, 1},
+ Fields: []Field{
+ NewField(FieldError, []byte("You are not allowed to read news.")),
+ },
+ },
+ },
+ wantErr: assert.NoError,
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ gotRes, err := HandleGetNewsArtNameList(tt.args.cc, tt.args.t)
+ if !tt.wantErr(t, err, fmt.Sprintf("HandleGetNewsArtNameList(%v, %v)", tt.args.cc, tt.args.t)) {
+ return
+ }
+ tranAssertEqual(t, tt.wantRes, gotRes)
+ })
+ }
+}
+
+func TestHandleNewNewsFldr(t *testing.T) {
+ type args struct {
+ cc *ClientConn
+ t *Transaction
+ }
+ tests := []struct {
+ name string
+ args args
+ wantRes []Transaction
+ wantErr assert.ErrorAssertionFunc
+ }{
+ {
+ name: "when user does not have required permission",
+ args: args{
+ cc: &ClientConn{
+ Account: &Account{
+ Access: func() accessBitmap {
+ var bits accessBitmap
+ return bits
+ }(),
+ },
+ Server: &Server{
+ Accounts: map[string]*Account{},
+ },
+ },
+ t: NewTransaction(
+ TranGetNewsArtNameList, &[]byte{0, 1},
+ ),
+ },
+ wantRes: []Transaction{
+ {
+ Flags: 0x00,
+ IsReply: 0x01,
+ Type: []byte{0, 0},
+ ErrorCode: []byte{0, 0, 0, 1},
+ Fields: []Field{
+ NewField(FieldError, []byte("You are not allowed to create news folders.")),
+ },
+ },
+ },
+ wantErr: assert.NoError,
+ },
+ {
+ name: "with a valid request",
+ args: args{
+ cc: &ClientConn{
+ Account: &Account{
+ Access: func() accessBitmap {
+ var bits accessBitmap
+ bits.Set(accessNewsCreateFldr)
+ return bits
+ }(),
+ },
+ logger: NewTestLogger(),
+ ID: &[]byte{0, 1},
+ Server: &Server{
+ ConfigDir: "/fakeConfigRoot",
+ FS: func() *MockFileStore {
+ mfs := &MockFileStore{}
+ mfs.On("WriteFile", "/fakeConfigRoot/ThreadedNews.yaml", mock.Anything, mock.Anything).Return(nil)
+ return mfs
+ }(),
+ ThreadedNews: &ThreadedNews{Categories: map[string]NewsCategoryListData15{
+ "test": {
+ Type: [2]byte{0, 2},
+ Name: "test",
+ SubCats: make(map[string]NewsCategoryListData15),
+ },
+ }},
+ },
+ },
+ t: NewTransaction(
+ TranGetNewsArtNameList, &[]byte{0, 1},
+ NewField(FieldFileName, []byte("testFolder")),
+ NewField(FieldNewsPath,
+ []byte{
+ 0, 1,
+ 0, 0,
+ 4,
+ 0x74, 0x65, 0x73, 0x74,
+ },
+ ),
+ ),
+ },
+ wantRes: []Transaction{
+ {
+ clientID: &[]byte{0, 1},
+ Flags: 0x00,
+ IsReply: 0x01,
+ Type: []byte{0, 0},
+ ID: []byte{0, 0, 0, 0},
+ ErrorCode: []byte{0, 0, 0, 0},
+ Fields: []Field{},
+ },
+ },
+ wantErr: assert.NoError,
+ },
+ //{
+ // Name: "when there is an error writing the threaded news file",
+ // args: args{
+ // cc: &ClientConn{
+ // Account: &Account{
+ // Access: func() accessBitmap {
+ // var bits accessBitmap
+ // bits.Set(accessNewsCreateFldr)
+ // return bits
+ // }(),
+ // },
+ // logger: NewTestLogger(),
+ // ID: &[]byte{0, 1},
+ // Server: &Server{
+ // ConfigDir: "/fakeConfigRoot",
+ // FS: func() *MockFileStore {
+ // mfs := &MockFileStore{}
+ // mfs.On("WriteFile", "/fakeConfigRoot/ThreadedNews.yaml", mock.Anything, mock.Anything).Return(os.ErrNotExist)
+ // return mfs
+ // }(),
+ // ThreadedNews: &ThreadedNews{Categories: map[string]NewsCategoryListData15{
+ // "test": {
+ // Type: []byte{0, 2},
+ // Count: nil,
+ // NameSize: 0,
+ // Name: "test",
+ // SubCats: make(map[string]NewsCategoryListData15),
+ // },
+ // }},
+ // },
+ // },
+ // t: NewTransaction(
+ // TranGetNewsArtNameList, &[]byte{0, 1},
+ // NewField(FieldFileName, []byte("testFolder")),
+ // NewField(FieldNewsPath,
+ // []byte{
+ // 0, 1,
+ // 0, 0,
+ // 4,
+ // 0x74, 0x65, 0x73, 0x74,
+ // },
+ // ),
+ // ),
+ // },
+ // wantRes: []Transaction{
+ // {
+ // clientID: &[]byte{0, 1},
+ // Flags: 0x00,
+ // IsReply: 0x01,
+ // Type: []byte{0, 0},
+ // ErrorCode: []byte{0, 0, 0, 1},
+ // Fields: []Field{
+ // NewField(FieldError, []byte("Error creating news folder.")),
+ // },
+ // },
+ // },
+ // wantErr: assert.Error,
+ // },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ gotRes, err := HandleNewNewsFldr(tt.args.cc, tt.args.t)
+ if !tt.wantErr(t, err, fmt.Sprintf("HandleNewNewsFldr(%v, %v)", tt.args.cc, tt.args.t)) {
+ return
+ }
+ tranAssertEqual(t, tt.wantRes, gotRes)
+ })
+ }
+}
+
+func TestHandleDownloadBanner(t *testing.T) {
+ type args struct {
+ cc *ClientConn
+ t *Transaction
+ }
+ tests := []struct {
+ name string
+ args args
+ wantRes []Transaction
+ wantErr assert.ErrorAssertionFunc
+ }{
+ // TODO: Add test cases.
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ gotRes, err := HandleDownloadBanner(tt.args.cc, tt.args.t)
+ if !tt.wantErr(t, err, fmt.Sprintf("HandleDownloadBanner(%v, %v)", tt.args.cc, tt.args.t)) {
+ return
+ }
+ assert.Equalf(t, tt.wantRes, gotRes, "HandleDownloadBanner(%v, %v)", tt.args.cc, tt.args.t)
+ })
+ }
+}
git.r.bdr.sh / rbdr / mobius / blobdiff