Use fixed size array types in Transaction fields

[rbdr/mobius] / hotline / file_path.go

diff --git a/hotline/file_path.go b/hotline/file_path.go
index f7da29818e8bfc2489442609aeaf99f3316fac60..620f54d5cd0a5b969ade3237ad57617d65fd370e 100644 (file)
--- a/hotline/file_path.go
+++ b/hotline/file_path.go
@@ -1,29 +1,47 @@
 package hotline
 
 import (
+       "bufio"
        "bytes"
        "encoding/binary"
        "errors"
-       "path"
+       "fmt"
+       "io"
+       "path/filepath"
        "strings"
 )
 
-const pathSeparator = "/" // File path separator TODO: make configurable to support Windows
-
 // FilePathItem represents the file or directory portion of a delimited file path (e.g. foo and bar in "/foo/bar")
+// Example bytes:
 // 00 00
 // 09
-// 73 75 62 66 6f 6c 64 65 72 // "subfolder"
+// 73 75 62 66 6f 6c 64 65 72  "subfolder"
 type FilePathItem struct {
        Len  byte
        Name []byte
 }
 
-func NewFilePathItem(b []byte) FilePathItem {
-       return FilePathItem{
-               Len:  b[2],
-               Name: b[3:],
+const fileItemMinLen = 3
+
+// fileItemScanner implements bufio.SplitFunc for parsing incoming byte slices into complete tokens
+func fileItemScanner(data []byte, _ bool) (advance int, token []byte, err error) {
+       if len(data) < fileItemMinLen {
+               return 0, nil, nil
        }
+
+       advance = fileItemMinLen + int(data[2])
+       return advance, data[0:advance], nil
+}
+
+// Write implements the io.Writer interface for FilePathItem
+func (fpi *FilePathItem) Write(b []byte) (n int, err error) {
+       if len(b) < 3 {
+               return n, errors.New("buflen too small")
+       }
+       fpi.Len = b[2]
+       fpi.Name = b[fileItemMinLen : fpi.Len+fileItemMinLen]
+
+       return int(fpi.Len) + fileItemMinLen, nil
 }
 
 type FilePath struct {
@@ -31,30 +49,39 @@ type FilePath struct {
        Items     []FilePathItem
 }
 
-const minFilePathLen = 2
-
-func (fp *FilePath) UnmarshalBinary(b []byte) error {
-       if b == nil {
-               return nil
-       }
-       if len(b) < minFilePathLen {
-               return errors.New("insufficient bytes")
+// Write implements io.Writer interface for FilePath
+func (fp *FilePath) Write(b []byte) (n int, err error) {
+       reader := bytes.NewReader(b)
+       err = binary.Read(reader, binary.BigEndian, &fp.ItemCount)
+       if err != nil && !errors.Is(err, io.EOF) {
+               return n, err
        }
-       err := binary.Read(bytes.NewReader(b[0:2]), binary.BigEndian, &fp.ItemCount)
-       if err != nil {
-               return err
+       if errors.Is(err, io.EOF) {
+               return n, nil
        }
 
-       pathData := b[2:]
-       for i := uint16(0); i < fp.Len(); i++ {
-               segLen := pathData[2]
-               fp.Items = append(fp.Items, NewFilePathItem(pathData[:segLen+3]))
-               pathData = pathData[3+segLen:]
+       scanner := bufio.NewScanner(reader)
+       scanner.Split(fileItemScanner)
+
+       for i := 0; i < int(binary.BigEndian.Uint16(fp.ItemCount[:])); i++ {
+               var fpi FilePathItem
+               scanner.Scan()
+
+               // Make a new []byte slice and copy the scanner bytes to it.  This is critical to avoid a data race as the
+               // scanner re-uses the buffer for subsequent scans.
+               buf := make([]byte, len(scanner.Bytes()))
+               copy(buf, scanner.Bytes())
+
+               if _, err := fpi.Write(buf); err != nil {
+                       return n, err
+               }
+               fp.Items = append(fp.Items, fpi)
        }
 
-       return nil
+       return n, nil
 }
 
+// IsDropbox checks if a FilePath matches the special drop box folder type
 func (fp *FilePath) IsDropbox() bool {
        if fp.Len() == 0 {
                return false
@@ -75,38 +102,27 @@ func (fp *FilePath) Len() uint16 {
        return binary.BigEndian.Uint16(fp.ItemCount[:])
 }
 
-func (fp *FilePath) String() string {
-       out := []string{"/"}
-       for _, i := range fp.Items {
-               out = append(out, string(i.Name))
-       }
-
-       return path.Join(out...)
-}
-
-func ReadFilePath(filePathFieldData []byte) string {
-       var fp FilePath
-       err := fp.UnmarshalBinary(filePathFieldData)
-       if err != nil {
-               // TODO
-       }
-       return fp.String()
-}
-
 func readPath(fileRoot string, filePath, fileName []byte) (fullPath string, err error) {
        var fp FilePath
        if filePath != nil {
-               if err = fp.UnmarshalBinary(filePath); err != nil {
+               if _, err = fp.Write(filePath); err != nil {
                        return "", err
                }
        }
 
-       fullPath = path.Join(
-               "/",
+       var subPath string
+       for _, pathItem := range fp.Items {
+               subPath = filepath.Join("/", subPath, string(pathItem.Name))
+       }
+
+       fullPath = filepath.Join(
                fileRoot,
-               fp.String(),
-               path.Join("/", string(fileName)),
+               subPath,
+               filepath.Join("/", string(fileName)),
        )
-
+       fullPath, err = txtDecoder.String(fullPath)
+       if err != nil {
+               return "", fmt.Errorf("invalid filepath encoding: %w", err)
+       }
        return fullPath, nil
 }