package hotline
import (
+ "fmt"
"github.com/stretchr/testify/assert"
"testing"
)
-func TestReadFields(t *testing.T) {
+func Test_transactionScanner(t *testing.T) {
type args struct {
- paramCount []byte
- buf []byte
+ data []byte
+ in1 bool
}
tests := []struct {
- name string
- args args
- want []Field
- wantErr bool
+ name string
+ args args
+ wantAdvance int
+ wantToken []byte
+ wantErr assert.ErrorAssertionFunc
}{
{
- name: "valid field data",
+ name: "when too few bytes are provided to read the transaction size",
args: args{
- paramCount: []byte{0x00, 0x02},
- buf: []byte{
- 0x00, 0x65, // ID: fieldData
- 0x00, 0x04, // Size: 2 bytes
- 0x01, 0x02, 0x03, 0x04, // Data
- 0x00, 0x66, // ID: fieldUserName
- 0x00, 0x02, // Size: 2 bytes
- 0x00, 0x01, // Data
- },
- },
- want: []Field{
- {
- ID: []byte{0x00, 0x65},
- FieldSize: []byte{0x00, 0x04},
- Data: []byte{0x01, 0x02, 0x03, 0x04},
- },
- {
- ID: []byte{0x00, 0x66},
- FieldSize: []byte{0x00, 0x02},
- Data: []byte{0x00, 0x01},
- },
+ data: []byte{},
+ in1: false,
},
- wantErr: false,
+ wantAdvance: 0,
+ wantToken: []byte(nil),
+ wantErr: assert.NoError,
},
{
- name: "empty bytes",
+ name: "when too few bytes are provided to read the full payload",
args: args{
- paramCount: []byte{0x00, 0x00},
- buf: []byte{},
+ data: []byte{
+ 0,
+ 1,
+ 0, 0,
+ 0, 00, 00, 04,
+ 00, 00, 00, 00,
+ 00, 00, 00, 10,
+ 00, 00, 00, 10,
+ },
+ in1: false,
},
- want: []Field(nil),
- wantErr: false,
+ wantAdvance: 0,
+ wantToken: []byte(nil),
+ wantErr: assert.NoError,
},
{
- name: "when field size does not match data length",
+ name: "when a full transaction is provided",
args: args{
- paramCount: []byte{0x00, 0x01},
- buf: []byte{
- 0x00, 0x65, // ID: fieldData
- 0x00, 0x04, // Size: 4 bytes
- 0x01, 0x02, 0x03, // Data
+ data: []byte{
+ 0,
+ 1,
+ 0, 0,
+ 0, 00, 00, 0x04,
+ 00, 00, 00, 0x00,
+ 00, 00, 00, 0x10,
+ 00, 00, 00, 0x10,
+ 00, 02,
+ 00, 0x6c, // 108 - FieldTransferSize
+ 00, 02,
+ 0x63, 0x3b,
+ 00, 0x6b, // 107 = FieldRefNum
+ 00, 0x04,
+ 00, 0x02, 0x93, 0x47,
},
+ in1: false,
+ },
+ wantAdvance: 36,
+ wantToken: []byte{
+ 0,
+ 1,
+ 0, 0,
+ 0, 00, 00, 0x04,
+ 00, 00, 00, 0x00,
+ 00, 00, 00, 0x10,
+ 00, 00, 00, 0x10,
+ 00, 02,
+ 00, 0x6c, // 108 - FieldTransferSize
+ 00, 02,
+ 0x63, 0x3b,
+ 00, 0x6b, // 107 = FieldRefNum
+ 00, 0x04,
+ 00, 0x02, 0x93, 0x47,
},
- want: []Field{},
- wantErr: true,
+ wantErr: assert.NoError,
},
{
- name: "when field size of second field does not match data length",
+ name: "when a full transaction plus extra bytes are provided",
args: args{
- paramCount: []byte{0x00, 0x01},
- buf: []byte{
- 0x00, 0x65, // ID: fieldData
- 0x00, 0x02, // Size: 2 bytes
- 0x01, 0x02, // Data
- 0x00, 0x65, // ID: fieldData
- 0x00, 0x04, // Size: 4 bytes
- 0x01, 0x02, 0x03, // Data
+ data: []byte{
+ 0,
+ 1,
+ 0, 0,
+ 0, 00, 00, 0x04,
+ 00, 00, 00, 0x00,
+ 00, 00, 00, 0x10,
+ 00, 00, 00, 0x10,
+ 00, 02,
+ 00, 0x6c, // 108 - FieldTransferSize
+ 00, 02,
+ 0x63, 0x3b,
+ 00, 0x6b, // 107 = FieldRefNum
+ 00, 0x04,
+ 00, 0x02, 0x93, 0x47,
+ 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
},
+ in1: false,
},
- want: []Field{},
- wantErr: true,
+ wantAdvance: 36,
+ wantToken: []byte{
+ 0,
+ 1,
+ 0, 0,
+ 0, 00, 00, 0x04,
+ 00, 00, 00, 0x00,
+ 00, 00, 00, 0x10,
+ 00, 00, 00, 0x10,
+ 00, 02,
+ 00, 0x6c, // 108 - FieldTransferSize
+ 00, 02,
+ 0x63, 0x3b,
+ 00, 0x6b, // 107 = FieldRefNum
+ 00, 0x04,
+ 00, 0x02, 0x93, 0x47,
+ },
+ wantErr: assert.NoError,
},
{
- name: "when field data has extra bytes",
+ name: "when two full transactions are provided",
args: args{
- paramCount: []byte{0x00, 0x01},
- buf: []byte{
- 0x00, 0x65, // ID: fieldData
- 0x00, 0x02, // Size: 2 bytes
- 0x01, 0x02, 0x03, // Data
+ data: []byte{
+ 0,
+ 1,
+ 0, 0,
+ 0, 00, 00, 0x04,
+ 00, 00, 00, 0x00,
+ 00, 00, 00, 0x10,
+ 00, 00, 00, 0x10,
+ 00, 02,
+ 00, 0x6c, // 108 - FieldTransferSize
+ 00, 02,
+ 0x63, 0x3b,
+ 00, 0x6b, // 107 = FieldRefNum
+ 00, 0x04,
+ 00, 0x02, 0x93, 0x47,
+ 0,
+ 1,
+ 0, 0,
+ 0, 00, 00, 0x04,
+ 00, 00, 00, 0x00,
+ 00, 00, 00, 0x10,
+ 00, 00, 00, 0x10,
+ 00, 02,
+ 00, 0x6c, // 108 - FieldTransferSize
+ 00, 02,
+ 0x63, 0x3b,
+ 00, 0x6b, // 107 = FieldRefNum
+ 00, 0x04,
+ 00, 0x02, 0x93, 0x47,
},
+ in1: false,
+ },
+ wantAdvance: 36,
+ wantToken: []byte{
+ 0,
+ 1,
+ 0, 0,
+ 0, 00, 00, 0x04,
+ 00, 00, 00, 0x00,
+ 00, 00, 00, 0x10,
+ 00, 00, 00, 0x10,
+ 00, 02,
+ 00, 0x6c, // 108 - FieldTransferSize
+ 00, 02,
+ 0x63, 0x3b,
+ 00, 0x6b, // 107 = FieldRefNum
+ 00, 0x04,
+ 00, 0x02, 0x93, 0x47,
},
- want: []Field{},
- wantErr: true,
+ wantErr: assert.NoError,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- got, err := ReadFields(tt.args.paramCount, tt.args.buf)
- if (err != nil) != tt.wantErr {
- t.Errorf("ReadFields() error = %v, wantErr %v", err, tt.wantErr)
+ gotAdvance, gotToken, err := transactionScanner(tt.args.data, tt.args.in1)
+ if !tt.wantErr(t, err, fmt.Sprintf("transactionScanner(%v, %v)", tt.args.data, tt.args.in1)) {
return
}
-
- if !assert.Equal(t, tt.want, got) {
- t.Errorf("ReadFields() got = %v, want %v", got, tt.want)
- }
+ assert.Equalf(t, tt.wantAdvance, gotAdvance, "transactionScanner(%v, %v)", tt.args.data, tt.args.in1)
+ assert.Equalf(t, tt.wantToken, gotToken, "transactionScanner(%v, %v)", tt.args.data, tt.args.in1)
})
}
}
-func TestReadTransaction(t *testing.T) {
- sampleTransaction := &Transaction{
- Flags: byte(0),
- IsReply: byte(0),
- Type: []byte{0x000, 0x93},
- ID: []byte{0x000, 0x00, 0x00, 0x01},
- ErrorCode: []byte{0x000, 0x00, 0x00, 0x00},
- TotalSize: []byte{0x000, 0x00, 0x00, 0x08},
- DataSize: []byte{0x000, 0x00, 0x00, 0x08},
- ParamCount: []byte{0x00, 0x01},
- Fields: []Field{
- {
- ID: []byte{0x00, 0x01},
- FieldSize: []byte{0x00, 0x02},
- Data: []byte{0xff, 0xff},
- },
- },
+func TestTransaction_Read(t1 *testing.T) {
+ type fields struct {
+ clientID [2]byte
+ Flags byte
+ IsReply byte
+ Type [2]byte
+ ID [4]byte
+ ErrorCode [4]byte
+ TotalSize [4]byte
+ DataSize [4]byte
+ ParamCount [2]byte
+ Fields []Field
+ readOffset int
}
-
type args struct {
- buf []byte
+ p []byte
}
tests := []struct {
- name string
- args args
- want *Transaction
- want1 int
- wantErr bool
+ name string
+ fields fields
+ args args
+ want int
+ wantErr assert.ErrorAssertionFunc
+ wantBytes []byte
}{
{
- name: "when buf contains all bytes for a single transaction",
+ name: "returns transaction bytes",
+ fields: fields{
+ Flags: 0x00,
+ IsReply: 0x01,
+ Type: [2]byte{0, 0},
+ ID: [4]byte{0x9a, 0xcb, 0x04, 0x42},
+ ErrorCode: [4]byte{0, 0, 0, 0},
+ Fields: []Field{
+ NewField(FieldData, []byte("TEST")),
+ },
+ },
args: args{
- buf: sampleTransaction.Payload(),
+ p: make([]byte, 1024),
},
- want: sampleTransaction,
- want1: len(sampleTransaction.Payload()),
- wantErr: false,
+ want: 30,
+ wantErr: assert.NoError,
+ wantBytes: []byte{0x0, 0x1, 0x0, 0x0, 0x9a, 0xcb, 0x4, 0x42, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xa, 0x0, 0x0, 0x0, 0xa, 0x0, 0x1, 0x0, 0x65, 0x0, 0x4, 0x54, 0x45, 0x53, 0x54},
},
{
- name: "when len(buf) is less than the length of the transaction",
+ name: "returns transaction bytes from readOffset",
+ fields: fields{
+ Flags: 0x00,
+ IsReply: 0x01,
+ Type: [2]byte{0, 0},
+ ID: [4]byte{0x9a, 0xcb, 0x04, 0x42},
+ ErrorCode: [4]byte{0, 0, 0, 0},
+ Fields: []Field{
+ NewField(FieldData, []byte("TEST")),
+ },
+ readOffset: 20,
+ },
+ args: args{
+ p: make([]byte, 1024),
+ },
+ want: 10,
+ wantErr: assert.NoError,
+ wantBytes: []byte{0x0, 0x1, 0x0, 0x65, 0x0, 0x4, 0x54, 0x45, 0x53, 0x54},
+ },
+ {
+ name: "returns io.EOF when all bytes read",
+ fields: fields{
+ Flags: 0x00,
+ IsReply: 0x01,
+ Type: [2]byte{0, 0},
+ ID: [4]byte{0x9a, 0xcb, 0x04, 0x42},
+ ErrorCode: [4]byte{0, 0, 0, 0},
+ Fields: []Field{
+ NewField(FieldData, []byte("TEST")),
+ },
+ readOffset: 30,
+ },
args: args{
- buf: sampleTransaction.Payload()[:len(sampleTransaction.Payload()) - 1],
+ p: make([]byte, 1024),
},
- want: nil,
- want1: 0,
- wantErr: true,
+ want: 0,
+ wantErr: assert.Error,
+ wantBytes: []byte{},
},
}
for _, tt := range tests {
- t.Run(tt.name, func(t *testing.T) {
- got, got1, err := ReadTransaction(tt.args.buf)
- if (err != nil) != tt.wantErr {
- t.Errorf("ReadTransaction() error = %v, wantErr %v", err, tt.wantErr)
- return
+ t1.Run(tt.name, func(t1 *testing.T) {
+ t := &Transaction{
+ ClientID: tt.fields.clientID,
+ Flags: tt.fields.Flags,
+ IsReply: tt.fields.IsReply,
+ Type: tt.fields.Type,
+ ID: tt.fields.ID,
+ ErrorCode: tt.fields.ErrorCode,
+ TotalSize: tt.fields.TotalSize,
+ DataSize: tt.fields.DataSize,
+ ParamCount: tt.fields.ParamCount,
+ Fields: tt.fields.Fields,
+ readOffset: tt.fields.readOffset,
}
- if !assert.Equal(t, tt.want, got) {
- t.Errorf("ReadTransaction() got = %v, want %v", got, tt.want)
+ got, err := t.Read(tt.args.p)
+ if !tt.wantErr(t1, err, fmt.Sprintf("Read(%v)", tt.args.p)) {
+ return
}
- if got1 != tt.want1 {
- t.Errorf("ReadTransaction() got1 = %v, want %v", got1, tt.want1)
+ assert.Equalf(t1, tt.want, got, "Read(%v)", tt.args.p)
+ assert.Equalf(t1, tt.wantBytes, tt.args.p[:got], "Read(%v)", tt.args.p)
+ })
+ }
+}
+
+func TestTransaction_Write(t1 *testing.T) {
+ type args struct {
+ p []byte
+ }
+ tests := []struct {
+ name string
+ args args
+ wantN int
+ wantErr assert.ErrorAssertionFunc
+ wantTransaction Transaction
+ }{
+ {
+ name: "returns error if arg p is too small",
+ args: args{p: []byte{
+ 0x00, 0x00,
+ }},
+ wantN: 0,
+ wantErr: assert.Error,
+ wantTransaction: Transaction{},
+ },
+ //{
+ // name: "returns error if param data is invalid",
+ // args: args{p: []byte{
+ // 0x00, 0x00, 0x00, 0x69, 0x00, 0x00, 0x15, 0x72,
+ // 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x09,
+ // 0x00, 0x00, 0x00, 0x09, 0x00, 0x00, 0x00, 0x65,
+ // 0x00, 0x03, 0x68, 0x61, 0x69,
+ // }},
+ // wantN: 0,
+ // wantErr: assert.Error,
+ // wantTransaction: Transaction{},
+ //},
+ {
+ name: "writes bytes to transaction",
+ args: args{p: []byte{
+ 0x00, 0x00, 0x00, 0x69, 0x00, 0x00, 0x15, 0x72,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x09,
+ 0x00, 0x00, 0x00, 0x09, 0x00, 0x01, 0x00, 0x65,
+ 0x00, 0x03, 0x68, 0x61, 0x69,
+ }},
+ wantN: 29,
+ wantErr: assert.NoError,
+ wantTransaction: Transaction{
+ Flags: 0,
+ IsReply: 0,
+ Type: TranChatSend,
+ ID: [4]byte{},
+ ErrorCode: [4]byte{},
+ TotalSize: [4]byte{0, 0, 0, 9},
+ DataSize: [4]byte{0, 0, 0, 9},
+ ParamCount: [2]byte{0, 1},
+ Fields: []Field{
+ {
+ Type: FieldData,
+ FieldSize: [2]byte{0, 3},
+ Data: []byte("hai"),
+ },
+ },
+ ClientID: [2]byte{},
+ readOffset: 0,
+ },
+ },
+ }
+ for _, tt := range tests {
+ t1.Run(tt.name, func(t1 *testing.T) {
+ t := &Transaction{}
+ gotN, err := t.Write(tt.args.p)
+ if !tt.wantErr(t1, err, fmt.Sprintf("Write(%v)", tt.args.p)) {
+ return
}
+ assert.Equalf(t1, tt.wantN, gotN, "Write(%v)", tt.args.p)
+
+ TranAssertEqual(t1, []Transaction{tt.wantTransaction}, []Transaction{*t})
})
}
}
git.r.bdr.sh / rbdr / mobius / blobdiff