Appease linter

[rbdr/mobius] / hotline / transfer.go

diff --git a/hotline/transfer.go b/hotline/transfer.go
index 78bd888ccc35e3b27f168fcdc4ab6e7c20b7f0e1..5cb28c8e60fba1927470860ba22597485c28fe83 100644 (file)
--- a/hotline/transfer.go
+++ b/hotline/transfer.go
@@ -1,7 +1,6 @@
 package hotline
 
 import (
-       "bufio"
        "bytes"
        "encoding/binary"
        "errors"
@@ -10,7 +9,7 @@ import (
 
 type transfer struct {
        Protocol        [4]byte // "HTXF" 0x48545846
-       ReferenceNumber [4]byte // Unique ID generated for the transfer
+       ReferenceNumber [4]byte // Unique Type generated for the transfer
        DataSize        [4]byte // File size
        RSVD            [4]byte // Not implemented in Hotline Protocol
 }
@@ -29,83 +28,28 @@ func (tf *transfer) Write(b []byte) (int, error) {
        return len(b), nil
 }
 
-const fileCopyBufSize = 524288 // 512k
-func receiveFile(conn io.Reader, targetFile io.Writer, resForkFile io.Writer) error {
-       ffhBuf := make([]byte, 24)
-       if _, err := conn.Read(ffhBuf); err != nil {
+func receiveFile(r io.Reader, targetFile, resForkFile, infoFork, counterWriter io.Writer) error {
+       var ffo flattenedFileObject
+       if _, err := ffo.ReadFrom(r); err != nil {
                return err
        }
 
-       var ffh FlatFileHeader
-       err := binary.Read(bytes.NewReader(ffhBuf), binary.BigEndian, &ffh)
+       // Write the information fork
+       _, err := io.Copy(infoFork, &ffo.FlatFileInformationFork)
        if err != nil {
                return err
        }
 
-       ffifhBuf := make([]byte, 16)
-       if _, err := conn.Read(ffifhBuf); err != nil {
+       if _, err = io.CopyN(targetFile, io.TeeReader(r, counterWriter), ffo.dataSize()); err != nil {
                return err
        }
 
-       var ffifh FlatFileInformationForkHeader
-       err = binary.Read(bytes.NewReader(ffifhBuf), binary.BigEndian, &ffifh)
-       if err != nil {
-               return err
-       }
-
-       var ffif FlatFileInformationFork
-
-       dataLen := binary.BigEndian.Uint32(ffifh.DataSize[:])
-       ffifBuf := make([]byte, dataLen)
-       if _, err := conn.Read(ffifBuf); err != nil {
-               return err
-       }
-       if err := ffif.UnmarshalBinary(ffifBuf); err != nil {
-               return err
-       }
-
-       var ffdfh FlatFileDataForkHeader
-       ffdfhBuf := make([]byte, 16)
-       if _, err := conn.Read(ffdfhBuf); err != nil {
-               return err
-       }
-       err = binary.Read(bytes.NewReader(ffdfhBuf), binary.BigEndian, &ffdfh)
-       if err != nil {
-               return err
-       }
-
-       // this will be zero if the file only has a resource fork
-       fileSize := int(binary.BigEndian.Uint32(ffdfh.DataSize[:]))
-
-       bw := bufio.NewWriterSize(targetFile, fileCopyBufSize)
-       _, err = io.CopyN(bw, conn, int64(fileSize))
-       if err != nil {
-               return err
-       }
-       if err := bw.Flush(); err != nil {
-               return err
-       }
-
-       if ffh.ForkCount == [2]byte{0, 3} {
-               var resForkHeader FlatFileDataForkHeader
-               resForkBuf := make([]byte, 16)
-               resForkBufWrter := bufio.NewWriterSize(resForkFile, 16)
-               if _, err := io.CopyN(resForkBufWrter, conn, 16); err != nil {
-                       return err
-               }
-               err = binary.Read(bytes.NewReader(resForkBuf), binary.BigEndian, &resForkHeader)
-               if err != nil {
+       if ffo.FlatFileHeader.ForkCount == [2]byte{0, 3} {
+               if err := binary.Read(r, binary.BigEndian, &ffo.FlatFileResForkHeader); err != nil {
                        return err
                }
 
-               fileSize = int(binary.BigEndian.Uint32(resForkHeader.DataSize[:]))
-
-               bw = bufio.NewWriterSize(resForkFile, fileCopyBufSize)
-               _, err = io.CopyN(resForkFile, conn, int64(fileSize))
-               if err != nil {
-                       return err
-               }
-               if err := bw.Flush(); err != nil {
+               if _, err = io.CopyN(resForkFile, io.TeeReader(r, counterWriter), ffo.rsrcSize()); err != nil {
                        return err
                }
        }