Adopt more fixed size array types for struct fields

[rbdr/mobius] / hotline / field.go

diff --git a/hotline/field.go b/hotline/field.go
index 045e09fce8aad3a6a2974a271f6a1faac1ad8eac..2fcb41a1a5451e070ba187fe17695af4d3f90171 100644 (file)
--- a/hotline/field.go
+++ b/hotline/field.go
@@ -80,17 +80,11 @@ type requiredField struct {
 }
 
 func NewField(id uint16, data []byte) Field {
 }
 
 func NewField(id uint16, data []byte) Field {

-       idBytes := make([]byte, 2)
-       binary.BigEndian.PutUint16(idBytes, id)
+       f := Field{Data: data}
+       binary.BigEndian.PutUint16(f.ID[:], id)
+       binary.BigEndian.PutUint16(f.FieldSize[:], uint16(len(data)))

 
 

-       bs := make([]byte, 2)
-       binary.BigEndian.PutUint16(bs, uint16(len(data)))
-
-       return Field{
-               ID:        [2]byte(idBytes),
-               FieldSize: [2]byte(bs),
-               Data:      data,
-       }
+       return f

 }
 
 // fieldScanner implements bufio.SplitFunc for parsing byte slices into complete tokens
 }
 
 // fieldScanner implements bufio.SplitFunc for parsing byte slices into complete tokens