From 2f0f3d45f4335327c269a689fbeb62b3003695aa Mon Sep 17 00:00:00 2001 From: la_ninpre Date: Wed, 28 Jan 2026 11:30:03 +0300 Subject: static files: allow files in a subdirectory allowing '/' in paths is a bit scary, but replacing the check with reject on '..' seems to work. please correct me if i'm wrong and this is insecure. --- data.c | 2 +- html.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/data.c b/data.c index 27825ad..02686e1 100644 --- a/data.c +++ b/data.c @@ -2691,7 +2691,7 @@ static int _load_raw_file(const char *fn, xs_val **data, int *size, xs_str *_static_fn(snac *snac, const char *id) /* gets the filename for a static file */ { - if (strchr(id, '/')) + if (strstr(id, "..")) return NULL; else return xs_fmt("%s/static/%s", snac->basedir, id); diff --git a/html.c b/html.c index 7b93e49..2a03579 100644 --- a/html.c +++ b/html.c @@ -5026,7 +5026,7 @@ int html_get_handler(const xs_dict *req, const char *q_path, } else if (xs_startswith(p_path, "s/")) { /** a static file **/ - xs *l = xs_split(p_path, "/"); + xs *l = xs_split_n(p_path, "/", 1); const char *id = xs_list_get(l, 1); int sz; -- cgit