From: Jeff Halter <redacted>
Date: Mon, 6 Jun 2022 23:44:57 +0000 (-0700)
Subject: Improve tracker logging
X-Git-Url: https://git.r.bdr.sh/rbdr/mobius/commitdiff_plain/e42888eb1a6c2bfb6c8bd73baba6acdfddb1f72e?ds=sidebyside

Improve tracker logging
---

diff --git a/hotline/server.go b/hotline/server.go
index 2bd5c04..cfac442 100644
--- a/hotline/server.go
+++ b/hotline/server.go
@@ -236,9 +236,15 @@ func NewServer(configDir, netInterface string, netPort int, logger *zap.SugaredL
 	*server.NextGuestID = 1
 
 	if server.Config.EnableTrackerRegistration {
+		server.Logger.Infow(
+			"Tracker registration enabled",
+			"frequency", fmt.Sprintf("%vs", trackerUpdateFrequency),
+			"trackers", server.Config.Trackers,
+		)
+
 		go func() {
 			for {
-				tr := TrackerRegistration{
+				tr := &TrackerRegistration{
 					Port:        []byte{0x15, 0x7c},
 					UserCount:   server.userCount(),
 					PassID:      server.TrackerPassID,
@@ -246,11 +252,10 @@ func NewServer(configDir, netInterface string, netPort int, logger *zap.SugaredL
 					Description: server.Config.Description,
 				}
 				for _, t := range server.Config.Trackers {
-					server.Logger.Infof("Registering with tracker %v", t)
-
 					if err := register(t, tr); err != nil {
 						server.Logger.Errorw("unable to register with tracker %v", "error", err)
 					}
+					server.Logger.Infow("Sent Tracker registration", "data", tr)
 				}
 
 				time.Sleep(trackerUpdateFrequency * time.Second)
diff --git a/hotline/tracker.go b/hotline/tracker.go
index 0825fc7..2fc6004 100644
--- a/hotline/tracker.go
+++ b/hotline/tracker.go
@@ -36,7 +36,7 @@ func (tr *TrackerRegistration) Payload() []byte {
 	)
 }
 
-func register(tracker string, tr TrackerRegistration) error {
+func register(tracker string, tr *TrackerRegistration) error {
 	conn, err := net.Dial("udp", tracker)
 	if err != nil {
 		return err