X-Git-Url: https://git.r.bdr.sh/rbdr/mobius/blobdiff_plain/d005ef04cfaa26943e6dd33807d741577ffb232a..6699cff21c226aa900ed3517c0f7ef3d50cefc17:/hotline/user.go

diff --git a/hotline/user.go b/hotline/user.go
index a86aeba..e64bf84 100644
--- a/hotline/user.go
+++ b/hotline/user.go
@@ -2,14 +2,16 @@ package hotline
 
 import (
 	"encoding/binary"
+	"io"
+	"slices"
 )
 
-// User flags are stored as a 2 byte bitmap with the following values:
+// User flags are stored as a 2 byte bitmap and represent various user states
 const (
-	userFlagAway        = 0 // User is away
-	userFlagAdmin       = 1 // User is admin
-	userFlagRefusePM    = 2 // User refuses private messages
-	userFLagRefusePChat = 3 // User refuses private chat
+	UserFlagAway        = 0 // User is away
+	UserFlagAdmin       = 1 // User is admin
+	UserFlagRefusePM    = 2 // User refuses private messages
+	UserFlagRefusePChat = 3 // User refuses private chat
 )
 
 // FieldOptions flags are sent from v1.5+ clients as part of TranAgreed
@@ -26,7 +28,7 @@ type User struct {
 	Name  string // Variable length user name
 }
 
-func (u User) Payload() []byte {
+func (u *User) Read(p []byte) (int, error) {
 	nameLen := make([]byte, 2)
 	binary.BigEndian.PutUint16(nameLen, uint16(len(u.Name)))
 
@@ -43,32 +45,29 @@ func (u User) Payload() []byte {
 	out = append(out, nameLen...)
 	out = append(out, u.Name...)
 
-	return out
+	return copy(p, slices.Concat(
+		u.ID,
+		u.Icon,
+		u.Flags,
+		nameLen,
+		[]byte(u.Name),
+	)), io.EOF
 }
 
-func ReadUser(b []byte) (*User, error) {
-	u := &User{
-		ID:    b[0:2],
-		Icon:  b[2:4],
-		Flags: b[4:6],
-		Name:  string(b[8:]),
-	}
-	return u, nil
-}
+func (u *User) Write(p []byte) (int, error) {
+	namelen := int(binary.BigEndian.Uint16(p[6:8]))
+	u.ID = p[0:2]
+	u.Icon = p[2:4]
+	u.Flags = p[4:6]
+	u.Name = string(p[8 : 8+namelen])
 
-// DecodeUserString decodes an obfuscated user string from a client
-// e.g. 98 8a 9a 8c 8b => "guest"
-func DecodeUserString(obfuText []byte) (clearText string) {
-	for _, char := range obfuText {
-		clearText += string(rune(255 - uint(char)))
-	}
-	return clearText
+	return 8 + namelen, nil
 }
 
-// negateString takes []byte s containing cleartext and rotates by 255 into obfuscated cleartext.
+// encodeString takes []byte s containing cleartext and rotates by 255 into obfuscated cleartext.
 // The Hotline protocol uses this format for sending passwords over network.
 // Not secure, but hey, it was the 90s!
-func negateString(clearText []byte) []byte {
+func encodeString(clearText []byte) []byte {
 	obfuText := make([]byte, len(clearText))
 	for i := 0; i < len(clearText); i++ {
 		obfuText[i] = 255 - clearText[i]