X-Git-Url: https://git.r.bdr.sh/rbdr/mobius/blobdiff_plain/8eb43f95a6f11b6c256ff339399e9479898b4380..9cf66aeafbcbb9237fedc2efc97cc2856eb60f7f:/hotline/transaction_handlers_test.go

diff --git a/hotline/transaction_handlers_test.go b/hotline/transaction_handlers_test.go
index 893a537..ca1722f 100644
--- a/hotline/transaction_handlers_test.go
+++ b/hotline/transaction_handlers_test.go
@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/mock"
+	"io"
 	"io/fs"
 	"math/rand"
 	"os"
@@ -73,8 +74,8 @@ func TestHandleSetChatSubject(t *testing.T) {
 					ID:        []byte{0, 0, 0, 1},
 					ErrorCode: []byte{0, 0, 0, 0},
 					Fields: []Field{
-						NewField(fieldChatID, []byte{0, 0, 0, 1}),
-						NewField(fieldChatSubject, []byte("Test Subject")),
+						NewField(FieldChatID, []byte{0, 0, 0, 1}),
+						NewField(FieldChatSubject, []byte("Test Subject")),
 					},
 				},
 			},
@@ -87,8 +88,8 @@ func TestHandleSetChatSubject(t *testing.T) {
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42}, // Random ID from rand.Seed(1)
 					ErrorCode: []byte{0, 0, 0, 0},
 					Fields: []Field{
-						NewField(fieldChatID, []byte{0, 0, 0, 1}),
-						NewField(fieldChatSubject, []byte("Test Subject")),
+						NewField(FieldChatID, []byte{0, 0, 0, 1}),
+						NewField(FieldChatSubject, []byte("Test Subject")),
 					},
 				},
 				{
@@ -99,8 +100,8 @@ func TestHandleSetChatSubject(t *testing.T) {
 					ID:        []byte{0xf0, 0xc5, 0x34, 0x1e}, // Random ID from rand.Seed(1)
 					ErrorCode: []byte{0, 0, 0, 0},
 					Fields: []Field{
-						NewField(fieldChatID, []byte{0, 0, 0, 1}),
-						NewField(fieldChatSubject, []byte("Test Subject")),
+						NewField(FieldChatID, []byte{0, 0, 0, 1}),
+						NewField(FieldChatSubject, []byte("Test Subject")),
 					},
 				},
 			},
@@ -174,7 +175,7 @@ func TestHandleLeaveChat(t *testing.T) {
 						},
 					},
 				},
-				t: NewTransaction(tranDeleteUser, nil, NewField(fieldChatID, []byte{0, 0, 0, 1})),
+				t: NewTransaction(TranDeleteUser, nil, NewField(FieldChatID, []byte{0, 0, 0, 1})),
 			},
 			want: []Transaction{
 				{
@@ -185,8 +186,8 @@ func TestHandleLeaveChat(t *testing.T) {
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42}, // Random ID from rand.Seed(1)
 					ErrorCode: []byte{0, 0, 0, 0},
 					Fields: []Field{
-						NewField(fieldChatID, []byte{0, 0, 0, 1}),
-						NewField(fieldUserID, []byte{0, 2}),
+						NewField(FieldChatID, []byte{0, 0, 0, 1}),
+						NewField(FieldUserID, []byte{0, 2}),
 					},
 				},
 			},
@@ -232,21 +233,12 @@ func TestHandleGetUserNameList(t *testing.T) {
 								Icon:     []byte{0, 2},
 								Flags:    []byte{0, 3},
 								UserName: []byte{0, 4},
-								Agreed:   true,
 							},
 							uint16(2): {
 								ID:       &[]byte{0, 2},
 								Icon:     []byte{0, 2},
 								Flags:    []byte{0, 3},
 								UserName: []byte{0, 4},
-								Agreed:   true,
-							},
-							uint16(3): {
-								ID:       &[]byte{0, 3},
-								Icon:     []byte{0, 2},
-								Flags:    []byte{0, 3},
-								UserName: []byte{0, 4},
-								Agreed:   false,
 							},
 						},
 					},
@@ -261,16 +253,16 @@ func TestHandleGetUserNameList(t *testing.T) {
 					clientID:  &[]byte{1, 1},
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 1},
+					Type:      []byte{0, 0},
 					ID:        []byte{0, 0, 0, 1},
 					ErrorCode: []byte{0, 0, 0, 0},
 					Fields: []Field{
 						NewField(
-							fieldUsernameWithInfo,
+							FieldUsernameWithInfo,
 							[]byte{00, 01, 00, 02, 00, 03, 00, 02, 00, 04},
 						),
 						NewField(
-							fieldUsernameWithInfo,
+							FieldUsernameWithInfo,
 							[]byte{00, 02, 00, 02, 00, 03, 00, 02, 00, 04},
 						),
 					},
@@ -333,7 +325,69 @@ func TestHandleChatSend(t *testing.T) {
 				},
 				t: &Transaction{
 					Fields: []Field{
-						NewField(fieldData, []byte("hai")),
+						NewField(FieldData, []byte("hai")),
+					},
+				},
+			},
+			want: []Transaction{
+				{
+					clientID:  &[]byte{0, 1},
+					Flags:     0x00,
+					IsReply:   0x00,
+					Type:      []byte{0, 0x6a},
+					ID:        []byte{0x9a, 0xcb, 0x04, 0x42}, // Random ID from rand.Seed(1)
+					ErrorCode: []byte{0, 0, 0, 0},
+					Fields: []Field{
+						NewField(FieldData, []byte{0x0d, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x00, 0x01, 0x3a, 0x20, 0x20, 0x68, 0x61, 0x69}),
+					},
+				},
+				{
+					clientID:  &[]byte{0, 2},
+					Flags:     0x00,
+					IsReply:   0x00,
+					Type:      []byte{0, 0x6a},
+					ID:        []byte{0xf0, 0xc5, 0x34, 0x1e}, // Random ID from rand.Seed(1)
+					ErrorCode: []byte{0, 0, 0, 0},
+					Fields: []Field{
+						NewField(FieldData, []byte{0x0d, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x00, 0x01, 0x3a, 0x20, 0x20, 0x68, 0x61, 0x69}),
+					},
+				},
+			},
+			wantErr: false,
+		},
+		{
+			name: "treats Chat ID 00 00 00 00 as a public chat message",
+			args: args{
+				cc: &ClientConn{
+					Account: &Account{
+						Access: func() accessBitmap {
+							var bits accessBitmap
+							bits.Set(accessSendChat)
+							return bits
+						}(),
+					},
+					UserName: []byte{0x00, 0x01},
+					Server: &Server{
+						Clients: map[uint16]*ClientConn{
+							uint16(1): {
+								Account: &Account{
+									Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
+								},
+								ID: &[]byte{0, 1},
+							},
+							uint16(2): {
+								Account: &Account{
+									Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
+								},
+								ID: &[]byte{0, 2},
+							},
+						},
+					},
+				},
+				t: &Transaction{
+					Fields: []Field{
+						NewField(FieldData, []byte("hai")),
+						NewField(FieldChatID, []byte{0, 0, 0, 0}),
 					},
 				},
 			},
@@ -346,7 +400,7 @@ func TestHandleChatSend(t *testing.T) {
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42}, // Random ID from rand.Seed(1)
 					ErrorCode: []byte{0, 0, 0, 0},
 					Fields: []Field{
-						NewField(fieldData, []byte{0x0d, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x00, 0x01, 0x3a, 0x20, 0x20, 0x68, 0x61, 0x69}),
+						NewField(FieldData, []byte{0x0d, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x00, 0x01, 0x3a, 0x20, 0x20, 0x68, 0x61, 0x69}),
 					},
 				},
 				{
@@ -357,7 +411,7 @@ func TestHandleChatSend(t *testing.T) {
 					ID:        []byte{0xf0, 0xc5, 0x34, 0x1e}, // Random ID from rand.Seed(1)
 					ErrorCode: []byte{0, 0, 0, 0},
 					Fields: []Field{
-						NewField(fieldData, []byte{0x0d, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x00, 0x01, 0x3a, 0x20, 0x20, 0x68, 0x61, 0x69}),
+						NewField(FieldData, []byte{0x0d, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x00, 0x01, 0x3a, 0x20, 0x20, 0x68, 0x61, 0x69}),
 					},
 				},
 			},
@@ -378,26 +432,88 @@ func TestHandleChatSend(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranChatSend, &[]byte{0, 1},
-					NewField(fieldData, []byte("hai")),
+					TranChatSend, &[]byte{0, 1},
+					NewField(FieldData, []byte("hai")),
 				),
 			},
 			want: []Transaction{
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0x00},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
 					ErrorCode: []byte{0, 0, 0, 1},
 					Fields: []Field{
-						NewField(fieldError, []byte("You are not allowed to participate in chat.")),
+						NewField(FieldError, []byte("You are not allowed to participate in chat.")),
+					},
+				},
+			},
+			wantErr: false,
+		},
+		{
+			name: "sends chat msg as emote if FieldChatOptions is set to 1",
+			args: args{
+				cc: &ClientConn{
+					Account: &Account{
+						Access: func() accessBitmap {
+							var bits accessBitmap
+							bits.Set(accessSendChat)
+							return bits
+						}(),
+					},
+					UserName: []byte("Testy McTest"),
+					Server: &Server{
+						Clients: map[uint16]*ClientConn{
+							uint16(1): {
+								Account: &Account{
+									Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
+								},
+								ID: &[]byte{0, 1},
+							},
+							uint16(2): {
+								Account: &Account{
+									Access: accessBitmap{255, 255, 255, 255, 255, 255, 255, 255},
+								},
+								ID: &[]byte{0, 2},
+							},
+						},
+					},
+				},
+				t: &Transaction{
+					Fields: []Field{
+						NewField(FieldData, []byte("performed action")),
+						NewField(FieldChatOptions, []byte{0x00, 0x01}),
+					},
+				},
+			},
+			want: []Transaction{
+				{
+					clientID:  &[]byte{0, 1},
+					Flags:     0x00,
+					IsReply:   0x00,
+					Type:      []byte{0, 0x6a},
+					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
+					ErrorCode: []byte{0, 0, 0, 0},
+					Fields: []Field{
+						NewField(FieldData, []byte("\r*** Testy McTest performed action")),
+					},
+				},
+				{
+					clientID:  &[]byte{0, 2},
+					Flags:     0x00,
+					IsReply:   0x00,
+					Type:      []byte{0, 0x6a},
+					ID:        []byte{0xf0, 0xc5, 0x34, 0x1e},
+					ErrorCode: []byte{0, 0, 0, 0},
+					Fields: []Field{
+						NewField(FieldData, []byte("\r*** Testy McTest performed action")),
 					},
 				},
 			},
 			wantErr: false,
 		},
 		{
-			name: "sends chat msg as emote if fieldChatOptions is set",
+			name: "does not send chat msg as emote if FieldChatOptions is set to 0",
 			args: args{
 				cc: &ClientConn{
 					Account: &Account{
@@ -427,8 +543,8 @@ func TestHandleChatSend(t *testing.T) {
 				},
 				t: &Transaction{
 					Fields: []Field{
-						NewField(fieldData, []byte("performed action")),
-						NewField(fieldChatOptions, []byte{0x00, 0x01}),
+						NewField(FieldData, []byte("hello")),
+						NewField(FieldChatOptions, []byte{0x00, 0x00}),
 					},
 				},
 			},
@@ -441,7 +557,7 @@ func TestHandleChatSend(t *testing.T) {
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
 					ErrorCode: []byte{0, 0, 0, 0},
 					Fields: []Field{
-						NewField(fieldData, []byte("\r*** Testy McTest performed action")),
+						NewField(FieldData, []byte("\r Testy McTest:  hello")),
 					},
 				},
 				{
@@ -452,7 +568,7 @@ func TestHandleChatSend(t *testing.T) {
 					ID:        []byte{0xf0, 0xc5, 0x34, 0x1e},
 					ErrorCode: []byte{0, 0, 0, 0},
 					Fields: []Field{
-						NewField(fieldData, []byte("\r*** Testy McTest performed action")),
+						NewField(FieldData, []byte("\r Testy McTest:  hello")),
 					},
 				},
 			},
@@ -492,7 +608,7 @@ func TestHandleChatSend(t *testing.T) {
 				},
 				t: &Transaction{
 					Fields: []Field{
-						NewField(fieldData, []byte("hai")),
+						NewField(FieldData, []byte("hai")),
 					},
 				},
 			},
@@ -505,7 +621,7 @@ func TestHandleChatSend(t *testing.T) {
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42}, // Random ID from rand.Seed(1)
 					ErrorCode: []byte{0, 0, 0, 0},
 					Fields: []Field{
-						NewField(fieldData, []byte{0x0d, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x00, 0x01, 0x3a, 0x20, 0x20, 0x68, 0x61, 0x69}),
+						NewField(FieldData, []byte{0x0d, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x00, 0x01, 0x3a, 0x20, 0x20, 0x68, 0x61, 0x69}),
 					},
 				},
 			},
@@ -560,8 +676,8 @@ func TestHandleChatSend(t *testing.T) {
 				},
 				t: &Transaction{
 					Fields: []Field{
-						NewField(fieldData, []byte("hai")),
-						NewField(fieldChatID, []byte{0, 0, 0, 1}),
+						NewField(FieldData, []byte("hai")),
+						NewField(FieldChatID, []byte{0, 0, 0, 1}),
 					},
 				},
 			},
@@ -574,8 +690,8 @@ func TestHandleChatSend(t *testing.T) {
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
 					ErrorCode: []byte{0, 0, 0, 0},
 					Fields: []Field{
-						NewField(fieldChatID, []byte{0, 0, 0, 1}),
-						NewField(fieldData, []byte{0x0d, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x00, 0x01, 0x3a, 0x20, 0x20, 0x68, 0x61, 0x69}),
+						NewField(FieldChatID, []byte{0, 0, 0, 1}),
+						NewField(FieldData, []byte{0x0d, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x00, 0x01, 0x3a, 0x20, 0x20, 0x68, 0x61, 0x69}),
 					},
 				},
 				{
@@ -586,8 +702,8 @@ func TestHandleChatSend(t *testing.T) {
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
 					ErrorCode: []byte{0, 0, 0, 0},
 					Fields: []Field{
-						NewField(fieldChatID, []byte{0, 0, 0, 1}),
-						NewField(fieldData, []byte{0x0d, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x00, 0x01, 0x3a, 0x20, 0x20, 0x68, 0x61, 0x69}),
+						NewField(FieldChatID, []byte{0, 0, 0, 1}),
+						NewField(FieldData, []byte{0x0d, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x00, 0x01, 0x3a, 0x20, 0x20, 0x68, 0x61, 0x69}),
 					},
 				},
 			},
@@ -636,9 +752,9 @@ func TestHandleGetFileInfo(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranGetFileInfo, nil,
-					NewField(fieldFileName, []byte("testfile.txt")),
-					NewField(fieldFilePath, []byte{0x00, 0x00}),
+					TranGetFileInfo, nil,
+					NewField(FieldFileName, []byte("testfile.txt")),
+					NewField(FieldFilePath, []byte{0x00, 0x00}),
 				),
 			},
 			wantRes: []Transaction{
@@ -646,18 +762,17 @@ func TestHandleGetFileInfo(t *testing.T) {
 					clientID:  &[]byte{0, 1},
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0xce},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42}, // Random ID from rand.Seed(1)
 					ErrorCode: []byte{0, 0, 0, 0},
 					Fields: []Field{
-						NewField(fieldFileName, []byte("testfile.txt")),
-						NewField(fieldFileTypeString, []byte("Text File")),
-						NewField(fieldFileCreatorString, []byte("ttxt")),
-						NewField(fieldFileComment, []byte{}),
-						NewField(fieldFileType, []byte("TEXT")),
-						NewField(fieldFileCreateDate, make([]byte, 8)),
-						NewField(fieldFileModifyDate, make([]byte, 8)),
-						NewField(fieldFileSize, []byte{0x0, 0x0, 0x0, 0x17}),
+						NewField(FieldFileName, []byte("testfile.txt")),
+						NewField(FieldFileTypeString, []byte("Text File")),
+						NewField(FieldFileCreatorString, []byte("ttxt")),
+						NewField(FieldFileType, []byte("TEXT")),
+						NewField(FieldFileCreateDate, make([]byte, 8)),
+						NewField(FieldFileModifyDate, make([]byte, 8)),
+						NewField(FieldFileSize, []byte{0x0, 0x0, 0x0, 0x17}),
 					},
 				},
 			},
@@ -676,8 +791,8 @@ func TestHandleGetFileInfo(t *testing.T) {
 
 			// Clear the fileWrapper timestamp fields to work around problems running the tests in multiple timezones
 			// TODO: revisit how to test this by mocking the stat calls
+			gotRes[0].Fields[4].Data = make([]byte, 8)
 			gotRes[0].Fields[5].Data = make([]byte, 8)
-			gotRes[0].Fields[6].Data = make([]byte, 8)
 			if !assert.Equal(t, tt.wantRes, gotRes) {
 				t.Errorf("HandleGetFileInfo() gotRes = %v, want %v", gotRes, tt.wantRes)
 			}
@@ -716,11 +831,11 @@ func TestHandleNewFolder(t *testing.T) {
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0x00},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
 					ErrorCode: []byte{0, 0, 0, 1},
 					Fields: []Field{
-						NewField(fieldError, []byte("You are not allowed to create folders.")),
+						NewField(FieldError, []byte("You are not allowed to create folders.")),
 					},
 				},
 			},
@@ -751,9 +866,9 @@ func TestHandleNewFolder(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranNewFolder, &[]byte{0, 1},
-					NewField(fieldFileName, []byte("testFolder")),
-					NewField(fieldFilePath, []byte{
+					TranNewFolder, &[]byte{0, 1},
+					NewField(FieldFileName, []byte("testFolder")),
+					NewField(FieldFilePath, []byte{
 						0x00, 0x01,
 						0x00, 0x00,
 						0x03,
@@ -766,7 +881,7 @@ func TestHandleNewFolder(t *testing.T) {
 					clientID:  &[]byte{0, 1},
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0xcd},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42}, // Random ID from rand.Seed(1)
 					ErrorCode: []byte{0, 0, 0, 0},
 				},
@@ -798,8 +913,8 @@ func TestHandleNewFolder(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranNewFolder, &[]byte{0, 1},
-					NewField(fieldFileName, []byte("testFolder")),
+					TranNewFolder, &[]byte{0, 1},
+					NewField(FieldFileName, []byte("testFolder")),
 				),
 			},
 			wantRes: []Transaction{
@@ -807,7 +922,7 @@ func TestHandleNewFolder(t *testing.T) {
 					clientID:  &[]byte{0, 1},
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0xcd},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42}, // Random ID from rand.Seed(1)
 					ErrorCode: []byte{0, 0, 0, 0},
 				},
@@ -839,9 +954,9 @@ func TestHandleNewFolder(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranNewFolder, &[]byte{0, 1},
-					NewField(fieldFileName, []byte("testFolder")),
-					NewField(fieldFilePath, []byte{
+					TranNewFolder, &[]byte{0, 1},
+					NewField(FieldFileName, []byte("testFolder")),
+					NewField(FieldFilePath, []byte{
 						0x00,
 					}),
 				),
@@ -850,7 +965,7 @@ func TestHandleNewFolder(t *testing.T) {
 			wantErr: true,
 		},
 		{
-			name: "fieldFileName does not allow directory traversal",
+			name: "FieldFileName does not allow directory traversal",
 			args: args{
 				cc: &ClientConn{
 					Account: &Account{
@@ -874,8 +989,8 @@ func TestHandleNewFolder(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranNewFolder, &[]byte{0, 1},
-					NewField(fieldFileName, []byte("../../testFolder")),
+					TranNewFolder, &[]byte{0, 1},
+					NewField(FieldFileName, []byte("../../testFolder")),
 				),
 			},
 			wantRes: []Transaction{
@@ -883,14 +998,14 @@ func TestHandleNewFolder(t *testing.T) {
 					clientID:  &[]byte{0, 1},
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0xcd},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42}, // Random ID from rand.Seed(1)
 					ErrorCode: []byte{0, 0, 0, 0},
 				},
 			}, wantErr: false,
 		},
 		{
-			name: "fieldFilePath does not allow directory traversal",
+			name: "FieldFilePath does not allow directory traversal",
 			args: args{
 				cc: &ClientConn{
 					Account: &Account{
@@ -914,9 +1029,9 @@ func TestHandleNewFolder(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranNewFolder, &[]byte{0, 1},
-					NewField(fieldFileName, []byte("testFolder")),
-					NewField(fieldFilePath, []byte{
+					TranNewFolder, &[]byte{0, 1},
+					NewField(FieldFileName, []byte("testFolder")),
+					NewField(FieldFilePath, []byte{
 						0x00, 0x02,
 						0x00, 0x00,
 						0x03,
@@ -932,7 +1047,7 @@ func TestHandleNewFolder(t *testing.T) {
 					clientID:  &[]byte{0, 1},
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0xcd},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42}, // Random ID from rand.Seed(1)
 					ErrorCode: []byte{0, 0, 0, 0},
 				},
@@ -941,7 +1056,6 @@ func TestHandleNewFolder(t *testing.T) {
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-
 			gotRes, err := HandleNewFolder(tt.args.cc, tt.args.t)
 			if (err != nil) != tt.wantErr {
 				t.Errorf("HandleNewFolder() error = %v, wantErr %v", err, tt.wantErr)
@@ -989,9 +1103,9 @@ func TestHandleUploadFile(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranUploadFile, &[]byte{0, 1},
-					NewField(fieldFileName, []byte("testFile")),
-					NewField(fieldFilePath, []byte{
+					TranUploadFile, &[]byte{0, 1},
+					NewField(FieldFileName, []byte("testFile")),
+					NewField(FieldFilePath, []byte{
 						0x00, 0x01,
 						0x00, 0x00,
 						0x03,
@@ -1003,11 +1117,11 @@ func TestHandleUploadFile(t *testing.T) {
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0xcb},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
 					ErrorCode: []byte{0, 0, 0, 0},
 					Fields: []Field{
-						NewField(fieldRefNum, []byte{0x52, 0xfd, 0xfc, 0x07}), // rand.Seed(1)
+						NewField(FieldRefNum, []byte{0x52, 0xfd, 0xfc, 0x07}), // rand.Seed(1)
 					},
 				},
 			},
@@ -1025,9 +1139,9 @@ func TestHandleUploadFile(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranUploadFile, &[]byte{0, 1},
-					NewField(fieldFileName, []byte("testFile")),
-					NewField(fieldFilePath, []byte{
+					TranUploadFile, &[]byte{0, 1},
+					NewField(FieldFileName, []byte("testFile")),
+					NewField(FieldFilePath, []byte{
 						0x00, 0x01,
 						0x00, 0x00,
 						0x03,
@@ -1039,11 +1153,11 @@ func TestHandleUploadFile(t *testing.T) {
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0x00},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
 					ErrorCode: []byte{0, 0, 0, 1},
 					Fields: []Field{
-						NewField(fieldError, []byte("You are not allowed to upload files.")), // rand.Seed(1)
+						NewField(FieldError, []byte("You are not allowed to upload files.")), // rand.Seed(1)
 					},
 				},
 			},
@@ -1060,7 +1174,6 @@ func TestHandleUploadFile(t *testing.T) {
 			}
 
 			tranAssertEqual(t, tt.wantRes, gotRes)
-
 		})
 	}
 }
@@ -1109,17 +1222,17 @@ func TestHandleMakeAlias(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranMakeFileAlias, &[]byte{0, 1},
-					NewField(fieldFileName, []byte("testFile")),
-					NewField(fieldFilePath, EncodeFilePath(strings.Join([]string{"foo"}, "/"))),
-					NewField(fieldFileNewPath, EncodeFilePath(strings.Join([]string{"bar"}, "/"))),
+					TranMakeFileAlias, &[]byte{0, 1},
+					NewField(FieldFileName, []byte("testFile")),
+					NewField(FieldFilePath, EncodeFilePath(strings.Join([]string{"foo"}, "/"))),
+					NewField(FieldFileNewPath, EncodeFilePath(strings.Join([]string{"bar"}, "/"))),
 				),
 			},
 			wantRes: []Transaction{
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0xd1},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
 					ErrorCode: []byte{0, 0, 0, 0},
 					Fields:    []Field(nil),
@@ -1160,21 +1273,21 @@ func TestHandleMakeAlias(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranMakeFileAlias, &[]byte{0, 1},
-					NewField(fieldFileName, []byte("testFile")),
-					NewField(fieldFilePath, EncodeFilePath(strings.Join([]string{"foo"}, "/"))),
-					NewField(fieldFileNewPath, EncodeFilePath(strings.Join([]string{"bar"}, "/"))),
+					TranMakeFileAlias, &[]byte{0, 1},
+					NewField(FieldFileName, []byte("testFile")),
+					NewField(FieldFilePath, EncodeFilePath(strings.Join([]string{"foo"}, "/"))),
+					NewField(FieldFileNewPath, EncodeFilePath(strings.Join([]string{"bar"}, "/"))),
 				),
 			},
 			wantRes: []Transaction{
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0x00},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
 					ErrorCode: []byte{0, 0, 0, 1},
 					Fields: []Field{
-						NewField(fieldError, []byte("Error creating alias")),
+						NewField(FieldError, []byte("Error creating alias")),
 					},
 				},
 			},
@@ -1201,15 +1314,15 @@ func TestHandleMakeAlias(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranMakeFileAlias, &[]byte{0, 1},
-					NewField(fieldFileName, []byte("testFile")),
-					NewField(fieldFilePath, []byte{
+					TranMakeFileAlias, &[]byte{0, 1},
+					NewField(FieldFileName, []byte("testFile")),
+					NewField(FieldFilePath, []byte{
 						0x00, 0x01,
 						0x00, 0x00,
 						0x03,
 						0x2e, 0x2e, 0x2e,
 					}),
-					NewField(fieldFileNewPath, []byte{
+					NewField(FieldFileNewPath, []byte{
 						0x00, 0x01,
 						0x00, 0x00,
 						0x03,
@@ -1221,11 +1334,11 @@ func TestHandleMakeAlias(t *testing.T) {
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0x00},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
 					ErrorCode: []byte{0, 0, 0, 1},
 					Fields: []Field{
-						NewField(fieldError, []byte("You are not allowed to make aliases.")),
+						NewField(FieldError, []byte("You are not allowed to make aliases.")),
 					},
 				},
 			},
@@ -1279,22 +1392,22 @@ func TestHandleGetUser(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranGetUser, &[]byte{0, 1},
-					NewField(fieldUserLogin, []byte("guest")),
+					TranGetUser, &[]byte{0, 1},
+					NewField(FieldUserLogin, []byte("guest")),
 				),
 			},
 			wantRes: []Transaction{
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0x01, 0x60},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
 					ErrorCode: []byte{0, 0, 0, 0},
 					Fields: []Field{
-						NewField(fieldUserName, []byte("Guest")),
-						NewField(fieldUserLogin, negateString([]byte("guest"))),
-						NewField(fieldUserPassword, []byte("password")),
-						NewField(fieldUserAccess, []byte{0, 0, 0, 0, 0, 0, 0, 0}),
+						NewField(FieldUserName, []byte("Guest")),
+						NewField(FieldUserLogin, encodeString([]byte("guest"))),
+						NewField(FieldUserPassword, []byte("password")),
+						NewField(FieldUserAccess, []byte{0, 0, 0, 0, 0, 0, 0, 0}),
 					},
 				},
 			},
@@ -1315,19 +1428,19 @@ func TestHandleGetUser(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranGetUser, &[]byte{0, 1},
-					NewField(fieldUserLogin, []byte("nonExistentUser")),
+					TranGetUser, &[]byte{0, 1},
+					NewField(FieldUserLogin, []byte("nonExistentUser")),
 				),
 			},
 			wantRes: []Transaction{
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0x00},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
 					ErrorCode: []byte{0, 0, 0, 1},
 					Fields: []Field{
-						NewField(fieldError, []byte("You are not allowed to view accounts.")),
+						NewField(FieldError, []byte("You are not allowed to view accounts.")),
 					},
 				},
 			},
@@ -1349,19 +1462,19 @@ func TestHandleGetUser(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranGetUser, &[]byte{0, 1},
-					NewField(fieldUserLogin, []byte("nonExistentUser")),
+					TranGetUser, &[]byte{0, 1},
+					NewField(FieldUserLogin, []byte("nonExistentUser")),
 				),
 			},
 			wantRes: []Transaction{
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0x00},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
 					ErrorCode: []byte{0, 0, 0, 1},
 					Fields: []Field{
-						NewField(fieldError, []byte("Account does not exist.")),
+						NewField(FieldError, []byte("Account does not exist.")),
 					},
 				},
 			},
@@ -1419,15 +1532,15 @@ func TestHandleDeleteUser(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranDeleteUser, &[]byte{0, 1},
-					NewField(fieldUserLogin, negateString([]byte("testuser"))),
+					TranDeleteUser, &[]byte{0, 1},
+					NewField(FieldUserLogin, encodeString([]byte("testuser"))),
 				),
 			},
 			wantRes: []Transaction{
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0x1, 0x5f},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
 					ErrorCode: []byte{0, 0, 0, 0},
 					Fields:    []Field(nil),
@@ -1450,19 +1563,19 @@ func TestHandleDeleteUser(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranDeleteUser, &[]byte{0, 1},
-					NewField(fieldUserLogin, negateString([]byte("testuser"))),
+					TranDeleteUser, &[]byte{0, 1},
+					NewField(FieldUserLogin, encodeString([]byte("testuser"))),
 				),
 			},
 			wantRes: []Transaction{
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0x00},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
 					ErrorCode: []byte{0, 0, 0, 1},
 					Fields: []Field{
-						NewField(fieldError, []byte("You are not allowed to delete accounts.")),
+						NewField(FieldError, []byte("You are not allowed to delete accounts.")),
 					},
 				},
 			},
@@ -1508,18 +1621,18 @@ func TestHandleGetMsgs(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranGetMsgs, &[]byte{0, 1},
+					TranGetMsgs, &[]byte{0, 1},
 				),
 			},
 			wantRes: []Transaction{
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0x65},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
 					ErrorCode: []byte{0, 0, 0, 0},
 					Fields: []Field{
-						NewField(fieldData, []byte("TEST")),
+						NewField(FieldData, []byte("TEST")),
 					},
 				},
 			},
@@ -1540,18 +1653,18 @@ func TestHandleGetMsgs(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranGetMsgs, &[]byte{0, 1},
+					TranGetMsgs, &[]byte{0, 1},
 				),
 			},
 			wantRes: []Transaction{
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0x00},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
 					ErrorCode: []byte{0, 0, 0, 1},
 					Fields: []Field{
-						NewField(fieldError, []byte("You are not allowed to read news.")),
+						NewField(FieldError, []byte("You are not allowed to read news.")),
 					},
 				},
 			},
@@ -1596,18 +1709,60 @@ func TestHandleNewUser(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranNewUser, &[]byte{0, 1},
+					TranNewUser, &[]byte{0, 1},
+				),
+			},
+			wantRes: []Transaction{
+				{
+					Flags:     0x00,
+					IsReply:   0x01,
+					Type:      []byte{0, 0},
+					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
+					ErrorCode: []byte{0, 0, 0, 1},
+					Fields: []Field{
+						NewField(FieldError, []byte("You are not allowed to create new accounts.")),
+					},
+				},
+			},
+			wantErr: assert.NoError,
+		},
+		{
+			name: "when user attempts to create account with greater access",
+			args: args{
+				cc: &ClientConn{
+					Account: &Account{
+						Access: func() accessBitmap {
+							var bits accessBitmap
+							bits.Set(accessCreateUser)
+							return bits
+						}(),
+					},
+					Server: &Server{
+						Accounts: map[string]*Account{},
+					},
+				},
+				t: NewTransaction(
+					TranNewUser, &[]byte{0, 1},
+					NewField(FieldUserLogin, []byte("userB")),
+					NewField(
+						FieldUserAccess,
+						func() []byte {
+							var bits accessBitmap
+							bits.Set(accessDisconUser)
+							return bits[:]
+						}(),
+					),
 				),
 			},
 			wantRes: []Transaction{
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0x00},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
 					ErrorCode: []byte{0, 0, 0, 1},
 					Fields: []Field{
-						NewField(fieldError, []byte("You are not allowed to create new accounts.")),
+						NewField(FieldError, []byte("Cannot create account with more access than yourself.")),
 					},
 				},
 			},
@@ -1652,18 +1807,18 @@ func TestHandleListUsers(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranNewUser, &[]byte{0, 1},
+					TranNewUser, &[]byte{0, 1},
 				),
 			},
 			wantRes: []Transaction{
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0x00},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
 					ErrorCode: []byte{0, 0, 0, 1},
 					Fields: []Field{
-						NewField(fieldError, []byte("You are not allowed to view accounts.")),
+						NewField(FieldError, []byte("You are not allowed to view accounts.")),
 					},
 				},
 			},
@@ -1692,19 +1847,19 @@ func TestHandleListUsers(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranGetClientInfoText, &[]byte{0, 1},
-					NewField(fieldUserID, []byte{0, 1}),
+					TranGetClientInfoText, &[]byte{0, 1},
+					NewField(FieldUserID, []byte{0, 1}),
 				),
 			},
 			wantRes: []Transaction{
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0x01, 0x2f},
+					Type:      []byte{0, 0},
 					ID:        []byte{0, 0, 0, 0},
 					ErrorCode: []byte{0, 0, 0, 0},
 					Fields: []Field{
-						NewField(fieldData, []byte{
+						NewField(FieldData, []byte{
 							0x00, 0x04, 0x00, 0x66, 0x00, 0x05, 0x67, 0x75, 0x65, 0x73, 0x74, 0x00, 0x69, 0x00, 0x05, 0x98,
 							0x8a, 0x9a, 0x8c, 0x8b, 0x00, 0x6e, 0x00, 0x08, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
 							0x00, 0x6a, 0x00, 0x01, 0x78,
@@ -1750,17 +1905,17 @@ func TestHandleDownloadFile(t *testing.T) {
 					},
 					Server: &Server{},
 				},
-				t: NewTransaction(tranDownloadFile, &[]byte{0, 1}),
+				t: NewTransaction(TranDownloadFile, &[]byte{0, 1}),
 			},
 			wantRes: []Transaction{
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0x00},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
 					ErrorCode: []byte{0, 0, 0, 1},
 					Fields: []Field{
-						NewField(fieldError, []byte("You are not allowed to download files.")),
+						NewField(FieldError, []byte("You are not allowed to download files.")),
 					},
 				},
 			},
@@ -1792,22 +1947,22 @@ func TestHandleDownloadFile(t *testing.T) {
 				t: NewTransaction(
 					accessDownloadFile,
 					&[]byte{0, 1},
-					NewField(fieldFileName, []byte("testfile.txt")),
-					NewField(fieldFilePath, []byte{0x0, 0x00}),
+					NewField(FieldFileName, []byte("testfile.txt")),
+					NewField(FieldFilePath, []byte{0x0, 0x00}),
 				),
 			},
 			wantRes: []Transaction{
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0x2},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
 					ErrorCode: []byte{0, 0, 0, 0},
 					Fields: []Field{
-						NewField(fieldRefNum, []byte{0x52, 0xfd, 0xfc, 0x07}),
-						NewField(fieldWaitingCount, []byte{0x00, 0x00}),
-						NewField(fieldTransferSize, []byte{0x00, 0x00, 0x00, 0xa5}),
-						NewField(fieldFileSize, []byte{0x00, 0x00, 0x00, 0x17}),
+						NewField(FieldRefNum, []byte{0x52, 0xfd, 0xfc, 0x07}),
+						NewField(FieldWaitingCount, []byte{0x00, 0x00}),
+						NewField(FieldTransferSize, []byte{0x00, 0x00, 0x00, 0xa5}),
+						NewField(FieldFileSize, []byte{0x00, 0x00, 0x00, 0x17}),
 					},
 				},
 			},
@@ -1856,10 +2011,10 @@ func TestHandleDownloadFile(t *testing.T) {
 				t: NewTransaction(
 					accessDownloadFile,
 					&[]byte{0, 1},
-					NewField(fieldFileName, []byte("testfile-1k")),
-					NewField(fieldFilePath, []byte{0x00, 0x00}),
+					NewField(FieldFileName, []byte("testfile-1k")),
+					NewField(FieldFilePath, []byte{0x00, 0x00}),
 					NewField(
-						fieldFileResumeData,
+						FieldFileResumeData,
 						func() []byte {
 							frd := FileResumeData{
 								Format:    [4]byte{},
@@ -1891,14 +2046,14 @@ func TestHandleDownloadFile(t *testing.T) {
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0x2},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
 					ErrorCode: []byte{0, 0, 0, 0},
 					Fields: []Field{
-						NewField(fieldRefNum, []byte{0x52, 0xfd, 0xfc, 0x07}),
-						NewField(fieldWaitingCount, []byte{0x00, 0x00}),
-						NewField(fieldTransferSize, []byte{0x00, 0x00, 0x03, 0x8d}),
-						NewField(fieldFileSize, []byte{0x00, 0x00, 0x03, 0x00}),
+						NewField(FieldRefNum, []byte{0x52, 0xfd, 0xfc, 0x07}),
+						NewField(FieldWaitingCount, []byte{0x00, 0x00}),
+						NewField(FieldTransferSize, []byte{0x00, 0x00, 0x03, 0x8d}),
+						NewField(FieldFileSize, []byte{0x00, 0x00, 0x03, 0x00}),
 					},
 				},
 			},
@@ -1944,24 +2099,24 @@ func TestHandleUpdateUser(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranUpdateUser,
+					TranUpdateUser,
 					&[]byte{0, 0},
-					NewField(fieldData, []byte{
+					NewField(FieldData, []byte{
 						0x00, 0x04, // field count
 
-						0x00, 0x69, // fieldUserLogin = 105
+						0x00, 0x69, // FieldUserLogin = 105
 						0x00, 0x03,
 						0x9d, 0x9d, 0x9d,
 
-						0x00, 0x6a, // fieldUserPassword = 106
+						0x00, 0x6a, // FieldUserPassword = 106
 						0x00, 0x03,
 						0x9c, 0x9c, 0x9c,
 
-						0x00, 0x66, // fieldUserName = 102
+						0x00, 0x66, // FieldUserName = 102
 						0x00, 0x03,
 						0x61, 0x61, 0x61,
 
-						0x00, 0x6e, // fieldUserAccess = 110
+						0x00, 0x6e, // FieldUserAccess = 110
 						0x00, 0x08,
 						0x60, 0x70, 0x0c, 0x20, 0x03, 0x80, 0x00, 0x00,
 					}),
@@ -1971,11 +2126,11 @@ func TestHandleUpdateUser(t *testing.T) {
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0x00},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
 					ErrorCode: []byte{0, 0, 0, 1},
 					Fields: []Field{
-						NewField(fieldError, []byte("You are not allowed to create new accounts.")),
+						NewField(FieldError, []byte("You are not allowed to create new accounts.")),
 					},
 				},
 			},
@@ -2000,24 +2155,24 @@ func TestHandleUpdateUser(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranUpdateUser,
+					TranUpdateUser,
 					&[]byte{0, 0},
-					NewField(fieldData, []byte{
+					NewField(FieldData, []byte{
 						0x00, 0x04, // field count
 
-						0x00, 0x69, // fieldUserLogin = 105
+						0x00, 0x69, // FieldUserLogin = 105
 						0x00, 0x03,
 						0x9d, 0x9d, 0x9d,
 
-						0x00, 0x6a, // fieldUserPassword = 106
+						0x00, 0x6a, // FieldUserPassword = 106
 						0x00, 0x03,
 						0x9c, 0x9c, 0x9c,
 
-						0x00, 0x66, // fieldUserName = 102
+						0x00, 0x66, // FieldUserName = 102
 						0x00, 0x03,
 						0x61, 0x61, 0x61,
 
-						0x00, 0x6e, // fieldUserAccess = 110
+						0x00, 0x6e, // FieldUserAccess = 110
 						0x00, 0x08,
 						0x60, 0x70, 0x0c, 0x20, 0x03, 0x80, 0x00, 0x00,
 					}),
@@ -2027,11 +2182,11 @@ func TestHandleUpdateUser(t *testing.T) {
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0x00},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
 					ErrorCode: []byte{0, 0, 0, 1},
 					Fields: []Field{
-						NewField(fieldError, []byte("You are not allowed to modify accounts.")),
+						NewField(FieldError, []byte("You are not allowed to modify accounts.")),
 					},
 				},
 			},
@@ -2055,9 +2210,9 @@ func TestHandleUpdateUser(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranUpdateUser,
+					TranUpdateUser,
 					&[]byte{0, 0},
-					NewField(fieldData, []byte{
+					NewField(FieldData, []byte{
 						0x00, 0x01,
 						0x00, 0x65,
 						0x00, 0x03,
@@ -2069,11 +2224,11 @@ func TestHandleUpdateUser(t *testing.T) {
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0x00},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
 					ErrorCode: []byte{0, 0, 0, 1},
 					Fields: []Field{
-						NewField(fieldError, []byte("You are not allowed to delete accounts.")),
+						NewField(FieldError, []byte("You are not allowed to delete accounts.")),
 					},
 				},
 			},
@@ -2115,7 +2270,7 @@ func TestHandleDelNewsArt(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranDelNewsArt,
+					TranDelNewsArt,
 					&[]byte{0, 0},
 				),
 			},
@@ -2123,11 +2278,11 @@ func TestHandleDelNewsArt(t *testing.T) {
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0x00},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
 					ErrorCode: []byte{0, 0, 0, 1},
 					Fields: []Field{
-						NewField(fieldError, []byte("You are not allowed to delete news articles.")),
+						NewField(FieldError, []byte("You are not allowed to delete news articles.")),
 					},
 				},
 			},
@@ -2168,7 +2323,7 @@ func TestHandleDisconnectUser(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranDelNewsArt,
+					TranDelNewsArt,
 					&[]byte{0, 0},
 				),
 			},
@@ -2176,11 +2331,11 @@ func TestHandleDisconnectUser(t *testing.T) {
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0x00},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
 					ErrorCode: []byte{0, 0, 0, 1},
 					Fields: []Field{
-						NewField(fieldError, []byte("You are not allowed to disconnect users.")),
+						NewField(FieldError, []byte("You are not allowed to disconnect users.")),
 					},
 				},
 			},
@@ -2213,20 +2368,20 @@ func TestHandleDisconnectUser(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranDelNewsArt,
+					TranDelNewsArt,
 					&[]byte{0, 0},
-					NewField(fieldUserID, []byte{0, 1}),
+					NewField(FieldUserID, []byte{0, 1}),
 				),
 			},
 			wantRes: []Transaction{
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0x00},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
 					ErrorCode: []byte{0, 0, 0, 1},
 					Fields: []Field{
-						NewField(fieldError, []byte("unnamed is not allowed to be disconnected.")),
+						NewField(FieldError, []byte("unnamed is not allowed to be disconnected.")),
 					},
 				},
 			},
@@ -2267,7 +2422,7 @@ func TestHandleSendInstantMsg(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranDelNewsArt,
+					TranDelNewsArt,
 					&[]byte{0, 0},
 				),
 			},
@@ -2275,15 +2430,15 @@ func TestHandleSendInstantMsg(t *testing.T) {
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0x00},
+					Type:      []byte{0, 0},
 					ID:        []byte{0, 0, 0, 0},
 					ErrorCode: []byte{0, 0, 0, 1},
 					Fields: []Field{
-						NewField(fieldError, []byte("You are not allowed to send private messages.")),
+						NewField(FieldError, []byte("You are not allowed to send private messages.")),
 					},
 				},
 			},
-			wantErr: assert.NoError,
+			wantErr: assert.Error,
 		},
 		{
 			name: "when client 1 sends a message to client 2",
@@ -2302,31 +2457,32 @@ func TestHandleSendInstantMsg(t *testing.T) {
 						Clients: map[uint16]*ClientConn{
 							uint16(2): {
 								AutoReply: []byte(nil),
+								Flags:     []byte{0, 0},
 							},
 						},
 					},
 				},
 				t: NewTransaction(
-					tranSendInstantMsg,
+					TranSendInstantMsg,
 					&[]byte{0, 1},
-					NewField(fieldData, []byte("hai")),
-					NewField(fieldUserID, []byte{0, 2}),
+					NewField(FieldData, []byte("hai")),
+					NewField(FieldUserID, []byte{0, 2}),
 				),
 			},
 			wantRes: []Transaction{
 				*NewTransaction(
-					tranServerMsg,
+					TranServerMsg,
 					&[]byte{0, 2},
-					NewField(fieldData, []byte("hai")),
-					NewField(fieldUserName, []byte("User1")),
-					NewField(fieldUserID, []byte{0, 1}),
-					NewField(fieldOptions, []byte{0, 1}),
+					NewField(FieldData, []byte("hai")),
+					NewField(FieldUserName, []byte("User1")),
+					NewField(FieldUserID, []byte{0, 1}),
+					NewField(FieldOptions, []byte{0, 1}),
 				),
 				{
 					clientID:  &[]byte{0, 1},
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0x0, 0x6c},
+					Type:      []byte{0, 0},
 					ID:        []byte{0, 0, 0, 0},
 					ErrorCode: []byte{0, 0, 0, 0},
 					Fields:    []Field(nil),
@@ -2350,6 +2506,7 @@ func TestHandleSendInstantMsg(t *testing.T) {
 					Server: &Server{
 						Clients: map[uint16]*ClientConn{
 							uint16(2): {
+								Flags:     []byte{0, 0},
 								ID:        &[]byte{0, 2},
 								UserName:  []byte("User2"),
 								AutoReply: []byte("autohai"),
@@ -2358,34 +2515,85 @@ func TestHandleSendInstantMsg(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranSendInstantMsg,
+					TranSendInstantMsg,
 					&[]byte{0, 1},
-					NewField(fieldData, []byte("hai")),
-					NewField(fieldUserID, []byte{0, 2}),
+					NewField(FieldData, []byte("hai")),
+					NewField(FieldUserID, []byte{0, 2}),
 				),
 			},
 			wantRes: []Transaction{
 				*NewTransaction(
-					tranServerMsg,
+					TranServerMsg,
 					&[]byte{0, 2},
-					NewField(fieldData, []byte("hai")),
-					NewField(fieldUserName, []byte("User1")),
-					NewField(fieldUserID, []byte{0, 1}),
-					NewField(fieldOptions, []byte{0, 1}),
+					NewField(FieldData, []byte("hai")),
+					NewField(FieldUserName, []byte("User1")),
+					NewField(FieldUserID, []byte{0, 1}),
+					NewField(FieldOptions, []byte{0, 1}),
+				),
+				*NewTransaction(
+					TranServerMsg,
+					&[]byte{0, 1},
+					NewField(FieldData, []byte("autohai")),
+					NewField(FieldUserName, []byte("User2")),
+					NewField(FieldUserID, []byte{0, 2}),
+					NewField(FieldOptions, []byte{0, 1}),
+				),
+				{
+					clientID:  &[]byte{0, 1},
+					Flags:     0x00,
+					IsReply:   0x01,
+					Type:      []byte{0, 0},
+					ID:        []byte{0, 0, 0, 0},
+					ErrorCode: []byte{0, 0, 0, 0},
+					Fields:    []Field(nil),
+				},
+			},
+			wantErr: assert.NoError,
+		},
+		{
+			name: "when client 2 has refuse private messages enabled",
+			args: args{
+				cc: &ClientConn{
+					Account: &Account{
+						Access: func() accessBitmap {
+							var bits accessBitmap
+							bits.Set(accessSendPrivMsg)
+							return bits
+						}(),
+					},
+					ID:       &[]byte{0, 1},
+					UserName: []byte("User1"),
+					Server: &Server{
+						Clients: map[uint16]*ClientConn{
+							uint16(2): {
+								Flags:    []byte{255, 255},
+								ID:       &[]byte{0, 2},
+								UserName: []byte("User2"),
+							},
+						},
+					},
+				},
+				t: NewTransaction(
+					TranSendInstantMsg,
+					&[]byte{0, 1},
+					NewField(FieldData, []byte("hai")),
+					NewField(FieldUserID, []byte{0, 2}),
 				),
+			},
+			wantRes: []Transaction{
 				*NewTransaction(
-					tranServerMsg,
+					TranServerMsg,
 					&[]byte{0, 1},
-					NewField(fieldData, []byte("autohai")),
-					NewField(fieldUserName, []byte("User2")),
-					NewField(fieldUserID, []byte{0, 2}),
-					NewField(fieldOptions, []byte{0, 1}),
+					NewField(FieldData, []byte("User2 does not accept private messages.")),
+					NewField(FieldUserName, []byte("User2")),
+					NewField(FieldUserID, []byte{0, 2}),
+					NewField(FieldOptions, []byte{0, 2}),
 				),
 				{
 					clientID:  &[]byte{0, 1},
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0x0, 0x6c},
+					Type:      []byte{0, 0},
 					ID:        []byte{0, 0, 0, 0},
 					ErrorCode: []byte{0, 0, 0, 0},
 					Fields:    []Field(nil),
@@ -2452,9 +2660,9 @@ func TestHandleDeleteFile(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranDeleteFile, &[]byte{0, 1},
-					NewField(fieldFileName, []byte("testfile")),
-					NewField(fieldFilePath, []byte{
+					TranDeleteFile, &[]byte{0, 1},
+					NewField(FieldFileName, []byte("testfile")),
+					NewField(FieldFilePath, []byte{
 						0x00, 0x01,
 						0x00, 0x00,
 						0x03,
@@ -2466,11 +2674,11 @@ func TestHandleDeleteFile(t *testing.T) {
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0x00},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
 					ErrorCode: []byte{0, 0, 0, 1},
 					Fields: []Field{
-						NewField(fieldError, []byte("You are not allowed to delete files.")),
+						NewField(FieldError, []byte("You are not allowed to delete files.")),
 					},
 				},
 			},
@@ -2517,9 +2725,9 @@ func TestHandleDeleteFile(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranDeleteFile, &[]byte{0, 1},
-					NewField(fieldFileName, []byte("testfile")),
-					NewField(fieldFilePath, []byte{
+					TranDeleteFile, &[]byte{0, 1},
+					NewField(FieldFileName, []byte("testfile")),
+					NewField(FieldFilePath, []byte{
 						0x00, 0x01,
 						0x00, 0x00,
 						0x03,
@@ -2531,7 +2739,7 @@ func TestHandleDeleteFile(t *testing.T) {
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0x0, 0xcc},
+					Type:      []byte{0, 0},
 					ID:        []byte{0x0, 0x0, 0x0, 0x0},
 					ErrorCode: []byte{0, 0, 0, 0},
 					Fields:    []Field(nil),
@@ -2566,7 +2774,7 @@ func TestHandleGetFileNameList(t *testing.T) {
 		wantErr assert.ErrorAssertionFunc
 	}{
 		{
-			name: "when fieldFilePath is a drop box, but user does not have accessViewDropBoxes ",
+			name: "when FieldFilePath is a drop box, but user does not have accessViewDropBoxes ",
 			args: args{
 				cc: &ClientConn{
 					Account: &Account{
@@ -2586,8 +2794,8 @@ func TestHandleGetFileNameList(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranGetFileNameList, &[]byte{0, 1},
-					NewField(fieldFilePath, []byte{
+					TranGetFileNameList, &[]byte{0, 1},
+					NewField(FieldFilePath, []byte{
 						0x00, 0x01,
 						0x00, 0x00,
 						0x08,
@@ -2599,11 +2807,11 @@ func TestHandleGetFileNameList(t *testing.T) {
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0x00},
+					Type:      []byte{0, 0},
 					ID:        []byte{0, 0, 0, 0},
 					ErrorCode: []byte{0, 0, 0, 1},
 					Fields: []Field{
-						NewField(fieldError, []byte("You are not allowed to view drop boxes.")),
+						NewField(FieldError, []byte("You are not allowed to view drop boxes.")),
 					},
 				},
 			},
@@ -2623,8 +2831,8 @@ func TestHandleGetFileNameList(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranGetFileNameList, &[]byte{0, 1},
-					NewField(fieldFilePath, []byte{
+					TranGetFileNameList, &[]byte{0, 1},
+					NewField(FieldFilePath, []byte{
 						0x00, 0x00,
 						0x00, 0x00,
 					}),
@@ -2634,12 +2842,12 @@ func TestHandleGetFileNameList(t *testing.T) {
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0xc8},
+					Type:      []byte{0, 0},
 					ID:        []byte{0, 0, 0, 0},
 					ErrorCode: []byte{0, 0, 0, 0},
 					Fields: []Field{
 						NewField(
-							fieldFileNameWithInfo,
+							FieldFileNameWithInfo,
 							func() []byte {
 								fnwi := FileNameWithInfo{
 									fileNameWithInfoHeader: fileNameWithInfoHeader{
@@ -2652,7 +2860,7 @@ func TestHandleGetFileNameList(t *testing.T) {
 									},
 									name: []byte("testfile-1k"),
 								}
-								b, _ := fnwi.MarshalBinary()
+								b, _ := io.ReadAll(&fnwi)
 								return b
 							}(),
 						),
@@ -2700,19 +2908,19 @@ func TestHandleGetClientInfoText(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranGetClientInfoText, &[]byte{0, 1},
-					NewField(fieldUserID, []byte{0, 1}),
+					TranGetClientInfoText, &[]byte{0, 1},
+					NewField(FieldUserID, []byte{0, 1}),
 				),
 			},
 			wantRes: []Transaction{
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0x00},
+					Type:      []byte{0, 0},
 					ID:        []byte{0, 0, 0, 0},
 					ErrorCode: []byte{0, 0, 0, 1},
 					Fields: []Field{
-						NewField(fieldError, []byte("You are not allowed to get client info.")),
+						NewField(FieldError, []byte("You are not allowed to get client info.")),
 					},
 				},
 			},
@@ -2759,20 +2967,20 @@ func TestHandleGetClientInfoText(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranGetClientInfoText, &[]byte{0, 1},
-					NewField(fieldUserID, []byte{0, 1}),
+					TranGetClientInfoText, &[]byte{0, 1},
+					NewField(FieldUserID, []byte{0, 1}),
 				),
 			},
 			wantRes: []Transaction{
 				{
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0x1, 0x2f},
+					Type:      []byte{0, 0},
 					ID:        []byte{0, 0, 0, 0},
 					ErrorCode: []byte{0, 0, 0, 0},
 					Fields: []Field{
-						NewField(fieldData, []byte(
-							strings.Replace(`Nickname:   Testy McTest
+						NewField(FieldData, []byte(
+							strings.ReplaceAll(`Nickname:   Testy McTest
 Name:       test
 Account:    test
 Address:    1.2.3.4:12345
@@ -2797,9 +3005,9 @@ None.
 
 None.
 
-`, "\n", "\r", -1)),
+`, "\n", "\r")),
 						),
-						NewField(fieldUserName, []byte("Testy McTest")),
+						NewField(FieldUserName, []byte("Testy McTest")),
 					},
 				},
 			},
@@ -2851,10 +3059,10 @@ func TestHandleTranAgreed(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranAgreed, nil,
-					NewField(fieldUserName, []byte("username")),
-					NewField(fieldUserIconID, []byte{0, 1}),
-					NewField(fieldOptions, []byte{0, 0}),
+					TranAgreed, nil,
+					NewField(FieldUserName, []byte("username")),
+					NewField(FieldUserIconID, []byte{0, 1}),
+					NewField(FieldOptions, []byte{0, 0}),
 				),
 			},
 			wantRes: []Transaction{
@@ -2866,14 +3074,14 @@ func TestHandleTranAgreed(t *testing.T) {
 					ID:        []byte{0, 0, 0, 0},
 					ErrorCode: []byte{0, 0, 0, 0},
 					Fields: []Field{
-						NewField(fieldBannerType, []byte("JPEG")),
+						NewField(FieldBannerType, []byte("JPEG")),
 					},
 				},
 				{
 					clientID:  &[]byte{0, 1},
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0x79},
+					Type:      []byte{0, 0},
 					ID:        []byte{0, 0, 0, 0},
 					ErrorCode: []byte{0, 0, 0, 0},
 					Fields:    []Field{},
@@ -2926,9 +3134,9 @@ func TestHandleSetClientUserInfo(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranSetClientUserInfo, nil,
-					NewField(fieldUserIconID, []byte{0, 1}),
-					NewField(fieldUserName, []byte("NOPE")),
+					TranSetClientUserInfo, nil,
+					NewField(FieldUserIconID, []byte{0, 1}),
+					NewField(FieldUserName, []byte("NOPE")),
 				),
 			},
 			wantRes: []Transaction{
@@ -2940,10 +3148,10 @@ func TestHandleSetClientUserInfo(t *testing.T) {
 					ID:        []byte{0, 0, 0, 0},
 					ErrorCode: []byte{0, 0, 0, 0},
 					Fields: []Field{
-						NewField(fieldUserID, []byte{0, 1}),
-						NewField(fieldUserIconID, []byte{0, 1}),
-						NewField(fieldUserFlags, []byte{0, 1}),
-						NewField(fieldUserName, []byte("Guest"))},
+						NewField(FieldUserID, []byte{0, 1}),
+						NewField(FieldUserIconID, []byte{0, 1}),
+						NewField(FieldUserFlags, []byte{0, 1}),
+						NewField(FieldUserName, []byte("Guest"))},
 				},
 			},
 			wantErr: assert.NoError,
@@ -2983,7 +3191,7 @@ func TestHandleDelNewsItem(t *testing.T) {
 					Server: &Server{
 						ThreadedNews: &ThreadedNews{Categories: map[string]NewsCategoryListData15{
 							"test": {
-								Type:     []byte{0, 3},
+								Type:     [2]byte{0, 3},
 								Count:    nil,
 								NameSize: 0,
 								Name:     "zz",
@@ -2992,8 +3200,8 @@ func TestHandleDelNewsItem(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranDelNewsItem, nil,
-					NewField(fieldNewsPath,
+					TranDelNewsItem, nil,
+					NewField(FieldNewsPath,
 						[]byte{
 							0, 1,
 							0, 0,
@@ -3008,11 +3216,11 @@ func TestHandleDelNewsItem(t *testing.T) {
 					clientID:  &[]byte{0, 1},
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0x00},
+					Type:      []byte{0, 0},
 					ID:        []byte{0, 0, 0, 0},
 					ErrorCode: []byte{0, 0, 0, 1},
 					Fields: []Field{
-						NewField(fieldError, []byte("You are not allowed to delete news categories.")),
+						NewField(FieldError, []byte("You are not allowed to delete news categories.")),
 					},
 				},
 			},
@@ -3029,7 +3237,7 @@ func TestHandleDelNewsItem(t *testing.T) {
 					Server: &Server{
 						ThreadedNews: &ThreadedNews{Categories: map[string]NewsCategoryListData15{
 							"testcat": {
-								Type:     []byte{0, 2},
+								Type:     [2]byte{0, 2},
 								Count:    nil,
 								NameSize: 0,
 								Name:     "test",
@@ -3038,8 +3246,8 @@ func TestHandleDelNewsItem(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranDelNewsItem, nil,
-					NewField(fieldNewsPath,
+					TranDelNewsItem, nil,
+					NewField(FieldNewsPath,
 						[]byte{
 							0, 1,
 							0, 0,
@@ -3054,11 +3262,11 @@ func TestHandleDelNewsItem(t *testing.T) {
 					clientID:  &[]byte{0, 1},
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0, 0x00},
+					Type:      []byte{0, 0},
 					ID:        []byte{0, 0, 0, 0},
 					ErrorCode: []byte{0, 0, 0, 1},
 					Fields: []Field{
-						NewField(fieldError, []byte("You are not allowed to delete news folders.")),
+						NewField(FieldError, []byte("You are not allowed to delete news folders.")),
 					},
 				},
 			},
@@ -3085,7 +3293,7 @@ func TestHandleDelNewsItem(t *testing.T) {
 						}(),
 						ThreadedNews: &ThreadedNews{Categories: map[string]NewsCategoryListData15{
 							"testcat": {
-								Type:     []byte{0, 2},
+								Type:     [2]byte{0, 2},
 								Count:    nil,
 								NameSize: 0,
 								Name:     "test",
@@ -3094,8 +3302,8 @@ func TestHandleDelNewsItem(t *testing.T) {
 					},
 				},
 				t: NewTransaction(
-					tranDelNewsItem, nil,
-					NewField(fieldNewsPath,
+					TranDelNewsItem, nil,
+					NewField(FieldNewsPath,
 						[]byte{
 							0, 1,
 							0, 0,
@@ -3110,7 +3318,7 @@ func TestHandleDelNewsItem(t *testing.T) {
 					clientID:  &[]byte{0, 1},
 					Flags:     0x00,
 					IsReply:   0x01,
-					Type:      []byte{0x01, 0x7c},
+					Type:      []byte{0, 0},
 					ID:        []byte{0, 0, 0, 0},
 					ErrorCode: []byte{0, 0, 0, 0},
 					Fields:    []Field{},
@@ -3129,3 +3337,617 @@ func TestHandleDelNewsItem(t *testing.T) {
 		})
 	}
 }
+
+func TestHandleDownloadBanner(t *testing.T) {
+	type args struct {
+		cc *ClientConn
+		t  *Transaction
+	}
+	tests := []struct {
+		name    string
+		args    args
+		wantRes []Transaction
+		wantErr assert.ErrorAssertionFunc
+	}{
+		{
+			name: "returns expected response",
+			args: args{
+				cc: &ClientConn{
+					ID: &[]byte{0, 1},
+					transfers: map[int]map[[4]byte]*FileTransfer{
+						bannerDownload: {},
+					},
+					Server: &Server{
+						ConfigDir: "/config",
+						Config: &Config{
+							BannerFile: "banner.jpg",
+						},
+						fileTransfers: map[[4]byte]*FileTransfer{},
+						FS: func() *MockFileStore {
+							mfi := &MockFileInfo{}
+							mfi.On("Size").Return(int64(100))
+
+							mfs := &MockFileStore{}
+							mfs.On("Stat", "/config/banner.jpg").Return(mfi, nil)
+							return mfs
+						}(),
+					},
+				},
+				t: NewTransaction(TranDownloadBanner, nil),
+			},
+			wantRes: []Transaction{
+				{
+					clientID:  &[]byte{0, 1},
+					Flags:     0x00,
+					IsReply:   0x01,
+					Type:      []byte{0, 0},
+					ID:        []byte{0, 0, 0, 0},
+					ErrorCode: []byte{0, 0, 0, 0},
+					Fields: []Field{
+						NewField(FieldRefNum, []byte{1, 2, 3, 4}),
+						NewField(FieldTransferSize, []byte{0, 0, 0, 0x64}),
+					},
+				},
+			},
+			wantErr: assert.NoError,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			gotRes, err := HandleDownloadBanner(tt.args.cc, tt.args.t)
+			if !tt.wantErr(t, err, fmt.Sprintf("HandleDownloadBanner(%v, %v)", tt.args.cc, tt.args.t)) {
+				return
+			}
+
+			tranAssertEqual(t, tt.wantRes, gotRes)
+		})
+	}
+}
+
+func TestHandleTranOldPostNews(t *testing.T) {
+	type args struct {
+		cc *ClientConn
+		t  *Transaction
+	}
+	tests := []struct {
+		name    string
+		args    args
+		wantRes []Transaction
+		wantErr assert.ErrorAssertionFunc
+	}{
+		{
+			name: "when user does not have required permission",
+			args: args{
+				cc: &ClientConn{
+					Account: &Account{
+						Access: func() accessBitmap {
+							var bits accessBitmap
+							return bits
+						}(),
+					},
+				},
+				t: NewTransaction(
+					TranOldPostNews, &[]byte{0, 1},
+					NewField(FieldData, []byte("hai")),
+				),
+			},
+			wantRes: []Transaction{
+				{
+					Flags:     0x00,
+					IsReply:   0x01,
+					Type:      []byte{0, 0},
+					ID:        []byte{0, 0, 0, 0},
+					ErrorCode: []byte{0, 0, 0, 1},
+					Fields: []Field{
+						NewField(FieldError, []byte("You are not allowed to post news.")),
+					},
+				},
+			},
+			wantErr: assert.NoError,
+		},
+		{
+			name: "when user posts news update",
+			args: args{
+				cc: &ClientConn{
+					Account: &Account{
+						Access: func() accessBitmap {
+							var bits accessBitmap
+							bits.Set(accessNewsPostArt)
+							return bits
+						}(),
+					},
+					Server: &Server{
+						FS: func() *MockFileStore {
+							mfs := &MockFileStore{}
+							mfs.On("WriteFile", "/fakeConfigRoot/MessageBoard.txt", mock.Anything, mock.Anything).Return(nil, os.ErrNotExist)
+							return mfs
+						}(),
+						ConfigDir: "/fakeConfigRoot",
+						Config:    &Config{},
+					},
+				},
+				t: NewTransaction(
+					TranOldPostNews, &[]byte{0, 1},
+					NewField(FieldData, []byte("hai")),
+				),
+			},
+			wantRes: []Transaction{
+				{
+					Flags:     0x00,
+					IsReply:   0x01,
+					Type:      []byte{0, 0},
+					ID:        []byte{0, 0, 0, 0},
+					ErrorCode: []byte{0, 0, 0, 0},
+				},
+			},
+			wantErr: assert.NoError,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			gotRes, err := HandleTranOldPostNews(tt.args.cc, tt.args.t)
+			if !tt.wantErr(t, err, fmt.Sprintf("HandleTranOldPostNews(%v, %v)", tt.args.cc, tt.args.t)) {
+				return
+			}
+
+			tranAssertEqual(t, tt.wantRes, gotRes)
+		})
+	}
+}
+
+func TestHandleInviteNewChat(t *testing.T) {
+	type args struct {
+		cc *ClientConn
+		t  *Transaction
+	}
+	tests := []struct {
+		name    string
+		args    args
+		wantRes []Transaction
+		wantErr assert.ErrorAssertionFunc
+	}{
+		{
+			name: "when user does not have required permission",
+			args: args{
+				cc: &ClientConn{
+					Account: &Account{
+						Access: func() accessBitmap {
+							var bits accessBitmap
+							return bits
+						}(),
+					},
+				},
+				t: NewTransaction(TranInviteNewChat, &[]byte{0, 1}),
+			},
+			wantRes: []Transaction{
+				{
+					Flags:     0x00,
+					IsReply:   0x01,
+					Type:      []byte{0, 0},
+					ID:        []byte{0, 0, 0, 0},
+					ErrorCode: []byte{0, 0, 0, 1},
+					Fields: []Field{
+						NewField(FieldError, []byte("You are not allowed to request private chat.")),
+					},
+				},
+			},
+			wantErr: assert.NoError,
+		},
+		{
+			name: "when userA invites userB to new private chat",
+			args: args{
+				cc: &ClientConn{
+					ID: &[]byte{0, 1},
+					Account: &Account{
+						Access: func() accessBitmap {
+							var bits accessBitmap
+							bits.Set(accessOpenChat)
+							return bits
+						}(),
+					},
+					UserName: []byte("UserA"),
+					Icon:     []byte{0, 1},
+					Flags:    []byte{0, 0},
+					Server: &Server{
+						Clients: map[uint16]*ClientConn{
+							uint16(2): {
+								ID:       &[]byte{0, 2},
+								UserName: []byte("UserB"),
+								Flags:    []byte{0, 0},
+							},
+						},
+						PrivateChats: make(map[uint32]*PrivateChat),
+					},
+				},
+				t: NewTransaction(
+					TranInviteNewChat, &[]byte{0, 1},
+					NewField(FieldUserID, []byte{0, 2}),
+				),
+			},
+			wantRes: []Transaction{
+				{
+					clientID:  &[]byte{0, 2},
+					Flags:     0x00,
+					IsReply:   0x00,
+					Type:      []byte{0, 0x71},
+					ID:        []byte{0, 0, 0, 0},
+					ErrorCode: []byte{0, 0, 0, 0},
+					Fields: []Field{
+						NewField(FieldChatID, []byte{0x52, 0xfd, 0xfc, 0x07}),
+						NewField(FieldUserName, []byte("UserA")),
+						NewField(FieldUserID, []byte{0, 1}),
+					},
+				},
+
+				{
+					clientID:  &[]byte{0, 1},
+					Flags:     0x00,
+					IsReply:   0x01,
+					Type:      []byte{0, 0},
+					ID:        []byte{0, 0, 0, 0},
+					ErrorCode: []byte{0, 0, 0, 0},
+					Fields: []Field{
+						NewField(FieldChatID, []byte{0x52, 0xfd, 0xfc, 0x07}),
+						NewField(FieldUserName, []byte("UserA")),
+						NewField(FieldUserID, []byte{0, 1}),
+						NewField(FieldUserIconID, []byte{0, 1}),
+						NewField(FieldUserFlags, []byte{0, 0}),
+					},
+				},
+			},
+			wantErr: assert.NoError,
+		},
+		{
+			name: "when userA invites userB to new private chat, but UserB has refuse private chat enabled",
+			args: args{
+				cc: &ClientConn{
+					ID: &[]byte{0, 1},
+					Account: &Account{
+						Access: func() accessBitmap {
+							var bits accessBitmap
+							bits.Set(accessOpenChat)
+							return bits
+						}(),
+					},
+					UserName: []byte("UserA"),
+					Icon:     []byte{0, 1},
+					Flags:    []byte{0, 0},
+					Server: &Server{
+						Clients: map[uint16]*ClientConn{
+							uint16(2): {
+								ID:       &[]byte{0, 2},
+								UserName: []byte("UserB"),
+								Flags:    []byte{255, 255},
+							},
+						},
+						PrivateChats: make(map[uint32]*PrivateChat),
+					},
+				},
+				t: NewTransaction(
+					TranInviteNewChat, &[]byte{0, 1},
+					NewField(FieldUserID, []byte{0, 2}),
+				),
+			},
+			wantRes: []Transaction{
+				{
+					clientID:  &[]byte{0, 1},
+					Flags:     0x00,
+					IsReply:   0x00,
+					Type:      []byte{0, 0x68},
+					ID:        []byte{0, 0, 0, 0},
+					ErrorCode: []byte{0, 0, 0, 0},
+					Fields: []Field{
+						NewField(FieldData, []byte("UserB does not accept private chats.")),
+						NewField(FieldUserName, []byte("UserB")),
+						NewField(FieldUserID, []byte{0, 2}),
+						NewField(FieldOptions, []byte{0, 2}),
+					},
+				},
+				{
+					clientID:  &[]byte{0, 1},
+					Flags:     0x00,
+					IsReply:   0x01,
+					Type:      []byte{0, 0},
+					ID:        []byte{0, 0, 0, 0},
+					ErrorCode: []byte{0, 0, 0, 0},
+					Fields: []Field{
+						NewField(FieldChatID, []byte{0x52, 0xfd, 0xfc, 0x07}),
+						NewField(FieldUserName, []byte("UserA")),
+						NewField(FieldUserID, []byte{0, 1}),
+						NewField(FieldUserIconID, []byte{0, 1}),
+						NewField(FieldUserFlags, []byte{0, 0}),
+					},
+				},
+			},
+			wantErr: assert.NoError,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			rand.Seed(1)
+			gotRes, err := HandleInviteNewChat(tt.args.cc, tt.args.t)
+			if !tt.wantErr(t, err, fmt.Sprintf("HandleInviteNewChat(%v, %v)", tt.args.cc, tt.args.t)) {
+				return
+			}
+			tranAssertEqual(t, tt.wantRes, gotRes)
+		})
+	}
+}
+
+func TestHandleGetNewsArtData(t *testing.T) {
+	type args struct {
+		cc *ClientConn
+		t  *Transaction
+	}
+	tests := []struct {
+		name    string
+		args    args
+		wantRes []Transaction
+		wantErr assert.ErrorAssertionFunc
+	}{
+		{
+			name: "when user does not have required permission",
+			args: args{
+				cc: &ClientConn{
+					Account: &Account{
+						Access: func() accessBitmap {
+							var bits accessBitmap
+							return bits
+						}(),
+					},
+					Server: &Server{
+						Accounts: map[string]*Account{},
+					},
+				},
+				t: NewTransaction(
+					TranGetNewsArtData, &[]byte{0, 1},
+				),
+			},
+			wantRes: []Transaction{
+				{
+					Flags:     0x00,
+					IsReply:   0x01,
+					Type:      []byte{0, 0},
+					ID:        []byte{0x9a, 0xcb, 0x04, 0x42},
+					ErrorCode: []byte{0, 0, 0, 1},
+					Fields: []Field{
+						NewField(FieldError, []byte("You are not allowed to read news.")),
+					},
+				},
+			},
+			wantErr: assert.NoError,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			gotRes, err := HandleGetNewsArtData(tt.args.cc, tt.args.t)
+			if !tt.wantErr(t, err, fmt.Sprintf("HandleGetNewsArtData(%v, %v)", tt.args.cc, tt.args.t)) {
+				return
+			}
+			tranAssertEqual(t, tt.wantRes, gotRes)
+		})
+	}
+}
+
+func TestHandleGetNewsArtNameList(t *testing.T) {
+	type args struct {
+		cc *ClientConn
+		t  *Transaction
+	}
+	tests := []struct {
+		name    string
+		args    args
+		wantRes []Transaction
+		wantErr assert.ErrorAssertionFunc
+	}{
+		{
+			name: "when user does not have required permission",
+			args: args{
+				cc: &ClientConn{
+					Account: &Account{
+						Access: func() accessBitmap {
+							var bits accessBitmap
+							return bits
+						}(),
+					},
+					Server: &Server{
+						Accounts: map[string]*Account{},
+					},
+				},
+				t: NewTransaction(
+					TranGetNewsArtNameList, &[]byte{0, 1},
+				),
+			},
+			wantRes: []Transaction{
+				{
+					Flags:     0x00,
+					IsReply:   0x01,
+					Type:      []byte{0, 0},
+					ErrorCode: []byte{0, 0, 0, 1},
+					Fields: []Field{
+						NewField(FieldError, []byte("You are not allowed to read news.")),
+					},
+				},
+			},
+			wantErr: assert.NoError,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			gotRes, err := HandleGetNewsArtNameList(tt.args.cc, tt.args.t)
+			if !tt.wantErr(t, err, fmt.Sprintf("HandleGetNewsArtNameList(%v, %v)", tt.args.cc, tt.args.t)) {
+				return
+			}
+			tranAssertEqual(t, tt.wantRes, gotRes)
+		})
+	}
+}
+
+func TestHandleNewNewsFldr(t *testing.T) {
+	type args struct {
+		cc *ClientConn
+		t  *Transaction
+	}
+	tests := []struct {
+		name    string
+		args    args
+		wantRes []Transaction
+		wantErr assert.ErrorAssertionFunc
+	}{
+		{
+			name: "when user does not have required permission",
+			args: args{
+				cc: &ClientConn{
+					Account: &Account{
+						Access: func() accessBitmap {
+							var bits accessBitmap
+							return bits
+						}(),
+					},
+					Server: &Server{
+						Accounts: map[string]*Account{},
+					},
+				},
+				t: NewTransaction(
+					TranGetNewsArtNameList, &[]byte{0, 1},
+				),
+			},
+			wantRes: []Transaction{
+				{
+					Flags:     0x00,
+					IsReply:   0x01,
+					Type:      []byte{0, 0},
+					ErrorCode: []byte{0, 0, 0, 1},
+					Fields: []Field{
+						NewField(FieldError, []byte("You are not allowed to create news folders.")),
+					},
+				},
+			},
+			wantErr: assert.NoError,
+		},
+		{
+			name: "with a valid request",
+			args: args{
+				cc: &ClientConn{
+					Account: &Account{
+						Access: func() accessBitmap {
+							var bits accessBitmap
+							bits.Set(accessNewsCreateFldr)
+							return bits
+						}(),
+					},
+					logger: NewTestLogger(),
+					ID:     &[]byte{0, 1},
+					Server: &Server{
+						ConfigDir: "/fakeConfigRoot",
+						FS: func() *MockFileStore {
+							mfs := &MockFileStore{}
+							mfs.On("WriteFile", "/fakeConfigRoot/ThreadedNews.yaml", mock.Anything, mock.Anything).Return(nil)
+							return mfs
+						}(),
+						ThreadedNews: &ThreadedNews{Categories: map[string]NewsCategoryListData15{
+							"test": {
+								Type:     [2]byte{0, 2},
+								Count:    nil,
+								NameSize: 0,
+								Name:     "test",
+								SubCats:  make(map[string]NewsCategoryListData15),
+							},
+						}},
+					},
+				},
+				t: NewTransaction(
+					TranGetNewsArtNameList, &[]byte{0, 1},
+					NewField(FieldFileName, []byte("testFolder")),
+					NewField(FieldNewsPath,
+						[]byte{
+							0, 1,
+							0, 0,
+							4,
+							0x74, 0x65, 0x73, 0x74,
+						},
+					),
+				),
+			},
+			wantRes: []Transaction{
+				{
+					clientID:  &[]byte{0, 1},
+					Flags:     0x00,
+					IsReply:   0x01,
+					Type:      []byte{0, 0},
+					ID:        []byte{0, 0, 0, 0},
+					ErrorCode: []byte{0, 0, 0, 0},
+					Fields:    []Field{},
+				},
+			},
+			wantErr: assert.NoError,
+		},
+		//{
+		//	name: "when there is an error writing the threaded news file",
+		//	args: args{
+		//		cc: &ClientConn{
+		//			Account: &Account{
+		//				Access: func() accessBitmap {
+		//					var bits accessBitmap
+		//					bits.Set(accessNewsCreateFldr)
+		//					return bits
+		//				}(),
+		//			},
+		//			logger: NewTestLogger(),
+		//			ID:     &[]byte{0, 1},
+		//			Server: &Server{
+		//				ConfigDir: "/fakeConfigRoot",
+		//				FS: func() *MockFileStore {
+		//					mfs := &MockFileStore{}
+		//					mfs.On("WriteFile", "/fakeConfigRoot/ThreadedNews.yaml", mock.Anything, mock.Anything).Return(os.ErrNotExist)
+		//					return mfs
+		//				}(),
+		//				ThreadedNews: &ThreadedNews{Categories: map[string]NewsCategoryListData15{
+		//					"test": {
+		//						Type:     []byte{0, 2},
+		//						Count:    nil,
+		//						NameSize: 0,
+		//						Name:     "test",
+		//						SubCats:  make(map[string]NewsCategoryListData15),
+		//					},
+		//				}},
+		//			},
+		//		},
+		//		t: NewTransaction(
+		//			TranGetNewsArtNameList, &[]byte{0, 1},
+		//			NewField(FieldFileName, []byte("testFolder")),
+		//			NewField(FieldNewsPath,
+		//				[]byte{
+		//					0, 1,
+		//					0, 0,
+		//					4,
+		//					0x74, 0x65, 0x73, 0x74,
+		//				},
+		//			),
+		//		),
+		//	},
+		//	wantRes: []Transaction{
+		//		{
+		//			clientID:  &[]byte{0, 1},
+		//			Flags:     0x00,
+		//			IsReply:   0x01,
+		//			Type:      []byte{0, 0},
+		//			ErrorCode: []byte{0, 0, 0, 1},
+		//			Fields: []Field{
+		//				NewField(FieldError, []byte("Error creating news folder.")),
+		//			},
+		//		},
+		//	},
+		//	wantErr: assert.Error,
+		// },
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			gotRes, err := HandleNewNewsFldr(tt.args.cc, tt.args.t)
+			if !tt.wantErr(t, err, fmt.Sprintf("HandleNewNewsFldr(%v, %v)", tt.args.cc, tt.args.t)) {
+				return
+			}
+			tranAssertEqual(t, tt.wantRes, gotRes)
+		})
+	}
+}