X-Git-Url: https://git.r.bdr.sh/rbdr/mobius/blobdiff_plain/76d0c1f61d5981603389e6267bf62636f34bef1f..5954ccad9c87063231f3a8bb3e5d01675a9865ca:/hotline/user.go?ds=inline

diff --git a/hotline/user.go b/hotline/user.go
index 5b1b705..02deb31 100644
--- a/hotline/user.go
+++ b/hotline/user.go
@@ -2,21 +2,23 @@ package hotline
 
 import (
 	"encoding/binary"
+	"io"
+	"slices"
 )
 
 // User flags are stored as a 2 byte bitmap and represent various user states
 const (
-	UserFlagAway        = 0 // User is away
-	UserFlagAdmin       = 1 // User is admin
-	UserFlagRefusePM    = 2 // User refuses private messages
-	UserFlagRefusePChat = 3 // User refuses private chat
+	UserFlagAway        = iota // User is away
+	UserFlagAdmin              // User is admin
+	UserFlagRefusePM           // User refuses private messages
+	UserFlagRefusePChat        // User refuses private chat
 )
 
 // FieldOptions flags are sent from v1.5+ clients as part of TranAgreed
 const (
-	refusePM     = 0 // User has "Refuse private messages" pref set
-	refuseChat   = 1 // User has "Refuse private chat" pref set
-	autoResponse = 2 // User has "Automatic response" pref set
+	UserOptRefusePM     = iota // User has "Refuse private messages" pref set
+	UserOptRefuseChat          // User has "Refuse private chat" pref set
+	UserOptAutoResponse        // User has "Automatic response" pref set
 )
 
 type User struct {
@@ -24,9 +26,11 @@ type User struct {
 	Icon  []byte // Size 2
 	Flags []byte // Size 2
 	Name  string // Variable length user name
+
+	readOffset int // Internal offset to track read progress
 }
 
-func (u User) Payload() []byte {
+func (u *User) Read(p []byte) (int, error) {
 	nameLen := make([]byte, 2)
 	binary.BigEndian.PutUint16(nameLen, uint16(len(u.Name)))
 
@@ -38,31 +42,31 @@ func (u User) Payload() []byte {
 		u.Flags = u.Flags[2:]
 	}
 
-	out := append(u.ID[:2], u.Icon[:2]...)
-	out = append(out, u.Flags[:2]...)
-	out = append(out, nameLen...)
-	out = append(out, u.Name...)
-
-	return out
-}
+	b := slices.Concat(
+		u.ID,
+		u.Icon,
+		u.Flags,
+		nameLen,
+		[]byte(u.Name),
+	)
 
-func ReadUser(b []byte) (*User, error) {
-	u := &User{
-		ID:    b[0:2],
-		Icon:  b[2:4],
-		Flags: b[4:6],
-		Name:  string(b[8:]),
+	if u.readOffset >= len(b) {
+		return 0, io.EOF // All bytes have been read
 	}
-	return u, nil
+
+	n := copy(p, b)
+
+	return n, io.EOF
 }
 
-// decodeString decodes an obfuscated user string from a client
-// e.g. 98 8a 9a 8c 8b => "guest"
-func decodeString(obfuText []byte) (clearText string) {
-	for _, char := range obfuText {
-		clearText += string(rune(255 - uint(char)))
-	}
-	return clearText
+func (u *User) Write(p []byte) (int, error) {
+	namelen := int(binary.BigEndian.Uint16(p[6:8]))
+	u.ID = p[0:2]
+	u.Icon = p[2:4]
+	u.Flags = p[4:6]
+	u.Name = string(p[8 : 8+namelen])
+
+	return 8 + namelen, nil
 }
 
 // encodeString takes []byte s containing cleartext and rotates by 255 into obfuscated cleartext.