X-Git-Url: https://git.r.bdr.sh/rbdr/mobius/blobdiff_plain/72dd37f1abb2b550aaaac48eac677403d5664797..6610ee2030baa99e6129c7b06588d33038dde671:/hotline/news_test.go?ds=sidebyside

diff --git a/hotline/news_test.go b/hotline/news_test.go
index 02e11a9..588c979 100644
--- a/hotline/news_test.go
+++ b/hotline/news_test.go
@@ -1,21 +1,72 @@
 package hotline
 
 import (
-	"bytes"
-	"reflect"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/mock"
+	"io"
 	"testing"
 )
 
+type mockThreadNewsMgr struct {
+	mock.Mock
+}
+
+func (m *mockThreadNewsMgr) ListArticles(newsPath []string) NewsArtListData {
+	args := m.Called(newsPath)
+
+	return args.Get(0).(NewsArtListData)
+}
+
+func (m *mockThreadNewsMgr) GetArticle(newsPath []string, articleID uint32) *NewsArtData {
+	args := m.Called(newsPath, articleID)
+
+	return args.Get(0).(*NewsArtData)
+}
+func (m *mockThreadNewsMgr) DeleteArticle(newsPath []string, articleID uint32, recursive bool) error {
+	args := m.Called(newsPath, articleID, recursive)
+
+	return args.Error(0)
+}
+
+func (m *mockThreadNewsMgr) PostArticle(newsPath []string, parentArticleID uint32, article NewsArtData) error {
+	args := m.Called(newsPath, parentArticleID, article)
+
+	return args.Error(0)
+}
+func (m *mockThreadNewsMgr) CreateGrouping(newsPath []string, name string, itemType [2]byte) error {
+	args := m.Called(newsPath, name, itemType)
+
+	return args.Error(0)
+}
+
+func (m *mockThreadNewsMgr) GetCategories(paths []string) []NewsCategoryListData15 {
+	args := m.Called(paths)
+
+	return args.Get(0).([]NewsCategoryListData15)
+}
+
+func (m *mockThreadNewsMgr) NewsItem(newsPath []string) NewsCategoryListData15 {
+	args := m.Called(newsPath)
+
+	return args.Get(0).(NewsCategoryListData15)
+}
+
+func (m *mockThreadNewsMgr) DeleteNewsItem(newsPath []string) error {
+	args := m.Called(newsPath)
+
+	return args.Error(0)
+}
+
 func TestNewsCategoryListData15_MarshalBinary(t *testing.T) {
 	type fields struct {
-		Type     []byte
+		Type     [2]byte
 		Name     string
 		Articles map[uint32]*NewsArtData
 		SubCats  map[string]NewsCategoryListData15
 		Count    []byte
-		AddSN    []byte
-		DeleteSN []byte
-		GUID     []byte
+		AddSN    [4]byte
+		DeleteSN [4]byte
+		GUID     [16]byte
 	}
 	tests := []struct {
 		name     string
@@ -26,7 +77,7 @@ func TestNewsCategoryListData15_MarshalBinary(t *testing.T) {
 		{
 			name: "returns expected bytes when type is a bundle",
 			fields: fields{
-				Type: []byte{0x00, 0x02},
+				Type: [2]byte{0x00, 0x02},
 				Articles: map[uint32]*NewsArtData{
 					uint32(1): {
 						Title:  "",
@@ -47,7 +98,7 @@ func TestNewsCategoryListData15_MarshalBinary(t *testing.T) {
 		{
 			name: "returns expected bytes when type is a category",
 			fields: fields{
-				Type: []byte{0x00, 0x03},
+				Type: [2]byte{0x00, 0x03},
 				Articles: map[uint32]*NewsArtData{
 					uint32(1): {
 						Title:  "",
@@ -61,8 +112,8 @@ func TestNewsCategoryListData15_MarshalBinary(t *testing.T) {
 				0x00, 0x03,
 				0x00, 0x01,
 				0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
-				0x00, 0x00, 0x00, 0x01,
-				0x00, 0x00, 0x00, 0x02,
+				0x00, 0x00, 0x00, 0x00,
+				0x00, 0x00, 0x00, 0x00,
 				0x03,
 				0x66, 0x6f, 0x6f,
 			},
@@ -76,13 +127,12 @@ func TestNewsCategoryListData15_MarshalBinary(t *testing.T) {
 				Name:     tt.fields.Name,
 				Articles: tt.fields.Articles,
 				SubCats:  tt.fields.SubCats,
-				Count:    tt.fields.Count,
 				AddSN:    tt.fields.AddSN,
 				DeleteSN: tt.fields.DeleteSN,
 				GUID:     tt.fields.GUID,
 			}
-			gotData, err := newscat.MarshalBinary()
-			if bytes.Equal(newscat.Type, []byte{0, 3}) {
+			gotData, err := io.ReadAll(newscat)
+			if newscat.Type == [2]byte{0, 3} {
 				// zero out the random GUID before comparison
 				for i := 4; i < 20; i++ {
 					gotData[i] = 0
@@ -92,7 +142,7 @@ func TestNewsCategoryListData15_MarshalBinary(t *testing.T) {
 				t.Errorf("MarshalBinary() error = %v, wantErr %v", err, tt.wantErr)
 				return
 			}
-			if !reflect.DeepEqual(gotData, tt.wantData) {
+			if !assert.Equal(t, tt.wantData, gotData) {
 				t.Errorf("MarshalBinary() gotData = %v, want %v", gotData, tt.wantData)
 			}
 		})