X-Git-Url: https://git.r.bdr.sh/rbdr/mobius/blobdiff_plain/6699cff21c226aa900ed3517c0f7ef3d50cefc17..8cd28eb8cede1c6888cbbcd319a9617304bfc4c1:/hotline/user.go?ds=inline

diff --git a/hotline/user.go b/hotline/user.go
index e64bf84..c4e0790 100644
--- a/hotline/user.go
+++ b/hotline/user.go
@@ -3,6 +3,7 @@ package hotline
 import (
 	"encoding/binary"
 	"io"
+	"math/big"
 	"slices"
 )
 
@@ -14,18 +15,33 @@ const (
 	UserFlagRefusePChat = 3 // User refuses private chat
 )
 
-// FieldOptions flags are sent from v1.5+ clients as part of TranAgreed
+// User options are sent from clients and represent options set in the client's preferences.
 const (
-	refusePM     = 0 // User has "Refuse private messages" pref set
-	refuseChat   = 1 // User has "Refuse private chat" pref set
-	autoResponse = 2 // User has "Automatic response" pref set
+	UserOptRefusePM     = 0 // User has "Refuse private messages" pref set
+	UserOptRefuseChat   = 1 // User has "Refuse private chat" pref set
+	UserOptAutoResponse = 2 // User has "Automatic response" pref set
 )
 
+type UserFlags [2]byte
+
+func (f *UserFlags) IsSet(i int) bool {
+	flagBitmap := big.NewInt(int64(binary.BigEndian.Uint16(f[:])))
+	return flagBitmap.Bit(i) == 1
+}
+
+func (f *UserFlags) Set(i int, newVal uint) {
+	flagBitmap := big.NewInt(int64(binary.BigEndian.Uint16(f[:])))
+	flagBitmap.SetBit(flagBitmap, i, newVal)
+	binary.BigEndian.PutUint16(f[:], uint16(flagBitmap.Int64()))
+}
+
 type User struct {
-	ID    []byte // Size 2
+	ID    [2]byte
 	Icon  []byte // Size 2
 	Flags []byte // Size 2
 	Name  string // Variable length user name
+
+	readOffset int // Internal offset to track read progress
 }
 
 func (u *User) Read(p []byte) (int, error) {
@@ -40,23 +56,27 @@ func (u *User) Read(p []byte) (int, error) {
 		u.Flags = u.Flags[2:]
 	}
 
-	out := append(u.ID[:2], u.Icon[:2]...)
-	out = append(out, u.Flags[:2]...)
-	out = append(out, nameLen...)
-	out = append(out, u.Name...)
-
-	return copy(p, slices.Concat(
-		u.ID,
+	b := slices.Concat(
+		u.ID[:],
 		u.Icon,
 		u.Flags,
 		nameLen,
 		[]byte(u.Name),
-	)), io.EOF
+	)
+
+	if u.readOffset >= len(b) {
+		return 0, io.EOF // All bytes have been read
+	}
+
+	n := copy(p, b)
+	u.readOffset = n
+
+	return n, nil
 }
 
 func (u *User) Write(p []byte) (int, error) {
 	namelen := int(binary.BigEndian.Uint16(p[6:8]))
-	u.ID = p[0:2]
+	u.ID = [2]byte(p[0:2])
 	u.Icon = p[2:4]
 	u.Flags = p[4:6]
 	u.Name = string(p[8 : 8+namelen])
@@ -64,10 +84,10 @@ func (u *User) Write(p []byte) (int, error) {
 	return 8 + namelen, nil
 }
 
-// encodeString takes []byte s containing cleartext and rotates by 255 into obfuscated cleartext.
+// EncodeString takes []byte s containing cleartext and rotates by 255 into obfuscated cleartext.
 // The Hotline protocol uses this format for sending passwords over network.
 // Not secure, but hey, it was the 90s!
-func encodeString(clearText []byte) []byte {
+func EncodeString(clearText []byte) []byte {
 	obfuText := make([]byte, len(clearText))
 	for i := 0; i < len(clearText); i++ {
 		obfuText[i] = 255 - clearText[i]