X-Git-Url: https://git.r.bdr.sh/rbdr/mobius/blobdiff_plain/5c34f8752938764668d829fb284626b9c62c5475..439712cc40865d6e3a42386393a64737f2b77c50:/hotline/transaction_test.go diff --git a/hotline/transaction_test.go b/hotline/transaction_test.go index 4c7d372..4b4f183 100644 --- a/hotline/transaction_test.go +++ b/hotline/transaction_test.go @@ -1,6 +1,7 @@ package hotline import ( + "fmt" "github.com/stretchr/testify/assert" "testing" ) @@ -110,7 +111,195 @@ func TestReadFields(t *testing.T) { } } -func TestReadTransaction(t *testing.T) { +func Test_transactionScanner(t *testing.T) { + type args struct { + data []byte + in1 bool + } + tests := []struct { + name string + args args + wantAdvance int + wantToken []byte + wantErr assert.ErrorAssertionFunc + }{ + { + name: "when too few bytes are provided to read the transaction size", + args: args{ + data: []byte{}, + in1: false, + }, + wantAdvance: 0, + wantToken: []byte(nil), + wantErr: assert.NoError, + }, + { + name: "when too few bytes are provided to read the full payload", + args: args{ + data: []byte{ + 0, + 1, + 0, 0, + 0, 00, 00, 04, + 00, 00, 00, 00, + 00, 00, 00, 10, + 00, 00, 00, 10, + }, + in1: false, + }, + wantAdvance: 0, + wantToken: []byte(nil), + wantErr: assert.NoError, + }, + { + name: "when a full transaction is provided", + args: args{ + data: []byte{ + 0, + 1, + 0, 0, + 0, 00, 00, 0x04, + 00, 00, 00, 0x00, + 00, 00, 00, 0x10, + 00, 00, 00, 0x10, + 00, 02, + 00, 0x6c, // 108 - fieldTransferSize + 00, 02, + 0x63, 0x3b, + 00, 0x6b, // 107 = fieldRefNum + 00, 0x04, + 00, 0x02, 0x93, 0x47, + }, + in1: false, + }, + wantAdvance: 36, + wantToken: []byte{ + 0, + 1, + 0, 0, + 0, 00, 00, 0x04, + 00, 00, 00, 0x00, + 00, 00, 00, 0x10, + 00, 00, 00, 0x10, + 00, 02, + 00, 0x6c, // 108 - fieldTransferSize + 00, 02, + 0x63, 0x3b, + 00, 0x6b, // 107 = fieldRefNum + 00, 0x04, + 00, 0x02, 0x93, 0x47, + }, + wantErr: assert.NoError, + }, + { + name: "when a full transaction plus extra bytes are provided", + args: args{ + data: []byte{ + 0, + 1, + 0, 0, + 0, 00, 00, 0x04, + 00, 00, 00, 0x00, + 00, 00, 00, 0x10, + 00, 00, 00, 0x10, + 00, 02, + 00, 0x6c, // 108 - fieldTransferSize + 00, 02, + 0x63, 0x3b, + 00, 0x6b, // 107 = fieldRefNum + 00, 0x04, + 00, 0x02, 0x93, 0x47, + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, + }, + in1: false, + }, + wantAdvance: 36, + wantToken: []byte{ + 0, + 1, + 0, 0, + 0, 00, 00, 0x04, + 00, 00, 00, 0x00, + 00, 00, 00, 0x10, + 00, 00, 00, 0x10, + 00, 02, + 00, 0x6c, // 108 - fieldTransferSize + 00, 02, + 0x63, 0x3b, + 00, 0x6b, // 107 = fieldRefNum + 00, 0x04, + 00, 0x02, 0x93, 0x47, + }, + wantErr: assert.NoError, + }, + { + name: "when two full transactions are provided", + args: args{ + data: []byte{ + 0, + 1, + 0, 0, + 0, 00, 00, 0x04, + 00, 00, 00, 0x00, + 00, 00, 00, 0x10, + 00, 00, 00, 0x10, + 00, 02, + 00, 0x6c, // 108 - fieldTransferSize + 00, 02, + 0x63, 0x3b, + 00, 0x6b, // 107 = fieldRefNum + 00, 0x04, + 00, 0x02, 0x93, 0x47, + 0, + 1, + 0, 0, + 0, 00, 00, 0x04, + 00, 00, 00, 0x00, + 00, 00, 00, 0x10, + 00, 00, 00, 0x10, + 00, 02, + 00, 0x6c, // 108 - fieldTransferSize + 00, 02, + 0x63, 0x3b, + 00, 0x6b, // 107 = fieldRefNum + 00, 0x04, + 00, 0x02, 0x93, 0x47, + }, + in1: false, + }, + wantAdvance: 36, + wantToken: []byte{ + 0, + 1, + 0, 0, + 0, 00, 00, 0x04, + 00, 00, 00, 0x00, + 00, 00, 00, 0x10, + 00, 00, 00, 0x10, + 00, 02, + 00, 0x6c, // 108 - fieldTransferSize + 00, 02, + 0x63, 0x3b, + 00, 0x6b, // 107 = fieldRefNum + 00, 0x04, + 00, 0x02, 0x93, 0x47, + }, + wantErr: assert.NoError, + }, + } + for _, tt := range tests { + t.Run(tt.name, func(t *testing.T) { + gotAdvance, gotToken, err := transactionScanner(tt.args.data, tt.args.in1) + if !tt.wantErr(t, err, fmt.Sprintf("transactionScanner(%v, %v)", tt.args.data, tt.args.in1)) { + return + } + assert.Equalf(t, tt.wantAdvance, gotAdvance, "transactionScanner(%v, %v)", tt.args.data, tt.args.in1) + assert.Equalf(t, tt.wantToken, gotToken, "transactionScanner(%v, %v)", tt.args.data, tt.args.in1) + }) + } +} + +func TestTransaction_Write(t1 *testing.T) { sampleTransaction := &Transaction{ Flags: byte(0), IsReply: byte(0), @@ -129,48 +318,60 @@ func TestReadTransaction(t *testing.T) { }, } + type fields struct { + clientID *[]byte + Flags byte + IsReply byte + Type []byte + ID []byte + ErrorCode []byte + TotalSize []byte + DataSize []byte + ParamCount []byte + Fields []Field + } type args struct { - buf []byte + p []byte } tests := []struct { name string + fields fields args args - want *Transaction - want1 int - wantErr bool + wantN int + wantErr assert.ErrorAssertionFunc }{ { - name: "when buf contains all bytes for a single transaction", + name: "when buf contains all bytes for a single transaction", + fields: fields{}, args: args{ - buf: sampleTransaction.Payload(), + p: func() []byte { + b, _ := sampleTransaction.MarshalBinary() + return b + }(), }, - want: sampleTransaction, - want1: len(sampleTransaction.Payload()), - wantErr: false, - }, - { - name: "when len(buf) is less than the length of the transaction", - args: args{ - buf: sampleTransaction.Payload()[:len(sampleTransaction.Payload())-1], - }, - want: nil, - want1: 0, - wantErr: true, + wantN: 28, + wantErr: assert.NoError, }, } for _, tt := range tests { - t.Run(tt.name, func(t *testing.T) { - got, got1, err := ReadTransaction(tt.args.buf) - if (err != nil) != tt.wantErr { - t.Errorf("ReadTransaction() error = %v, wantErr %v", err, tt.wantErr) - return + t1.Run(tt.name, func(t1 *testing.T) { + t := &Transaction{ + clientID: tt.fields.clientID, + Flags: tt.fields.Flags, + IsReply: tt.fields.IsReply, + Type: tt.fields.Type, + ID: tt.fields.ID, + ErrorCode: tt.fields.ErrorCode, + TotalSize: tt.fields.TotalSize, + DataSize: tt.fields.DataSize, + ParamCount: tt.fields.ParamCount, + Fields: tt.fields.Fields, } - if !assert.Equal(t, tt.want, got) { - t.Errorf("ReadTransaction() got = %v, want %v", got, tt.want) - } - if got1 != tt.want1 { - t.Errorf("ReadTransaction() got1 = %v, want %v", got1, tt.want1) + gotN, err := t.Write(tt.args.p) + if !tt.wantErr(t1, err, fmt.Sprintf("Write(%v)", tt.args.p)) { + return } + assert.Equalf(t1, tt.wantN, gotN, "Write(%v)", tt.args.p) }) } }