From: Ruben Beltran del Rio Date: Fri, 9 Dec 2022 20:46:57 +0000 (+0100) Subject: Remove unnecessary logging X-Git-Tag: 5.0.0~13 X-Git-Url: https://git.r.bdr.sh/rbdr/blog/commitdiff_plain/f91c2b4feb85933bc190712b45788d2f24fe851d Remove unnecessary logging --- diff --git a/lib/remote.js b/lib/remote.js index 569cd25..8b29c4e 100644 --- a/lib/remote.js +++ b/lib/remote.js @@ -11,22 +11,27 @@ const internals = { module.exports = { async add(remoteConfig, remote) { + await writeFile(remoteConfig, remote); }, async remove(remoteConfig) { + await rm(remoteConfig, { force: true }) }, async syncUp(remoteConfig, blogDirectory) { + await this._executeMethodOnStrategy(remoteConfig, 'syncUp', blogDirectory); }, async syncDown(remoteConfig, blogDirectory) { + await this._executeMethodOnStrategy(remoteConfig, 'syncDown', blogDirectory); }, async _executeMethodOnStrategy(remoteConfig, method, blogDirectory) { + const remote = await this._ensureConfiguration(remoteConfig); for (const strategy of internals.strategies) { @@ -37,6 +42,7 @@ module.exports = { }, async _ensureConfiguration(remoteConfig) { + try { const configuration = await readFile(remoteConfig, { encoding: 'utf8' }); return configuration; diff --git a/lib/remotes/git.js b/lib/remotes/git.js index 7a67462..11fdab8 100644 --- a/lib/remotes/git.js +++ b/lib/remotes/git.js @@ -1,48 +1,31 @@ const { exec } = require('child_process'); -const { debuglog, promisify } = require('util'); +const { promisify } = require('util'); const internals = { // Promisified functions exec: promisify(exec), - - debuglog: debuglog('blog'), }; module.exports = { canHandle() { + // For the future: actually check if it's a valid git url return true; }, async syncUp(remote, blogDirectory) { - let output = null; - - output = await internals.exec(`cd ${blogDirectory} && git init`); - internals.debuglog(output.stderr); - - output = await internals.exec(`cd ${blogDirectory} && git add .`); - internals.debuglog(output.stderr); - output = await internals.exec(`cd ${blogDirectory} && git commit --allow-empty -m blog-sync-up-${Date.now()}`); - internals.debuglog(output.stderr); - - output = await internals.exec(`cd ${blogDirectory} && git push ${remote} main --force`); - internals.debuglog(output.stderr); + await internals.exec(`cd ${blogDirectory} && git init`); + await internals.exec(`cd ${blogDirectory} && git add .`); + await internals.exec(`cd ${blogDirectory} && git commit --allow-empty -m blog-sync-up-${Date.now()}`); + await internals.exec(`cd ${blogDirectory} && git push ${remote} main --force`); }, async syncDown(remote, blogDirectory) { - let output = null; - - output = await internals.exec(`cd ${blogDirectory} && git init`); - internals.debuglog(output.stderr); - - output = await internals.exec(`cd ${blogDirectory} && git checkout .`); - internals.debuglog(output.stderr); - - output = await internals.exec(`cd ${blogDirectory} && git clean . -f`); - internals.debuglog(output.stderr); - output = await internals.exec(`cd ${blogDirectory} && git pull ${remote} main`); - internals.debuglog(output.stderr); + await internals.exec(`cd ${blogDirectory} && git init`); + await internals.exec(`cd ${blogDirectory} && git checkout .`); + await internals.exec(`cd ${blogDirectory} && git clean . -f`); + await internals.exec(`cd ${blogDirectory} && git pull ${remote} main`); } }