From f4cdaddcc62318dd1a10b4a287102762c41710e2 Mon Sep 17 00:00:00 2001
From: Jeff Halter <868228+jhalter@users.noreply.github.com>
Date: Tue, 8 Nov 2022 09:03:49 -0800
Subject: Fix overwrite of user info due to buffer re-use

---
 hotline/server.go | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

(limited to 'hotline')

diff --git a/hotline/server.go b/hotline/server.go
index 164b93e..bd15a2e 100644
--- a/hotline/server.go
+++ b/hotline/server.go
@@ -565,8 +565,13 @@ func (s *Server) handleNewConnection(ctx context.Context, rwc io.ReadWriteCloser
 
 	scanner.Scan()
 
+	// Make a new []byte slice and copy the scanner bytes to it.  This is critical to avoid a data race as the
+	// scanner re-uses the buffer for subsequent scans.
+	buf := make([]byte, len(scanner.Bytes()))
+	copy(buf, scanner.Bytes())
+
 	var clientLogin Transaction
-	if _, err := clientLogin.Write(scanner.Bytes()); err != nil {
+	if _, err := clientLogin.Write(buf); err != nil {
 		return err
 	}
 
-- 
cgit