From ee6629ad78ac62fa14371ea5ddb7474c1fe9c979 Mon Sep 17 00:00:00 2001 From: Jeff Halter <868228+jhalter@users.noreply.github.com> Date: Fri, 4 Jul 2025 17:24:02 -0700 Subject: Fix file handle close warnings by ignoring return values Updated all file close operations to use anonymous functions that ignore return values to satisfy golangci-lint errcheck warnings. --- hotline/files_test.go | 2 +- hotline/server.go | 4 ++-- hotline/tracker.go | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) (limited to 'hotline') diff --git a/hotline/files_test.go b/hotline/files_test.go index 0a7eb7b..9bed670 100644 --- a/hotline/files_test.go +++ b/hotline/files_test.go @@ -148,7 +148,7 @@ func TestCalcItemCount(t *testing.T) { if err != nil { t.Fatalf("Failed to create temp dir: %v", err) } - defer os.RemoveAll(tempDir) + defer func() { _ = os.RemoveAll(tempDir) }() // Create the test directory structure if err := createTestDirStructure(tempDir, tt.structure); err != nil { diff --git a/hotline/server.go b/hotline/server.go index 98b6132..19c7acc 100644 --- a/hotline/server.go +++ b/hotline/server.go @@ -235,7 +235,7 @@ func (s *Server) Serve(ctx context.Context, ln net.Listener) error { }) s.Logger.Info("Connection established", "ip", ipAddr) - defer conn.Close() + defer func() { _ = conn.Close() }() // Check if we have an existing rate limit for the IP and create one if we do not. rl, ok := s.rateLimiters[ipAddr] @@ -247,7 +247,7 @@ func (s *Server) Serve(ctx context.Context, ln net.Listener) error { // Check if the rate limit is exceeded and close the connection if so. if !rl.Allow() { s.Logger.Info("Rate limit exceeded", "RemoteAddr", conn.RemoteAddr()) - conn.Close() + _ = conn.Close() return } diff --git a/hotline/tracker.go b/hotline/tracker.go index 52963bf..edd973d 100644 --- a/hotline/tracker.go +++ b/hotline/tracker.go @@ -69,7 +69,7 @@ func register(dialer Dialer, tracker string, tr io.Reader) error { if err != nil { return fmt.Errorf("failed to dial tracker: %v", err) } - defer conn.Close() + defer func() { _ = conn.Close() }() if _, err := io.Copy(conn, tr); err != nil { return fmt.Errorf("failed to write to connection: %w", err) -- cgit