From de7d2b1d64a8c441db09de5cc3284d4fab0bd44b Mon Sep 17 00:00:00 2001
From: Jeff Halter <868228+jhalter@users.noreply.github.com>
Date: Mon, 21 Nov 2022 08:21:24 -0800
Subject: Fix mutex lock bug on invalid client

---
 hotline/server.go | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

(limited to 'hotline')

diff --git a/hotline/server.go b/hotline/server.go
index bd15a2e..e28ff9a 100644
--- a/hotline/server.go
+++ b/hotline/server.go
@@ -152,13 +152,12 @@ func (s *Server) sendTransaction(t Transaction) error {
 	}
 
 	s.mux.Lock()
+	defer s.mux.Unlock()
 	client := s.Clients[uint16(clientID)]
 	if client == nil {
 		return fmt.Errorf("invalid client id %v", *t.clientID)
 	}
 
-	s.mux.Unlock()
-
 	b, err := t.MarshalBinary()
 	if err != nil {
 		return err
-- 
cgit