mobius/hotline/news.go, branch mainFriendship Quest remix of mobius, a hotline server in go #clihttps://git.r.bdr.sh/mobius/atom/hotline/news.go?h=main2025-07-05T22:19:15ZAdd comprehensive test coverage for news.go functions2025-07-05T22:19:15ZJeff Halter868228+jhalter@users.noreply.github.com2025-07-05T22:19:15Zurn:sha1:b6bca2b7fe943ca4fd8f62a44bcfcc0c9f5a6de1
- Add table-driven tests for GetNewsArtListData, DataSize, NewsArtListData.Read, NewsArtList.Read, and newsPathScanner
- Improve test coverage from 0% to 87.5%-100% for these functions
- Add test for Field.DecodeNewsPath function
- Fix NewsArtList.Read to return nil instead of io.EOF for proper io.Reader behavior
- Add constants for NewsFlavorCount and improve code documentation
Replace inappropriate panic calls with proper error handling2025-06-30T22:24:19ZJeff Halter868228+jhalter@users.noreply.github.com2025-06-30T22:24:19Zurn:sha1:a9c6485fb00dbf2e4b55351c1ae74d4eaca3eec9
- Convert panic in news article processing to return error instead
- Replace panic in API stats endpoint with HTTP error response
- Update ThreadedNewsMgr interface to return errors from ListArticles
- Ensure server stability by handling errors gracefully
Extensive refactor, quality of life enhancements2024-07-17T22:42:37ZJeff Halter868228+jhalter@users.noreply.github.com2024-07-17T22:41:20Zurn:sha1:fd740bc499ebc6d3a381479316f74cdc736d02de
* Added ability to reload config, agreement, news, and user accounts without restarting the server by sending SIGHUP to the running process
* Added ability to use modern unix or windows line breaks in Agreement.txt and MessageBoard.txt instead of classic MacOS `\r` breaks.
* Extensive refactor towards swappable backends for the active server state
* Extensive refactored towards making the hotline package generic and re-usable for alternate server implemenations
* Fix bug where users whose accounts have been deleted would not be disconnected
Extensive refactor and clean up2024-07-10T04:42:05ZJeff Halter868228+jhalter@users.noreply.github.com2024-07-10T04:36:27Zurn:sha1:d9bc63a10d0978d9a5222cf7be74044e55f409b7Refactoring, cleanup, test backfilling2024-06-24T23:23:56ZJeff Halter868228+jhalter@users.noreply.github.com2024-06-24T23:23:56Zurn:sha1:a2ef262a164fc735b9b8471ac0c8001eea2b9bf6Fix broken io.Reader implementations2024-06-16T23:05:25ZJeff Halter868228+jhalter@users.noreply.github.com2024-06-16T23:03:54Zurn:sha1:0ed5132769e88cb385b5240986b706430f0ccd72Refactoring and cleanup2024-06-15T18:13:16ZJeff Halter868228+jhalter@users.noreply.github.com2024-06-15T18:13:16Zurn:sha1:95159e5585762c06c654945070ba54262b7dcec9
* Split CLI client into separate project
* Convert more functions to follow common Golang idioms e.g io.Reader, io.Writer
* Use ldflags for versioning
* Misc cleanup and simplification
Convert more bespoke methods to io.Reader/io.Writer interfaces2024-06-09T21:05:15ZJeff Halter868228+jhalter@users.noreply.github.com2024-06-09T20:56:29Zurn:sha1:9cf66aeafbcbb9237fedc2efc97cc2856eb60f7fMinor cleanup2023-01-21T16:54:12ZJeff Halter868228+jhalter@users.noreply.github.com2023-01-21T16:54:12Zurn:sha1:2d92d26e8abe2c368796e9d38c9ad87d0ac53df5Fix threaded news bugs2023-01-18T21:52:52ZJeff Halter868228+jhalter@users.noreply.github.com2023-01-18T21:52:52Zurn:sha1:3326539367dfa85cb2b0455d5b1c67eaaf59cf8e
1. Fix handling of article IDs sent as 4 bytes instead of 2
2. Fix incorrect article count listing that strangely only affects third party clients